Repository navigation
fix(agent pane): a followed chat reaches the end under Reduce Motion - #21955
Conversation
…der Reduce Motion (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ce Motion The pages' Reduce Motion rule sets transition-duration to 0.01ms on every element, and transition-property defaults to all, so the spacer's height lagged a frame behind and a followed view clamped short of the end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Receipt for
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
red: web / Web status; do not merge until green; see lane-rules |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by
Agents: |
|
Agents: |
|
Bead |
|
Found 10 test failures on Blacksmith runners: Failures
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
- regenerated Packages/macOS/CmuxNext/ci-target-graph.json - vp fmt webviews/src/agent-session/acpmux/replyHref.ts - vp fmt webviews/src/pages/markdown/README.md - vp fmt webviews/src/pages/markdown/links.ts - vp fmt webviews/test/markdown-cmux-app-links.test.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39212166835
…8099 # Conflicts: # webviews/src/agent-session/acpmux/replyHref.ts # webviews/src/pages/markdown/links.ts
|
Merged by the coord-2 rescue lane at the reviewed head. Every red on this head also fails on feat-cmux-next from the same morning, in unrelated PRs (#21697, #21729, #21623, #21272): cmux-next checks fails on Motion tokens at the base file TabCell+HibernationRing.swift:109, and react-apps-check fails on check-system-blue, composer-footer-plain, theme-colors and agent-pane-mode-keys. |
|
Shipped in:
|
Under Reduce Motion, a chat that follows new output could stop a little short of the end and stay there. The pages' shared Reduce Motion rule (`pages/shared/desktop.css`) sets `transition-duration: 0.01ms` on every element, and `transition-property` defaults to `all`, so the transcript spacer (the scroller's extent) transitioned its height for that 0.01ms. The followed view set its offset against the old height in the same frame and clamped short. `.acpmux-spacer` now has `transition: none`. The Reduce Motion rule's `!important` covers only duration, so it doesn't override this.
This came out of #21665, where it sat outside that PR's Debug toggle. It applies to everyone, so it ships on its own.
Testing
Changelog
Fixed: Under Reduce Motion, a chat following new output scrolls all the way to the end
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a followed chat stopping a bit short of the end and staying there under Reduce Motion.
The shared Reduce Motion rule sets
transition-duration: 0.01mson every element, andtransition-propertydefaults toall, so the transcript spacer transitioned its height for that frame while the followed view set its offset against the old height..acpmux-spacernow hastransition: none; the rule's!importantcovers only duration, so it doesn't override this. A new browser test loads the real stylesheets under emulated Reduce Motion and asserts no transition starts when the spacer grows.This PR also merges
feat-cmux-nextinto the branch.Written for commit 14810df. Summary will update on new commits.