[teamleaderleo]

Summary

The click-through lane found that ModelPickerCascade.tsx and ModelPickerDrill.tsx are mounted nowhere. The composer's model chip renders ModelPicker.tsx. This deletes the two layouts and everything only they used, 1,380 lines in all:

• Deleted files:
  • ModelPickerCascade.tsx, ModelPickerDrill.tsx
  • modelMenuNodes.tsx: pickerData, menuNodes, harnessNode and the recents landCombo path
  • MenuLevel.tsx, MenuRow.tsx, useMenuTree.ts
• CSS whose only users were those files:
  • In modelPicker.css: the cascade and drill blocks, breadcrumbs, the back button, the panel/detail/chevron/open/more/entry rows, the .acpmux-mp-sub animation, and the nested cascade popup surface.
  • In styles.css: .acpmux-menu-search* and .acpmux-menu-icon.
  • Before removing a class, I grepped src and test for any other use, including dynamically built class names.
• Also unused, found by review:
  • ModelPickerShell.tsx was already mounted nowhere.
  • acpmux's useHoverIntent.ts had no importers.
  • In modelPickerLayout.ts: useMenuHandle, ModelMenuProps, MenuHandle, the layout chooser (pickerLayout, PickerLayout, menuRoom) and the row constants.
  • Two stale comments.
• Removed their entries from gallery-coverage.allowlist.json and ui-rules.pending.json, along with the now-idle agent-session/acpmux/ModelPicker owner prefix.
• popup-surface.test.ts and popup-one-hairline.test.ts no longer list the cascade submenu's popup surface.

The dead path also had a latent bug, which goes with it: ComposerPickers passes onLand={(m) => land(m)}, which would drop a recent combo's effort. The prop still exists on the shipping picker's props type. I've left ComposerPickers.tsx alone because #21853 is editing it.

No visible change. The shipping picker uses none of these files or rules.

Testing

• bun test on popup-surface, popup-one-hairline, model-picker-height, new-tab-picker-clip, gallery-coverage and ui-rules: all pass (gallery-coverage passes once the idle owner prefix is removed).
• tsc --noEmit: no new errors. The one remaining error is the existing missing home-inbox-cloud-cases.json fixture.
• oxlint on src/agent-session/acpmux and test is clean.

Changelog

none

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: e3350bda-515b-4841-b661-63796ca4220d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 4bfee8e: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21930 -f ref=leo/drop-dead-model-pickers -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check (2) failed: no known signature; failed step: Check webviews (Oxlint, Oxfmt, type check).

CI failed on 4bfee8effb (run 39326158425 attempt 1): 3 unknown.

Job	Verdict	Why
web / react-apps-check (2)	unknown	no known signature; failed step: Check webviews (Oxlint, Oxfmt, type check)
web / react-apps-check (1)	unknown	no known signature; failed step: Check webviews (Oxlint, Oxfmt, type check)
web / react-apps-check	unknown	no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; do not merge until green; see lane-rules
red: web / react-apps-check; do not merge until green; see lane-rules
red: web / react-apps-check (1); do not merge until green; see lane-rules
red: web / react-apps-check (2); do not merge until green; see lane-rules

CI fast guards failed on 4bfee8effb (https://github.com/manaflow-ai/cmux/actions/runs/39326158425). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

[github-actions]

CI fast guards failed on c224cc7ecf (https://github.com/manaflow-ai/cmux/actions/runs/39201751394). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

[teamleaderleo]

Bead cx-fq1v0 created for this PR by the cmux coordinator.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
NEXT post-publication dependency contract/NEXT post-publication dependency contract	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[greptile-apps]

Confidence Score: 5/5

[Low impact] The PR appears safe to merge; the deleted picker paths have no surviving callers.

Summary

Removes the unused cascade, drill, and shell pickers, plus their helpers and CSS.

• Unused cascade and drill model-picker layouts are removed.

Acknowledgment: teamleaderleo explicitly left the existing recent-effort forwarding issue alone because another PR is editing ComposerPickers.tsx.

_{Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/fea..." · Reviewed by Greptile}

[teamleaderleo]

Verification at 4bfee8ef (base merged). Run on huge-blue with cd webviews && CMUX_BROWSER_TESTS=1 bun test <file>: tsc --noEmit 0, agent-pane build 0, and 24 picker/composer test files pass. That includes model-picker-picks 20/20, model-picker-composition, model-picker-height, popup-surface, text-field-focus 22/22 and composer-row-layout 27/27. Two fail the same way on base: composer-footer-plain 6 pass / 12 fail, and check-type-scale on syncMotion.gallery.css.

Base reds in CI: web / react-apps-check fails check:browser-lanes on agent-pane-older-rows-fade.test.ts from #20633. cmux-next checks fails on the state root in remote_host/config.rs:74, type scale and string tables, all outside this PR. This merges after #22005.

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.3934656011101 (d1e5410e03)
• cmux NEXT nightly 1.0.0-nightly.3934935376001 (fc1d07a5af)