Repository navigation
test(cmux-tui): an orphan-ended terminal respawns under a new incarnation (cx-6so.49) - #21926
Conversation
…tion (cx-6so.49) host_orphan's respawn check only asked for a running terminal with a surface, which an adoption of the old incarnation would also pass. It now records the incarnation before the daemon dies and waits for a new one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Receipt for
|
|
The one red, cmux-next checks › Motion tokens, flags Sources/CmuxNextSidebar/Views/SidebarCardTransition.swift, which this test-only PR doesn't touch. It was a base red, cleared on feat-cmux-next by #21951. Daemon tests and the hosted host_orphan run (Linux + macOS) pass. Merging. |
host_orphan::an_orphaned_host_exits_after_the_grace_and_a_served_one_does_notchecked the respawn from #20211 (cx-6so.49) by waiting for a running terminal with a surface. A plain adoption of the old incarnation would also pass that check, so it didn't prove a respawn. The test now records the terminal's incarnation before the daemon dies and waits for a different one after the restart, asterminal_respawn::wait_for_respawndoes.Test-only; no behavior change.
Changelog
none
Verification
scripts/verify-cmux-tui-hosted.sh --filter host_orphanat 78fc49c: Linux and macOS lint and tests passed (run 39201207364). A subagent review found no blocking issues.🤖 Generated with Claude Code