Skip to content

test(cmux-tui): an orphan-ended terminal respawns under a new incarnation (cx-6so.49) - #21926

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
leo/host-orphan-respawn-check
Oct 19, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
leo/host-orphan-respawn-check

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

host_orphan::an_orphaned_host_exits_after_the_grace_and_a_served_one_does_not checked the respawn from #20211 (cx-6so.49) by waiting for a running terminal with a surface. A plain adoption of the old incarnation would also pass that check, so it didn't prove a respawn. The test now records the terminal's incarnation before the daemon dies and waits for a different one after the restart, as terminal_respawn::wait_for_respawn does.

Test-only; no behavior change.

Changelog

none

Verification

scripts/verify-cmux-tui-hosted.sh --filter host_orphan at 78fc49c: Linux and macOS lint and tests passed (run 39201207364). A subagent review found no blocking issues.

🤖 Generated with Claude Code

…tion (cx-6so.49)

host_orphan's respawn check only asked for a running terminal with a
surface, which an adoption of the old incarnation would also pass. It
now records the incarnation before the daemon dies and waits for a new one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 19, 2026 04:47 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0e5982fd-9744-43a6-b43d-fc71d789f982

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Receipt for 78fc49c (this PR's head; a new push replaces it)

  • Visual review: HQ feed card · gallery before/after runs
  • Checks: this head
  • App of this head (app.zip, kept 1 day): gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21926 -f ref=leo/host-orphan-respawn-check -f platform=macos -f backend_mode=local

@blacksmith-sh

blacksmith-sh Bot commented Oct 19, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpomxlor_j/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpricbmoja/summary-missing.json (live):/summary-missing.json (live): View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

The one red, cmux-next checks › Motion tokens, flags Sources/CmuxNextSidebar/Views/SidebarCardTransition.swift, which this test-only PR doesn't touch. It was a base red, cleared on feat-cmux-next by #21951. Daemon tests and the hosted host_orphan run (Linux + macOS) pass. Merging.

@teamleaderleo
teamleaderleo merged commit 279dcc2 into feat-cmux-next Oct 19, 2026
@teamleaderleo
teamleaderleo deleted the leo/host-orphan-respawn-check branch October 19, 2026 07:02

This branch was previously deployed

2 inactive deployments
artifacts — 78fc49ce Deployed Oct 19, 2026 by teamleaderleo
cmux-tui-merge-tree — 78fc49ce Deployed Oct 19, 2026 by teamleaderleo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant