Skip to content

webviews: a gallery entry for the Chief picture crop - #21874

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix/gallery-picture-crop
Oct 19, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix/gallery-picture-crop

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

#21737 added pages/home-channels/PictureCrop.tsx without a gallery entry, so test/gallery-coverage.test.ts fails on feat-cmux-next itself. On a PR, that finding fails only PRs that touch the file or the home-channels gallery: #21623 and #21747 so far.

The Chief sheet shows the crop only after a file is chosen, so the page entry never reaches it. This adds a standalone entry, pages.home-channels.picture-crop, using the page's real strings and a sample still drawn as an inline SVG. It has three variants: wide, tall, and zoomed and moved. I added an entry instead of an allowlist line because the allowlist is meant to only shrink.

Verification

  • At fa5ed5c, the feat-cmux-next tip, bun test test/gallery-coverage.test.ts fails with + "pages/home-channels/PictureCrop.tsx#PictureCrop". With this change: 6 pass.
  • gallery-manifest and gallery-entry-store tests pass. bun run typecheck finds no type errors, and vp fmt --check is clean.
  • Not checked locally: how the entry renders. CI's gallery play renders every entry.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds a gallery entry for the Chief picture crop so gallery-coverage passes on feat-cmux-next. The component added in #21737 had no gallery entry, and since the crop only appears after a file is chosen, the page entry never covers it.

  • Adds pages.home-channels.picture-crop using the page's real strings and an inline SVG sample so drag and zoom are visible.
  • Provides landscape, portrait, and zoomed-and-moved variants.
  • Adds an entry instead of an allowlist line because the allowlist is meant to only shrink.

Written for commit 297f856. Summary will update on new commits.

View guided diff Turn on auto-fix

#21737 added pages/home-channels/PictureCrop.tsx with no gallery entry, so
gallery-coverage is red on feat-cmux-next itself (and on every PR that touches
the home-channels gallery). The Chief sheet shows the crop only after a file is
chosen, so the page entry never reaches it: a standalone entry with a sample
still, wide, tall and zoomed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ee639af5-23d3-4bb3-af9f-ce3b176ebb01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Receipt for 297f856 (this PR's head; a new push replaces it)

  • Visual review: HQ feed card · gallery before/after runs
  • Checks: this head
  • App of this head (app.zip, kept 1 day): gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21874 -f ref=fix/gallery-picture-crop -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-9swda created for this PR by the cmux coordinator.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

red: web / Web status; do not merge until green; see lane-rules
red: web / react-apps-check; do not merge until green; see lane-rules
red: web / react-apps-check (2); do not merge until green; see lane-rules

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check (2) failed: no known signature; failed step: Test webviews.

CI failed on 297f856deb (run 39192565939 attempt 1): 2 unknown.

Job Verdict Why
web / react-apps-check (2) unknown no known signature; failed step: Test webviews
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check (2), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards failed on 297f856deb (https://github.com/manaflow-ai/cmux/actions/runs/39192565939). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

@blacksmith-sh

blacksmith-sh Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Found 5 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp3tvx5jhy/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmp7szetk2s/summary-fail.json (live):/summary-fail.json (live): View Logs
test/static-status-loops.test.ts/static-status-loops.test View Logs
test/static-status-loops.test.ts/static-status-loops.test View Logs
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)/
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 4f9b4a6 into feat-cmux-next Oct 19, 2026
118 of 126 checks passed
@teamleaderleo
teamleaderleo deleted the fix/gallery-picture-crop branch October 19, 2026 03:20
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant