Repository navigation
webviews: a gallery entry for the Chief picture crop - #21874
Conversation
#21737 added pages/home-channels/PictureCrop.tsx with no gallery entry, so gallery-coverage is red on feat-cmux-next itself (and on every PR that touches the home-channels gallery). The Chief sheet shows the crop only after a file is chosen, so the page entry never reaches it: a standalone entry with a sample still, wide, tall and zoomed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Receipt for
|
|
Bead |
|
red: web / Web status; do not merge until green; see lane-rules |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Unclear: CI failed on
Not re-run automatically: Written by |
|
Agents: |
|
Found 5 test failures on Blacksmith runners: Failures
|
|
Shipped in:
|
#21737 added
pages/home-channels/PictureCrop.tsxwithout a gallery entry, sotest/gallery-coverage.test.tsfails on feat-cmux-next itself. On a PR, that finding fails only PRs that touch the file or the home-channels gallery: #21623 and #21747 so far.The Chief sheet shows the crop only after a file is chosen, so the page entry never reaches it. This adds a standalone entry,
pages.home-channels.picture-crop, using the page's real strings and a sample still drawn as an inline SVG. It has three variants: wide, tall, and zoomed and moved. I added an entry instead of an allowlist line because the allowlist is meant to only shrink.Verification
bun test test/gallery-coverage.test.tsfails with+ "pages/home-channels/PictureCrop.tsx#PictureCrop". With this change: 6 pass.gallery-manifestandgallery-entry-storetests pass.bun run typecheckfinds no type errors, andvp fmt --checkis clean.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds a gallery entry for the Chief picture crop so
gallery-coveragepasses onfeat-cmux-next. The component added in #21737 had no gallery entry, and since the crop only appears after a file is chosen, the page entry never covers it.pages.home-channels.picture-cropusing the page's real strings and an inline SVG sample so drag and zoom are visible.Written for commit 297f856. Summary will update on new commits.