Repository navigation
acpmux: record the PRs each session opens; the sidebar session tree counts them all - #21823
Merged
teamleaderleo merged 15 commits intoOct 19, 2026
Conversation
Red: pullRequests is absent, so the summary has [] (no detector yet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ion tree counts them A tool call whose command runs `gh pr create` is remembered until it ends; the github.com pull URLs its output prints join SessionMeta.pull_requests, once each, and SessionSummary exposes them as optional pullRequests. CmuxNext parses them on AgentActivityLane and SidebarSessionTreeFeed reads each with `gh pr view <url>` beside the folder's branch PR, counting each pull request once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Found 28 test failures on Blacksmith runners: Failures
...and 18 more test failures. View all on Blacksmith
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
teamleaderleo
temporarily deployed
to
artifacts
October 19, 2026 00:07 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Probably yours: CI failed on
Matched log linesNot re-run automatically: Written by
|
Contributor
|
|
…g' into feat/acpmux-session-pull-requests # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextAgentLanes/SidebarSessionTreeFeed.swift # Packages/macOS/CmuxNext/Sources/CmuxNextApp/AgentChatPullRequest.swift
teamleaderleo
temporarily deployed
to
artifacts
October 19, 2026 00:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
…and only the URL it prints Review fixes for #21823: a grep or echo mentioning gh pr create, or a chained gh pr create && gh pr view 9, no longer records links. The command is parsed (quotes, $( ), heredocs) and must be gh pr create after cd steps and env prefixes; only the last output line that is just a pull URL is kept, preferring rawOutput.stdout when the harness separates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
temporarily deployed
to
artifacts
October 19, 2026 04:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 19, 2026 05:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
3 tasks done
gh exits 1 when the branch already has a pull request and prints its URL; that call opened nothing. Review nit from coord-2 on #21823. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
temporarily deployed
to
artifacts
October 19, 2026 05:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 19, 2026 05:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
…g' into feat/acpmux-session-pull-requests # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextAgentActivity/AgentActivityLane.swift # cmux-tui/crates/acpmux/tests/fake_agent.py Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g' into feat/acpmux-session-pull-requests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A harness that streams gh's "already exists: URL" in an in_progress update before the failed one recorded that pull request; the URL is now held per call and recorded on completed only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…g' into feat/acpmux-session-pull-requests
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Red: a bare & splits `2>&1` and `&>file` into two commands, and only cd may precede gh, so the usual `git push && gh pr create --fill 2>&1` is never recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
A redirect's & (2>&1, >&2, &>file) no longer splits the command, and steps joined to gh by && may precede it, so `git push && gh pr create --fill 2>&1` records its pull request. ;, ||, | and & before gh still don't count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # cmux-tui/crates/acpmux/src/hub/views.rs # cmux-tui/crates/acpmux/src/protocol/session.rs # cmux-tui/crates/acpmux/src/store.rs
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…adge (#21959) * cmux NEXT sidebar: pull request hover card on the session tree's PR badge Hovering a row's pull request badge lists each pull request its sessions opened (acpmux pullRequests plus the folder's branch PR), newest first: title, a state pill (Conflict / Checks failed / Checks passing / Draft / Merged / Closed), owner/repo #N and +adds -dels; a click opens it in the focused pane's browser. It scrolls past eight lines. The badge gains a red failing status. Live state comes from one batched gh api graphql read per refresh (aliased pullRequest fields, 50 per query) instead of one gh pr view per URL. Debug Settings toggle sidebar.pullRequestCard, on by default; native gallery entry with conflict, checks-failed, mixed, all-merged and empty fixtures; strings in 21 locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card review fixes A failed GraphQL read keeps the last answers (only a null alias clears one); the query pins --hostname github.com and other hosts fall back to gh pr view per URL; the card follows its badge when the row is reused or its pull requests change; a hidden badge never makes the panel and resets its hover; the workspace card and the pull request card dismiss each other; rows take first mouse; same-moment pull requests list by number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card opens only PR pages; settled PRs are read once; failing reads back off The card opens a URL only when it is https://github.com (or the user's GH_HOST) /<owner>/<repo>/pull/<n> with nothing else. A merged or closed PR's URL is not asked again; a URL whose read failed waits freshness doubled per failure, up to 16x. Failed checks show red before a conflict. Review fixes from coord-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: import Foundation for the PR item host check (ProcessInfo, URLComponents) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the PR store re-reads open PRs on its own, re-asks closed ones, and keeps answers on partial GraphQL errors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: re-read open PRs every five minutes while shown, re-ask closed ones, keep answers on partial GraphQL errors Review findings on #21814/#21959: a badge never refreshed once its session went idle, so CI that failed later stayed green; a reopened PR never came back; an SSO or resource-limit error nulled good answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): only an open pull request keeps the sidebar's recheck Red: a folder never settles, so with the tree on the store re-reads every folder every five minutes, branches with no pull request included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar rechecks only open pull requests, and forgets unshown ones - The five-minute recheck stays armed only while the tree shows an open or draft pull request. A folder never settled, so before this every session folder was re-read with gh every five minutes, branches without a pull request included. - Answers, read times and failure counts for folders and URLs the tree no longer shows are dropped on each pass instead of growing for the app's life. - The card's state pill uses Metrics.chipCornerRadius, not a capsule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
 [Medium impact] The change reaches session summaries and the macOS sidebar’s pull-request display. The PR needs the ownership, test-access, collection-scan, and failing-test fixes before merging. Findings
SummaryRecords PRs opened by session shell calls and includes them in the sidebar's PR count.
No tests or native UI captures were run during this review. Native AppKit capture was unavailable in the Linux environment. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart LR
A["Shell tool call and result"] --> B["Detect successful gh pr create"]
B --> C["Save session PR URLs"]
C --> D["Session summary"]
D --> E["AgentActivityLane"]
E --> F["Collect folders and opened URLs"]
F --> G["Read PR details"]
G --> H["Deduplicate by PR URL"]
H --> I["Sidebar badge and hover card"]
Reviews (1) · Last reviewed commit: "cmux NEXT sidebar: pull request hover ca..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| /// card leaves the badge to it (`WorkspaceHoverCardController.hoverCardHit`). | ||
| @MainActor | ||
| final class SidebarPullRequestCardController { | ||
| static let shared = SidebarPullRequestCardController() |
Contributor
There was a problem hiding this comment.
SidebarPullRequestCardController.shared adds a singleton that owns the panel, hovered badge, and open callback. This violates the repository rule requiring new runtime state to have a scoped, injectable owner. Construct the controller on the sidebar owner and pass it to the badge and workspace hover card.
Rule Used: Flag new ambient global state in production Swift: a top-level (file-scope) func used as API, a top-level mutable var or a stub class/struct holding a global flag/once-token, a caseless enum/empty struct used purely as a static func/static let namesp... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Comment on lines
+206
to
+207
| /// Whether the five-minute recheck is pending. | ||
| var rechecks: Bool { recheck.isScheduled } |
Contributor
There was a problem hiding this comment.
rechecks exposes the private timer's state solely for tests. This violates the repository rule against test-only accessors under Sources/. Remove the wrapper, make recheck internal, and let the test read recheck.isScheduled through @testable import.
Rule Used: Flag Swift files under a production Sources path (matching /Sources/ and not under /Tests/) that add a test-only or debug-only seam: a #if DEBUG (or other test-build-guarded) extension/member exposing internal state only for tests or a debugg... (source)
| static func asks(_ lanes: [AgentActivityLane]) -> [String] { | ||
| let folders = Set(lanes.compactMap(\.cwd)).sorted() | ||
| var opened: [String] = [] | ||
| for url in lanes.flatMap(\.pullRequests) where !opened.contains(url) { opened.append(url) } |
Contributor
There was a problem hiding this comment.
asks(_:) scans the growing opened array for every URL. Duplicate removal therefore takes quadratic work across a workspace's sessions, on the main actor whenever the feed updates. This violates the repository rule against nested scans of user-owned collections. Keep a Set<String> for membership and append only when insertion succeeds.
Suggested change
| for url in lanes.flatMap(\.pullRequests) where !opened.contains(url) { opened.append(url) } | |
| var seen: Set<String> = [] | |
| for url in lanes.flatMap(\.pullRequests) where seen.insert(url).inserted { opened.append(url) } |
Rule Used: Flag production code that adds nested full-collection scans, per-target rescans for batch actions, repeated sort/filter/map work in hot UI/socket/search/process paths, in-memory joins that belong in the data store, or unbenchmarked slower algorithms ... (source)
| #expect(seven.mergeable == "conflicting") | ||
| #expect(seven.checks == .init(state: "failing", passed: 1, total: 2)) | ||
| #expect((seven.additions, seven.deletions) == (120, 8)) | ||
| #expect(SidebarSessionTreeFeed.item(seven).state == .conflict) |
Contributor
There was a problem hiding this comment.
aGraphQLAnswerReadsAsGhPrViewDoes expects .conflict for a PR whose checks are failing. item(_:) deliberately returns .failing before checking for a conflict, so this assertion cannot pass. Change the expectation to .failing to match the documented red-before-orange behavior.
Suggested change
| #expect(SidebarSessionTreeFeed.item(seven).state == .conflict) | |
| #expect(SidebarSessionTreeFeed.item(seven).state == .failing) |
Comment on lines
+96
to
+97
| commits(last: 1) { nodes { commit { statusCheckRollup { contexts(first: 100) { nodes { __typename \ | ||
| ... on CheckRun { name status conclusion detailsUrl } ... on StatusContext { context state targetUrl } } } } } } } |
Contributor
There was a problem hiding this comment.
The new GraphQL query reads only the first 100 check results, then treats that page as the complete result. If a PR has more checks and a later check fails, the sidebar can show it as passing. Read the rollup's overall state for the badge, or fetch all pages before deciding that checks passed.
Comment on lines
+195
to
+198
| for url in urls { | ||
| guard let answer = read[url] else { | ||
| failures[url, default: 0] += 1 | ||
| continue |
Contributor
There was a problem hiding this comment.
A URL whose first read fails gets no automatic retry when none of the other shown keys has an open answer. refresh(_:) cancels the timer before the read, and the failed read only updates the ignored failures dictionary. The badge can stay missing after the network recovers. Schedule a retry for unanswered URLs using their backoff, not only for URLs already known to be open.
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
![cmux-autofix[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…essionTree, off by default) (#21814) * cmux NEXT sidebar: session tree with pull request badges and keycaps (sidebar.sessionTree) Claude desktop's Code tab, behind a setting that is off by default: a workspace whose agent another workspace's agent started (acpmux spawnedBy) lists under it on a thin guide line, each row carries its pull requests (the branch PR of each session folder, as the chat header's chip reads it) in a green, orange or purple badge, and the first rows show their Command-number keycaps. The Command-1...9 order follows the drawn order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT media: the core tour turns on the session tree last Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 9bee46b - regenerated webviews/src/pages/settings/generated/strings.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39176969610 * cmux NEXT sidebar: the session tree feed lives in CmuxNextAgentLanes CmuxNextApp may not grow: the feed moves to CmuxNextAgentLanes (the app passes its workspaces), and the gh pull request reader moves next to its model in CmuxNextAgentPane so the chat chip and the sidebar share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: CI target graph for CmuxNextAgentLanes' new dependencies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: review fixes for the session tree The moved gh reader's process holder carries its reviewed crash-allow (only the thread-safe isRunning and terminate() cross threads), and the sidebar asks each folder's pull request at most every five minutes, so it never stalls the chat header's chip on the two shared gh slots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): settings exports for sidebar.sessionTree Generated only: the fleet settings export (cmux-ci step b05e67a26082185e11778f94, run-swift-testing-suites.sh export-settings at 7ad7c4e; CmuxNextSettings is unchanged since), the defaults snapshot (defaults_guard.py snapshot) and the settings page strings (gen-strings.mjs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: CI target graph keeps CmuxNextAgentLanes' dependencies after the base merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): settings exports for sidebar.sessionTree after the base merge Generated only: the fleet settings export (cmux-ci step 69f7e53cebcd649429577bcd, run-swift-testing-suites.sh export-settings at 215bf61; CmuxNextSettings is unchanged since), the defaults snapshot (defaults_guard.py snapshot) and the settings page strings (gen-strings.mjs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): lower the type-scale baseline for BrowserPopupPanel (base red: it no longer has raw font sizes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux-next tour: turn sidebar.sessionTree back off after its step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): close the #require calls in the session tree lane test The base merge in 08374a3 left both try #require(AgentActivityLane.of(...)) calls without their closing parenthesis, so CmuxNextAppTests did not build (fast tier: "the tests do not build"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the Markdown viewer test host implements FilePageHosting.openAppLink (base red: CmuxNextAppTests did not build) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at f2d34a4 - regenerated docs/mdm/com.manaflow.cmux.json - regenerated docs/mdm/com.manaflow.cmux.plist - regenerated docs/mdm/managed-preferences.md - regenerated schemas/settings-export/settings-schema.sources.sha256 - regenerated schemas/settings/settings-schema.json - regenerated Packages/macOS/CmuxNext/ci-target-graph.json - regenerated web/data/cmux-shortcuts.generated.json - regenerated cmux-tui/crates/cmux-app-host/generated/cmux-app.d.ts - regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39215245191 * acpmux: record the PRs each session opens; the sidebar session tree counts them all (#21823) * acpmux: test that a session lists the pull requests gh pr create opened Red: pullRequests is absent, so the summary has [] (no detector yet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: record the pull requests each session opens; the sidebar session tree counts them A tool call whose command runs `gh pr create` is remembered until it ends; the github.com pull URLs its output prints join SessionMeta.pull_requests, once each, and SessionSummary exposes them as optional pullRequests. CmuxNext parses them on AgentActivityLane and SidebarSessionTreeFeed reads each with `gh pr view <url>` beside the folder's branch PR, counting each pull request once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: count only a shell call whose whole command is gh pr create, and only the URL it prints Review fixes for #21823: a grep or echo mentioning gh pr create, or a chained gh pr create && gh pr view 9, no longer records links. The command is parsed (quotes, $( ), heredocs) and must be gh pr create after cd steps and env prefixes; only the last output line that is just a pull URL is kept, preferring rawOutput.stdout when the harness separates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: a failed gh pr create records no pull request gh exits 1 when the branch already has a pull request and prints its URL; that call opened nothing. Review nit from coord-2 on #21823. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(acpmux): a gh pr create URL counts only once its call completes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: a gh pr create URL counts only when its call completes A harness that streams gh's "already exists: URL" in an in_progress update before the failed one recorded that pull request; the URL is now held per call and recorded on completed only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): AgentActivityLane.of takes no title Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(acpmux): gh pr create counts after && steps and with 2>&1 Red: a bare & splits `2>&1` and `&>file` into two commands, and only cd may precede gh, so the usual `git push && gh pr create --fill 2>&1` is never recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: gh pr create counts after && steps and with 2>&1 A redirect's & (2>&1, >&2, &>file) no longer splits the command, and steps joined to gh by && may precede it, so `git push && gh pr create --fill 2>&1` records its pull request. ;, ||, | and & before gh still don't count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request hover card on the session tree's PR badge (#21959) * cmux NEXT sidebar: pull request hover card on the session tree's PR badge Hovering a row's pull request badge lists each pull request its sessions opened (acpmux pullRequests plus the folder's branch PR), newest first: title, a state pill (Conflict / Checks failed / Checks passing / Draft / Merged / Closed), owner/repo #N and +adds -dels; a click opens it in the focused pane's browser. It scrolls past eight lines. The badge gains a red failing status. Live state comes from one batched gh api graphql read per refresh (aliased pullRequest fields, 50 per query) instead of one gh pr view per URL. Debug Settings toggle sidebar.pullRequestCard, on by default; native gallery entry with conflict, checks-failed, mixed, all-merged and empty fixtures; strings in 21 locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card review fixes A failed GraphQL read keeps the last answers (only a null alias clears one); the query pins --hostname github.com and other hosts fall back to gh pr view per URL; the card follows its badge when the row is reused or its pull requests change; a hidden badge never makes the panel and resets its hover; the workspace card and the pull request card dismiss each other; rows take first mouse; same-moment pull requests list by number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card opens only PR pages; settled PRs are read once; failing reads back off The card opens a URL only when it is https://github.com (or the user's GH_HOST) /<owner>/<repo>/pull/<n> with nothing else. A merged or closed PR's URL is not asked again; a URL whose read failed waits freshness doubled per failure, up to 16x. Failed checks show red before a conflict. Review fixes from coord-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: import Foundation for the PR item host check (ProcessInfo, URLComponents) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the PR store re-reads open PRs on its own, re-asks closed ones, and keeps answers on partial GraphQL errors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: re-read open PRs every five minutes while shown, re-ask closed ones, keep answers on partial GraphQL errors Review findings on #21814/#21959: a badge never refreshed once its session went idle, so CI that failed later stayed green; a reopened PR never came back; an SSO or resource-limit error nulled good answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): only an open pull request keeps the sidebar's recheck Red: a folder never settles, so with the tree on the store re-reads every folder every five minutes, branches with no pull request included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar rechecks only open pull requests, and forgets unshown ones - The five-minute recheck stays armed only while the tree shows an open or draft pull request. A folder never settled, so before this every session folder was re-read with gh every five minutes, branches without a pull request included. - Answers, read times and failure counts for folders and URLs the tree no longer shows are dropped on each pass instead of growing for the app's life. - The card's state pill uses Metrics.chipCornerRadius, not a capsule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): take the base's generated files and Markdown test host after the merge The merge kept stale copies of the shortcuts export, the devbox rebake list and the agent-session spec, and a second openAppLink in the test host. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * generated: restore base's shortcuts export (a stale autofix dropped paletteKey.toggleActions) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): keep the base's hook status conflicts (#21813) after the stack merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 4e00ea2 - vp fmt webviews/src/sidebar/SidebarPullRequestCard.gallery.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39315375602 * chore(next): rerun the PR autofix so it regenerates the settings exports The last head was an autofix commit, which the autofix skips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 014d9cc - regenerated docs/mdm/com.manaflow.cmux.json - regenerated docs/mdm/com.manaflow.cmux.plist - regenerated docs/mdm/managed-preferences.md - regenerated schemas/settings-export/settings-schema.sources.sha256 - regenerated schemas/settings/settings-schema.json - regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39321341168 * test(next): the sidebar's PR recheck reads only open pull requests A recheck called refresh(shown), which also re-read every folder without a pull request every five minutes while one open PR showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar's PR recheck reads only open pull requests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 4dd489e - docs/mdm/com.manaflow.cmux.json - docs/mdm/com.manaflow.cmux.plist - docs/mdm/managed-preferences.md - schemas/defaults/cmux-next.json - schemas/settings-export/settings-schema.sources.sha256 - schemas/settings/settings-schema.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39359164603 * cmux NEXT sidebar: the pull requests card is an owned card in the one hover card window Base deleted SidebarUpdateNotesPanel (5cac4de, one morphing sidebar card), which the PR card used as its window, so the merge did not compile. The card now shows through HoverCardCoordinator.presentOwned, as the update highlights do: it takes clicks and scrolls, a workspace card that shows morphs into it, and a row the pointer reaches next takes the card back, so the manual dismissals between the two cards go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux-next: AppServices reads the gh path from the moved PR reader (package access) Base made CmuxNextApp call AgentChatPullRequestReader.findGitHubCLI(); this PR moves the reader into CmuxNextAgentPane, where the method was internal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Leave ci-target-graph.json to the base autofix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-autofix[bot] <cmux-autofix[bot]@users.noreply.github.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
…on tree (#22323) * cmux NEXT sidebar: session tree with pull request badges and keycaps (sidebar.sessionTree) Claude desktop's Code tab, behind a setting that is off by default: a workspace whose agent another workspace's agent started (acpmux spawnedBy) lists under it on a thin guide line, each row carries its pull requests (the branch PR of each session folder, as the chat header's chip reads it) in a green, orange or purple badge, and the first rows show their Command-number keycaps. The Command-1...9 order follows the drawn order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT media: the core tour turns on the session tree last Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 9bee46b - regenerated webviews/src/pages/settings/generated/strings.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39176969610 * cmux NEXT sidebar: the session tree feed lives in CmuxNextAgentLanes CmuxNextApp may not grow: the feed moves to CmuxNextAgentLanes (the app passes its workspaces), and the gh pull request reader moves next to its model in CmuxNextAgentPane so the chat chip and the sidebar share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: CI target graph for CmuxNextAgentLanes' new dependencies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: review fixes for the session tree The moved gh reader's process holder carries its reviewed crash-allow (only the thread-safe isRunning and terminate() cross threads), and the sidebar asks each folder's pull request at most every five minutes, so it never stalls the chat header's chip on the two shared gh slots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): settings exports for sidebar.sessionTree Generated only: the fleet settings export (cmux-ci step b05e67a26082185e11778f94, run-swift-testing-suites.sh export-settings at 7ad7c4e; CmuxNextSettings is unchanged since), the defaults snapshot (defaults_guard.py snapshot) and the settings page strings (gen-strings.mjs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: CI target graph keeps CmuxNextAgentLanes' dependencies after the base merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): settings exports for sidebar.sessionTree after the base merge Generated only: the fleet settings export (cmux-ci step 69f7e53cebcd649429577bcd, run-swift-testing-suites.sh export-settings at 215bf61; CmuxNextSettings is unchanged since), the defaults snapshot (defaults_guard.py snapshot) and the settings page strings (gen-strings.mjs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): lower the type-scale baseline for BrowserPopupPanel (base red: it no longer has raw font sizes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux-next tour: turn sidebar.sessionTree back off after its step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): close the #require calls in the session tree lane test The base merge in 08374a3 left both try #require(AgentActivityLane.of(...)) calls without their closing parenthesis, so CmuxNextAppTests did not build (fast tier: "the tests do not build"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the Markdown viewer test host implements FilePageHosting.openAppLink (base red: CmuxNextAppTests did not build) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at f2d34a4 - regenerated docs/mdm/com.manaflow.cmux.json - regenerated docs/mdm/com.manaflow.cmux.plist - regenerated docs/mdm/managed-preferences.md - regenerated schemas/settings-export/settings-schema.sources.sha256 - regenerated schemas/settings/settings-schema.json - regenerated Packages/macOS/CmuxNext/ci-target-graph.json - regenerated web/data/cmux-shortcuts.generated.json - regenerated cmux-tui/crates/cmux-app-host/generated/cmux-app.d.ts - regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39215245191 * acpmux: record the PRs each session opens; the sidebar session tree counts them all (#21823) * acpmux: test that a session lists the pull requests gh pr create opened Red: pullRequests is absent, so the summary has [] (no detector yet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: record the pull requests each session opens; the sidebar session tree counts them A tool call whose command runs `gh pr create` is remembered until it ends; the github.com pull URLs its output prints join SessionMeta.pull_requests, once each, and SessionSummary exposes them as optional pullRequests. CmuxNext parses them on AgentActivityLane and SidebarSessionTreeFeed reads each with `gh pr view <url>` beside the folder's branch PR, counting each pull request once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: count only a shell call whose whole command is gh pr create, and only the URL it prints Review fixes for #21823: a grep or echo mentioning gh pr create, or a chained gh pr create && gh pr view 9, no longer records links. The command is parsed (quotes, $( ), heredocs) and must be gh pr create after cd steps and env prefixes; only the last output line that is just a pull URL is kept, preferring rawOutput.stdout when the harness separates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: a failed gh pr create records no pull request gh exits 1 when the branch already has a pull request and prints its URL; that call opened nothing. Review nit from coord-2 on #21823. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(acpmux): a gh pr create URL counts only once its call completes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: a gh pr create URL counts only when its call completes A harness that streams gh's "already exists: URL" in an in_progress update before the failed one recorded that pull request; the URL is now held per call and recorded on completed only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): AgentActivityLane.of takes no title Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(acpmux): gh pr create counts after && steps and with 2>&1 Red: a bare & splits `2>&1` and `&>file` into two commands, and only cd may precede gh, so the usual `git push && gh pr create --fill 2>&1` is never recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: gh pr create counts after && steps and with 2>&1 A redirect's & (2>&1, >&2, &>file) no longer splits the command, and steps joined to gh by && may precede it, so `git push && gh pr create --fill 2>&1` records its pull request. ;, ||, | and & before gh still don't count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request hover card on the session tree's PR badge (#21959) * cmux NEXT sidebar: pull request hover card on the session tree's PR badge Hovering a row's pull request badge lists each pull request its sessions opened (acpmux pullRequests plus the folder's branch PR), newest first: title, a state pill (Conflict / Checks failed / Checks passing / Draft / Merged / Closed), owner/repo #N and +adds -dels; a click opens it in the focused pane's browser. It scrolls past eight lines. The badge gains a red failing status. Live state comes from one batched gh api graphql read per refresh (aliased pullRequest fields, 50 per query) instead of one gh pr view per URL. Debug Settings toggle sidebar.pullRequestCard, on by default; native gallery entry with conflict, checks-failed, mixed, all-merged and empty fixtures; strings in 21 locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card review fixes A failed GraphQL read keeps the last answers (only a null alias clears one); the query pins --hostname github.com and other hosts fall back to gh pr view per URL; the card follows its badge when the row is reused or its pull requests change; a hidden badge never makes the panel and resets its hover; the workspace card and the pull request card dismiss each other; rows take first mouse; same-moment pull requests list by number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card opens only PR pages; settled PRs are read once; failing reads back off The card opens a URL only when it is https://github.com (or the user's GH_HOST) /<owner>/<repo>/pull/<n> with nothing else. A merged or closed PR's URL is not asked again; a URL whose read failed waits freshness doubled per failure, up to 16x. Failed checks show red before a conflict. Review fixes from coord-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: import Foundation for the PR item host check (ProcessInfo, URLComponents) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the PR store re-reads open PRs on its own, re-asks closed ones, and keeps answers on partial GraphQL errors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: re-read open PRs every five minutes while shown, re-ask closed ones, keep answers on partial GraphQL errors Review findings on #21814/#21959: a badge never refreshed once its session went idle, so CI that failed later stayed green; a reopened PR never came back; an SSO or resource-limit error nulled good answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): only an open pull request keeps the sidebar's recheck Red: a folder never settles, so with the tree on the store re-reads every folder every five minutes, branches with no pull request included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar rechecks only open pull requests, and forgets unshown ones - The five-minute recheck stays armed only while the tree shows an open or draft pull request. A folder never settled, so before this every session folder was re-read with gh every five minutes, branches without a pull request included. - Answers, read times and failure counts for folders and URLs the tree no longer shows are dropped on each pass instead of growing for the app's life. - The card's state pill uses Metrics.chipCornerRadius, not a capsule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): take the base's generated files and Markdown test host after the merge The merge kept stale copies of the shortcuts export, the devbox rebake list and the agent-session spec, and a second openAppLink in the test host. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * generated: restore base's shortcuts export (a stale autofix dropped paletteKey.toggleActions) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): keep the base's hook status conflicts (#21813) after the stack merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 4e00ea2 - vp fmt webviews/src/sidebar/SidebarPullRequestCard.gallery.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39315375602 * chore(next): rerun the PR autofix so it regenerates the settings exports The last head was an autofix commit, which the autofix skips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 014d9cc - regenerated docs/mdm/com.manaflow.cmux.json - regenerated docs/mdm/com.manaflow.cmux.plist - regenerated docs/mdm/managed-preferences.md - regenerated schemas/settings-export/settings-schema.sources.sha256 - regenerated schemas/settings/settings-schema.json - regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39321341168 * test(next): the sidebar's PR recheck reads only open pull requests A recheck called refresh(shown), which also re-read every folder without a pull request every five minutes while one open PR showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar's PR recheck reads only open pull requests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(next): sidebar chat history and pinning under the session tree With sidebar.sessionTree on (default unchanged), chats stay in the sidebar after their workspace closes: a Pinned block above the workspaces and a calm, foldable Earlier block under them, 20 at a time with Show More. Built from acpmux's chat index metadata only (no transcript loads), read lazily so it stays cheap with thousands of chats. A row resumes its chat through the shared Open Chat path; its right-click menu pins or unpins it. Pins and the Earlier fold persist in UserDefaults. No project grouping. hq#2569 gap #6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar chat history: Pin/Unpin runs a registered action; Earlier animates through Motion.sidebar - SidebarChatHistoryView placed the blocks with Motion.animate(.move, in:), which base removed (every animation names its category now); it uses Motion.sidebar.animate, like the rest of the sidebar. - A history row's Pin/Unpin menu ran its own selector, which check-menu-actions.py rejects. The row's menu now comes from ActionRegistry.makeContextMenu(for: .sidebarItem, target: sidebar-item:<chat key>, entries: [sidebar.chat.togglePin]), retitled Pin or Unpin for the row's chat. SidebarChatHistoryFeed.bind binds the action to the history's pins; the App binds it where it starts the feed. New action title in all 21 locales; generated action exports are left to the autofix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray * SidebarChatHistoryFeed: import Observation publicly The public @observable class's conformance needs the module imported publicly (fleet app compile, job bea228bd3cfa). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray * Keep the sidebar string catalog in base's key order (content unchanged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray * Sidebar history: the row menu hook lives on SidebarChatHistory, not an all-static enum The conventions check refused the namespace enum SidebarChatHistoryMenu. The menu factory is now an instance hook on the history the rows already read, like onOpen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray * Sidebar history: a group fold lays the list out again while the history blocks show The fold splice moved the rows but not pinnedChatsY/earlierChatsY, so opening a group pushed workspace rows under Earlier and closing one left a gap. With either block placed, SidebarLayout.fold now declines and the list takes its full layout. Test included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-autofix[bot] <cmux-autofix[bot]@users.noreply.github.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 22, 2026
…l-ups (#21836) * cmux NEXT sidebar: session tree with pull request badges and keycaps (sidebar.sessionTree) Claude desktop's Code tab, behind a setting that is off by default: a workspace whose agent another workspace's agent started (acpmux spawnedBy) lists under it on a thin guide line, each row carries its pull requests (the branch PR of each session folder, as the chat header's chip reads it) in a green, orange or purple badge, and the first rows show their Command-number keycaps. The Command-1...9 order follows the drawn order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT media: the core tour turns on the session tree last Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 9bee46b - regenerated webviews/src/pages/settings/generated/strings.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39176969610 * cmux NEXT sidebar: the session tree feed lives in CmuxNextAgentLanes CmuxNextApp may not grow: the feed moves to CmuxNextAgentLanes (the app passes its workspaces), and the gh pull request reader moves next to its model in CmuxNextAgentPane so the chat chip and the sidebar share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: CI target graph for CmuxNextAgentLanes' new dependencies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: review fixes for the session tree The moved gh reader's process holder carries its reviewed crash-allow (only the thread-safe isRunning and terminate() cross threads), and the sidebar asks each folder's pull request at most every five minutes, so it never stalls the chat header's chip on the two shared gh slots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): settings exports for sidebar.sessionTree Generated only: the fleet settings export (cmux-ci step b05e67a26082185e11778f94, run-swift-testing-suites.sh export-settings at 7ad7c4e; CmuxNextSettings is unchanged since), the defaults snapshot (defaults_guard.py snapshot) and the settings page strings (gen-strings.mjs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: CI target graph keeps CmuxNextAgentLanes' dependencies after the base merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): settings exports for sidebar.sessionTree after the base merge Generated only: the fleet settings export (cmux-ci step 69f7e53cebcd649429577bcd, run-swift-testing-suites.sh export-settings at 215bf61; CmuxNextSettings is unchanged since), the defaults snapshot (defaults_guard.py snapshot) and the settings page strings (gen-strings.mjs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the session tree draws every level at its depth (red) The session tree flattens a child's child to depth 1 under the top parent. These tests draw a three-level chain and a fifty-workspace tree four levels deep and expect each row at its real depth, subtrees unbroken. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(next): the session tree draws the real spawn tree, folds, and rolls up With sidebar.sessionTree on, a workspace draws at its real depth under the workspace whose agent started it, at any depth, instead of flattening every descendant to depth 1 under the top parent. A parent gets a chevron that folds its subtree (kept across launches), and a folded parent shows chips for its hidden sessions: waiting on you, failed, running, finished unread. The states come from acpmux's lanes (input, failed or lost, working, idle), with an unread idle workspace counted as finished unread. A workspace with no lane reads its row: a hook's waiting or error, its work, its unread mark. Unread alone never counts as waiting on you. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): a patched row keeps its tree chevron and roll-up A row's content patch rebuilds its content from the workspace; it kept the tree depth already, and now keeps the parent's fold and roll-up too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(next): leave workspace groups' rows as the session tree drew them Folds and roll-ups apply to a section's loose rows only; a workspace group's members keep #21814's drawing (Leo: group code is another lane's). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): session tree review fixes - Search finds a match inside a folded subtree (folds open while filtering, as groups do). - A folded parent's roll-up follows a hidden session's patch: the list lays out again. - A selected session never hides in a fold: selecting one opens the folds above it. - The layout computes each list's children once, not once per row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): lower the type-scale baseline for BrowserPopupPanel (base red: it no longer has raw font sizes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux-next tour: turn sidebar.sessionTree back off after its step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): close the #require calls in the session tree lane test The base merge in 08374a3 left both try #require(AgentActivityLane.of(...)) calls without their closing parenthesis, so CmuxNextAppTests did not build (fast tier: "the tests do not build"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): a filter draws a folded parent open; a deep chain keeps every link Red: while filtering, treeOrder draws a folded parent's children but treeFold still reads the fold, so the parent shows a collapsed chevron and a roll-up above its own children. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): session tree folds open under a filter; reveal lives with the folds - A filter opens every fold for the chevrons and roll-ups too, not only the order, so a matching folded parent no longer shows a collapsed chevron above its own children. - treeChildren remembers each workspace's answer (one pass over a chain), and the layout hands treeOrder the children it already computed. - A patch to a row nobody draws relays the list only when a folded ancestor hides it (hidesInFold), not whenever any fold exists. - reveal(_:) moves here from the needs-you tray PR: the selection path in this PR calls it, so the branch did not build on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the Markdown viewer test host implements FilePageHosting.openAppLink (base red: CmuxNextAppTests did not build) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at f2d34a4 - regenerated docs/mdm/com.manaflow.cmux.json - regenerated docs/mdm/com.manaflow.cmux.plist - regenerated docs/mdm/managed-preferences.md - regenerated schemas/settings-export/settings-schema.sources.sha256 - regenerated schemas/settings/settings-schema.json - regenerated Packages/macOS/CmuxNext/ci-target-graph.json - regenerated web/data/cmux-shortcuts.generated.json - regenerated cmux-tui/crates/cmux-app-host/generated/cmux-app.d.ts - regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39215245191 * acpmux: record the PRs each session opens; the sidebar session tree counts them all (#21823) * acpmux: test that a session lists the pull requests gh pr create opened Red: pullRequests is absent, so the summary has [] (no detector yet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: record the pull requests each session opens; the sidebar session tree counts them A tool call whose command runs `gh pr create` is remembered until it ends; the github.com pull URLs its output prints join SessionMeta.pull_requests, once each, and SessionSummary exposes them as optional pullRequests. CmuxNext parses them on AgentActivityLane and SidebarSessionTreeFeed reads each with `gh pr view <url>` beside the folder's branch PR, counting each pull request once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: count only a shell call whose whole command is gh pr create, and only the URL it prints Review fixes for #21823: a grep or echo mentioning gh pr create, or a chained gh pr create && gh pr view 9, no longer records links. The command is parsed (quotes, $( ), heredocs) and must be gh pr create after cd steps and env prefixes; only the last output line that is just a pull URL is kept, preferring rawOutput.stdout when the harness separates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: a failed gh pr create records no pull request gh exits 1 when the branch already has a pull request and prints its URL; that call opened nothing. Review nit from coord-2 on #21823. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(acpmux): a gh pr create URL counts only once its call completes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: a gh pr create URL counts only when its call completes A harness that streams gh's "already exists: URL" in an in_progress update before the failed one recorded that pull request; the URL is now held per call and recorded on completed only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): AgentActivityLane.of takes no title Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(acpmux): gh pr create counts after && steps and with 2>&1 Red: a bare & splits `2>&1` and `&>file` into two commands, and only cd may precede gh, so the usual `git push && gh pr create --fill 2>&1` is never recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * acpmux: gh pr create counts after && steps and with 2>&1 A redirect's & (2>&1, >&2, &>file) no longer splits the command, and steps joined to gh by && may precede it, so `git push && gh pr create --fill 2>&1` records its pull request. ;, ||, | and & before gh still don't count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request hover card on the session tree's PR badge (#21959) * cmux NEXT sidebar: pull request hover card on the session tree's PR badge Hovering a row's pull request badge lists each pull request its sessions opened (acpmux pullRequests plus the folder's branch PR), newest first: title, a state pill (Conflict / Checks failed / Checks passing / Draft / Merged / Closed), owner/repo #N and +adds -dels; a click opens it in the focused pane's browser. It scrolls past eight lines. The badge gains a red failing status. Live state comes from one batched gh api graphql read per refresh (aliased pullRequest fields, 50 per query) instead of one gh pr view per URL. Debug Settings toggle sidebar.pullRequestCard, on by default; native gallery entry with conflict, checks-failed, mixed, all-merged and empty fixtures; strings in 21 locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card review fixes A failed GraphQL read keeps the last answers (only a null alias clears one); the query pins --hostname github.com and other hosts fall back to gh pr view per URL; the card follows its badge when the row is reused or its pull requests change; a hidden badge never makes the panel and resets its hover; the workspace card and the pull request card dismiss each other; rows take first mouse; same-moment pull requests list by number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: pull request card opens only PR pages; settled PRs are read once; failing reads back off The card opens a URL only when it is https://github.com (or the user's GH_HOST) /<owner>/<repo>/pull/<n> with nothing else. A merged or closed PR's URL is not asked again; a URL whose read failed waits freshness doubled per failure, up to 16x. Failed checks show red before a conflict. Review fixes from coord-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: import Foundation for the PR item host check (ProcessInfo, URLComponents) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): the PR store re-reads open PRs on its own, re-asks closed ones, and keeps answers on partial GraphQL errors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT sidebar: re-read open PRs every five minutes while shown, re-ask closed ones, keep answers on partial GraphQL errors Review findings on #21814/#21959: a badge never refreshed once its session went idle, so CI that failed later stayed green; a reopened PR never came back; an SSO or resource-limit error nulled good answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): only an open pull request keeps the sidebar's recheck Red: a folder never settles, so with the tree on the store re-reads every folder every five minutes, branches with no pull request included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar rechecks only open pull requests, and forgets unshown ones - The five-minute recheck stays armed only while the tree shows an open or draft pull request. A folder never settled, so before this every session folder was re-read with gh every five minutes, branches without a pull request included. - Answers, read times and failure counts for folders and URLs the tree no longer shows are dropped on each pass instead of growing for the app's life. - The card's state pill uses Metrics.chipCornerRadius, not a capsule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): take the base's generated files and Markdown test host after the merge The merge kept stale copies of the shortcuts export, the devbox rebake list and the agent-session spec, and a second openAppLink in the test host. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * generated: restore base's shortcuts export (a stale autofix dropped paletteKey.toggleActions) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): keep the base's hook status conflicts (#21813) after the stack merge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 4e00ea2 - vp fmt webviews/src/sidebar/SidebarPullRequestCard.gallery.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39315375602 * chore(next): rerun the PR autofix so it regenerates the settings exports The last head was an autofix commit, which the autofix skips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 014d9cc - regenerated docs/mdm/com.manaflow.cmux.json - regenerated docs/mdm/com.manaflow.cmux.plist - regenerated docs/mdm/managed-preferences.md - regenerated schemas/settings-export/settings-schema.sources.sha256 - regenerated schemas/settings/settings-schema.json - regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39321341168 * test(next): the sidebar's PR recheck reads only open pull requests A recheck called refresh(shown), which also re-read every folder without a pull request every five minutes while one open PR showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the sidebar's PR recheck reads only open pull requests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(next): a closed parent's fold leaves the saved fold list Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(next): the session tree saves only folds the tree still has The saved fold list grew with every folded workspace that later closed. Each save now keeps only folds on a live parent (once the feed has passed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(next): PR autofix at 4dd489e - docs/mdm/com.manaflow.cmux.json - docs/mdm/com.manaflow.cmux.plist - docs/mdm/managed-preferences.md - schemas/defaults/cmux-next.json - schemas/settings-export/settings-schema.sources.sha256 - schemas/settings/settings-schema.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39359164603 * chore(next): the session tree's root walk ends on its own condition, not `while true` The concurrency scanner reads `while true` as a loop that can spin. The walk is the same: it stops at a known answer, a cycle, or a workspace whose parent is not in the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2c-88e4-7fc2-b58e-9a55abdaced8&host=cosmic-gray * refactor(next): the session tree's loose-row drawing lives in SidebarLayout+SessionTree SidebarLayout.swift was already over the 400-line god-file limit on the base (455 lines) and this PR grew it to 472, which `check-no-godfiles --base` refuses. `treeRows` now builds each loose row's depth, chevron and roll-up beside `treeOrder`, and `emit` takes that row. Same order, folds and roll-ups; the file is 454 lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2c-88e4-7fc2-b58e-9a55abdaced8&host=cosmic-gray * chore(next): the sidebar catalog keeps base's key order after the merge The key-wise merge driver kept this branch's key order, which moved keys that #22983 placed on base. Same keys and values; the catalog's diff against base is now only the seven session tree strings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2c-88e4-7fc2-b58e-9a55abdaced8&host=cosmic-gray * cmux-next: a chevron folds right away; a reveal keeps other folds The chevron (and its VoiceOver actions) only toggled the tree and left the redraw to observation, which the calm-movement hold deferred until the pointer left the sidebar; it now reloads the list like the tabs disclosure. reveal() no longer prunes the saved folds, since at launch it runs for the restored selection before every lane has loaded. The sidebar catalog goes back to base's key order, so its diff is only the new keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2c-88e4-7fc2-b58e-9a55abdaced8&host=cosmic-gray --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-autofix[bot] <cmux-autofix[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @lawrencecchen: this is in your sidebar area. It stays behind
sidebar.sessionTree(off by default) and lands under Leo's merge directive; no action needed.Stacked on #21814 (base is its branch; retarget to
feat-cmux-nextonce it lands).Summary
The sidebar session tree's PR badge (#21814) counts only the pull request of each session folder's current branch, so a session that opened several PRs from different branches undercounts. This is the follow-up #21814 names.
kind: execute) whose whole command isgh pr create ..., until the call ends. Beforeghit allowscd DIR &&steps andVAR=value/envprefixes. The command comes fromrawInput.command(a string, or the script ofbash -lc), and the parse handles quotes,$( )and heredocs, so Claude's--body "$(cat <<'EOF' ...)"form counts. A grep or echo that mentionsgh pr createdoes not count, and neither doesgh pr create && gh pr view 9. Of the call's output, only the last line that is nothing but ahttps://github.com/<owner>/<repo>/pull/<n>URL is kept, fromrawOutput.stdoutwhen the harness separates it (Claude's result mixes stdout and stderr). It joinsSessionMeta.pull_requests, de-duplicated, oldest first, capped at 200. Harnesses send the command ontool_calland the output on later updates, which is why the call id is remembered. A fork starts with no PRs. Subagent tool calls are not counted.SessionSummary.pullRequests: string[]is optional in the schema, so peers on older acpmux versions still parse. The protocol IR and the web types are regenerated. The codegen also picked up an existing doc-comment drift onLifecycleReceiptfrom the base.AgentActivityLane.pullRequestsparses the field.SidebarSessionTreeFeedasksSidebarPullRequestStorefor each workspace's folders and each opened URL. The store reads a URL withgh pr view <url>(newAgentChatPullRequestReader.read(url:)) on the same two-at-a-time queue and once-a-minute freshness. The badge counts each pull request once, even when a folder's branch PR is also an opened URL or two sessions name the same PR.Testing
cargo test -p acpmux --test hub_integration session_pull_requests(Linux): red on the test-only commit 1591a4a with the detector disabled (left: []), green on bc84c70. The fake agent opens two PRs (command on the call, URL on the update; a string and an argv), runsgh pr viewon a third, prints the first one again, greps forgh pr createwith a URL in the output, and chainsgh pr create && gh pr view 11. Only the two opened PRs count. The test checks the summary, the saved meta and_acpmux/sessions.Full
cargo test -p acpmux --test hub_integration(250 passed, 1 ignored),cargo test -p acpmux --lib(142 passed, including 3 new unit tests for the command parse, the argv/title source and the printed-URL rule), andcargo clippy -p acpmux --all-targets(clean) on Linux.protocol_ir_is_currentwas blessed andbun run acpmux-protocol:codegenwas run.Swift: new
SidebarSessionTreeTestscases (lane parsing,asks/badgededupe). These are not compiled locally because the dev box is Linux. They rely on thecmux-nextCI lane. Not checked live in a tagged build.After merging cmux NEXT sidebar: session tree with PR badges and keycaps (sidebar.sessionTree, off by default) #21814's review fixes (the feed moved to
CmuxNextAgentLanes, the reader toCmuxNextAgentPane) and tightening the detector at 36152bd: full acpmux suites green again, clippy clean,acpmux-protocol:checkcurrent. The hosted--filter session_pull_requestsrun passed on bc84c70 and is re-running on 36152bd.Peers: summaries go to attached clients and to the peer daemons the person configured (
peersin their own acpmux config, reached with that peer's token or over ssh), which are their own machines. Those summaries already carry cwd, title, last prompt and preview.Changelog
none (behind
sidebar.sessionTree, off by default)Proof
No UI change beyond the badge count behind an off-by-default flag; CI only.
Checklist
🤖 Generated with Claude Code