Repository navigation
cmux-next New Tab: the mic leaves a narrow row at the chat bar's step - #21816
Conversation
The New Tab row (.nt-pickers) has no fit hook: under 340 px its chips can only shrink to the model's 56 px floor. #20391 took the New Tab screen's side padding from 16 to 18 px, which left the 280 px pane 1 px from that floor; with CI's font metrics the actions cluster ran into the mode chip and test/narrow-layouts.test.ts failed on every feat-cmux-next PR ("new-tab: New Tab chips: Mode overlaps Dictate"). The mic now leaves the New Tab row at the composer width where it leaves the chat bar (COMPOSER_FIT_STEPS.micHidden); a listening mic stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Receipt for
|
|
Bead |
|
cmux-next tour of The tour job failed before the tour ran (build or setup); the run log has the output. The tour produced no media. Tours are data in |
web / react-apps-check (1)fails on every feat-cmux-next PR (#21794, #21786, #21734) intest/narrow-layouts.test.ts, at 280 px:Cause. Two merges that each passed CI on their own:
max(16px, …)tomax(var(--cv-edge, 18px), …).The New Tab row (
.nt-pickers) has no fit hook. As it narrows, only the model chip shrinks, down to its 56 px floor. The 4 px #20391 took left the 280 px pane 1 px above that floor. With CI's font metrics the row ran out, and the mic and Send ran into the mode chip.Fix. The New Tab row's mic now leaves at the composer width where the chat bar's mic leaves (
COMPOSER_FIT_STEPS.micHidden, 340 px). A listening mic stays, as it does in the chat bar. At 280 px the model chip now has 89 px, 33 px above its floor.Testing
On huge-blue (Linux, Chromium headless shell 1234, Playwright's font packages):
CMUX_BROWSER_TESTS=1 bun test test/narrow-layouts.test.ts test/composer-fit-steps.test.ts: 10/10 pass.composer-menu-dismiss,composer-location-stripandnew-tab-chat-title-widthpass.Not reproduced locally: narrow-layouts also passes at the base tip on huge-blue. There the 280 px row is 1 px from the floor, and only CI's fonts push it over. A probe of the controls' rects (Model, Effort, Mode, Dictate, Send) shows the margin before and after the change. CI's run on this PR is the red-to-green check.
Changelog
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the New Tab composer overlapping the mode chip at 280 px panes, which broke
narrow-layoutsCI on everyfeat-cmux-nextPR. The New Tab row's mic now hides at the same composer width as the chat bar's mic (340 px), with a listening mic staying visible while dictating.Written for commit f8a00d7. Summary will update on new commits.