Repository navigation
cmux-next: overlays are themed Liquid Glass, and tooltips let more through #21785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5def1b6
945e1ba
2c05e3a
9c74884
0e08089
fcb8623
3449459
2a0ab72
a8d15d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -355,10 +355,10 @@ input[type="submit"] { | |
| /* TOOLTIP SURFACE (CmuxNextDesign/Tooltip/TooltipSurface.swift; tooltip-surface.test.ts holds the | ||
| two in step). Frosted glass: the host's tint (--cmux-tooltip-tint: the popup surface at the | ||
| least alpha that keeps the text 4.5:1 over pure black and pure white, whatever the blur | ||
| averages), else the popup surface at 86%; a 24px blur; the separator rim one device pixel | ||
| averages), else the popup surface at 60%; a 24px blur; the separator rim one device pixel | ||
| (--cmux-hairline); elevation 1. It fades in with the popup open and out with the popup close (the native | ||
| fadeIn and fadeOut tokens), rising 2px. Reduce Transparency: the opaque popup surface. */ | ||
| --tooltip-tint: var(--cmux-tooltip-tint, color-mix(in srgb, var(--surface-popup) 86%, transparent)); | ||
| --tooltip-tint: var(--cmux-tooltip-tint, color-mix(in srgb, var(--surface-popup) 60%, transparent)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Without Keep a safe fallback alpha separate from the native minimum, or calculate the fallback tint from the page’s colors. |
||
| --tooltip-blur: blur(24px) saturate(1.6); | ||
| --tooltip-rim-width: var(--cmux-hairline); | ||
| --tooltip-shadow: var(--elevation-1); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When Reduce Transparency changes during an
NSTextFieldedit,window.firstResponderis the shared field editor, not the field. Removing the content ends editing and can detach that editor. This makesfocused.windownil, so this line skips restoring focus and typing stops until the user clicks the field again.Save the editor’s owning field and selection before removal, then restore them through the original window, as
WindowOverlayHostalready does.