Repository navigation
test(acpmux): run three test binaries hermetically before the base-red skip expires (cx-5j26a) - #21707
Conversation
… hermetically (cx-5j26a) hermetic_daemon_guard requires every acpmux test binary to include tests/support/daemon_env.rs and define HERMETIC. These three, added on 2026-10-15, did not, so the guard has been red on every OS behind a base-red skip that expires today (2026-10-18). All three run stand-in agents (fake python agents, or shell scripts for Claude Code), so they take stand_in(). The skip line goes in the same push, as the skip file asks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Receipt for
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39139500989 at 6e7ec42 failed: cmux-next Release compile (Xcode 26). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39141168383 at e30d059 failed: cmux-next Release compile (Xcode 26). |
acpmux'severy_test_binary_runs_in_the_hermetic_environmenthas been red on every OS since 2026-10-15 (cx-5j26a).complete_rpc,session_mcp_serversandprompt_imagescame in withouttests/support/daemon_env.rsand itsHERMETICconstant.scripts/ci/cmux-tui-base-red.tsvskips the test until 2026-10-18 UTC, and after thatcmux-tui-rust-check.shfails the step for every head.The three binaries now include the helper and define
HERMETIC = Process::stand_in(), like the other tests that run stand-in agents (fake python agents, or shell scripts for Claude Code incomplete_rpc). They re-exec with the bare PATH and scratch HOME beforemain. This PR also removes the skip line, as the file asks.Testing
cargo test -p acpmux --test hermetic_daemon_guard --test complete_rpc --test session_mcp_servers --test prompt_imageson macOS (arm64): all 5 tests passed. That includes both guard tests, and the three binaries' tests now run under the hermetic environment.cmux-tui-rust-check.sh testand Linux.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the hermetic environment guard for three
acpmuxtest binaries so the CI step no longer fails once the base-red skip expires.daemon_envhelper andHERMETIC = Process::stand_in()tocomplete_rpc,session_mcp_servers, andprompt_images, which all run stand-in agents.every_test_binary_runs_in_the_hermetic_environmentfromcmux-tui-base-red.tsv, resolving cx-5j26a.Written for commit 27f7322. Summary will update on new commits.