Skip to content

test(acpmux): run three test binaries hermetically before the base-red skip expires (cx-5j26a) - #21707

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/acpmux-hermetic-test-binaries
Oct 18, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/acpmux-hermetic-test-binaries

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

acpmux's every_test_binary_runs_in_the_hermetic_environment has been red on every OS since 2026-10-15 (cx-5j26a). complete_rpc, session_mcp_servers and prompt_images came in without tests/support/daemon_env.rs and its HERMETIC constant. scripts/ci/cmux-tui-base-red.tsv skips the test until 2026-10-18 UTC, and after that cmux-tui-rust-check.sh fails the step for every head.

The three binaries now include the helper and define HERMETIC = Process::stand_in(), like the other tests that run stand-in agents (fake python agents, or shell scripts for Claude Code in complete_rpc). They re-exec with the bare PATH and scratch HOME before main. This PR also removes the skip line, as the file asks.

Testing

  • cargo test -p acpmux --test hermetic_daemon_guard --test complete_rpc --test session_mcp_servers --test prompt_images on macOS (arm64): all 5 tests passed. That includes both guard tests, and the three binaries' tests now run under the hermetic environment.
  • Not run: the full cmux-tui-rust-check.sh test and Linux.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the hermetic environment guard for three acpmux test binaries so the CI step no longer fails once the base-red skip expires.

  • Adds the daemon_env helper and HERMETIC = Process::stand_in() to complete_rpc, session_mcp_servers, and prompt_images, which all run stand-in agents.
  • Removes the skip line for every_test_binary_runs_in_the_hermetic_environment from cmux-tui-base-red.tsv, resolving cx-5j26a.

Written for commit 27f7322. Summary will update on new commits.

View guided diff Turn on auto-fix

… hermetically (cx-5j26a)

hermetic_daemon_guard requires every acpmux test binary to include
tests/support/daemon_env.rs and define HERMETIC. These three, added on
2026-10-15, did not, so the guard has been red on every OS behind a base-red
skip that expires today (2026-10-18). All three run stand-in agents (fake
python agents, or shell scripts for Claude Code), so they take stand_in().
The skip line goes in the same push, as the skip file asks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 18, 2026 14:53 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7d06c6a4-bab1-4c85-b4b3-a33919faf6a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Receipt for 27f7322 (this PR's head; a new push replaces it)

  • Visual review: HQ feed card · gallery before/after runs
  • Checks: this head
  • App of this head (app.zip, kept 1 day): gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21707 -f ref=fix/acpmux-hermetic-test-binaries -f platform=macos -f backend_mode=local

@teamleaderleo
teamleaderleo merged commit 6e7ec42 into feat-cmux-next Oct 18, 2026
147 of 156 checks passed
@teamleaderleo
teamleaderleo deleted the fix/acpmux-hermetic-test-binaries branch October 18, 2026 15:13
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39139500989 at 6e7ec42 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at 0e781a6. This pull request is one of 3 merged since: #21671, #21657, #21707.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39141168383 at e30d059 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at 0e781a6. This pull request is one of 4 merged since: #21671, #21657, #21707, #21679.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

This branch was previously deployed

2 inactive deployments
cmux-tui-merge-tree — 27f73222 Deployed Oct 18, 2026 by teamleaderleo via publish the merge tree #1996
artifacts — 27f73222 Deployed Oct 18, 2026 by teamleaderleo via publish tree-addressed cmux-tui #21440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant