Repository navigation
cmux NEXT: a long live thought streams in Codex's seven-line viewport - #21660
Conversation
A long thought folded once done (#20948, Debug toggle agentPane.debug.foldLongThoughts) now reads how long the agent thought, from its first chunk to its latest, clamped at zero for out-of-order events. An undated thought, or one under a second, reads "Thought". #20948's "Thought" plus first line stays as the Debug choice agentPane.debug.thoughtHeader = preview, which the app sets on <html> as data-thought-header. New string tools.thoughtFor in all 21 pane locales (split from #20963). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the long-thought fold on (agentPane.debug.foldLongThoughts), a thought taller than 140px that is still streaming reads "Thinking" and holds a fixed 140px viewport (Codex's 8.75rem) with its newest line at the bottom and older lines fading out over 16px. Once done it folds as before; the fold measures the text's whole height, not the clip. Debug toggle agentPane.debug.liveThoughtViewport, on by default; off sets data-live-thought-viewport="off" and the thought streams in full (split from #20963). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Receipt for
|
|
all web/size checks green |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
|
|
Bead |
|
🤖 Generated with Claude Code |
|
Closing and reopening to start a fresh CI run on the current base: #21679 fixed the base check:text-focus red, and a plain rerun would reuse the old merge commit. Head unchanged. |
…check:text-focus fix)
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…a squash) # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneTunables.swift # Packages/macOS/CmuxNext/Tests/CmuxNextAgentPaneTests/AgentPaneThoughtTunablesTests.swift # webviews/src/agent-session/acpmux/conversation/ThoughtRow.test.tsx # webviews/src/agent-session/acpmux/conversation/ThoughtRow.tsx # webviews/src/agent-session/acpmux/conversation/conversation.css
… as a squash) # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneTunables.swift # Packages/macOS/CmuxNext/Tests/CmuxNextAgentPaneTests/AgentPaneThoughtTunablesTests.swift # webviews/src/agent-session/acpmux/conversation/ThoughtRow.test.tsx # webviews/src/agent-session/acpmux/conversation/ThoughtRow.tsx
|
Shipped in:
|
Stacked on #21656. This branch includes #21656's commit. Review only the top commit,
6a72fb7a30b0, and land this after #21656.When the long-thought fold is on (
agentPane.debug.foldLongThoughts), a thought taller than 140 px that's still streaming now reads "Thinking" with the existing shimmer. It holds a fixed 140 px viewport, which is seven of its 20 px lines and the 8.75rem Codex gives a live reasoning trace. The newest line sits at the bottom, and older lines fade out at the top over 16 px. Once the agent moves on, the thought folds as before. A thought no taller than 140 px streams in full after "Thought".scrollHeight). Without that, a thought clipped to 140 px would measure 140 and never fold.agentPane.debug.liveThoughtViewport), is on by default. When it's off, the app setsdata-live-thought-viewport="off"on<html>and a long thought streams in full, as onfeat-cmux-nexttoday. It only applies while the fold is on.Freeze WINDOW areas:
Packages/macOS/CmuxNext(Debug tunables inAgentPaneTunables.swift).Testing
bun test src/agent-session/acpmux/conversation/ThoughtRow.test.tsxpasses, 16 tests. The new tests cover:bun run checkinwebviews/passes, andlint-ios-package-conventions.sh --namespace-fixis clean.agent-pane-chat-column.test.ts: a live long thought's text box is 140 px, with its last line in view and its first line above it. With the toggle off, it's taller than 600 px.AgentPaneThoughtTunablesTests.swift: the toggle's key, its default, and itsoffattribute.thinkingkey.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
With the long-thought fold on, a thought taller than 140 px that's still streaming reads "Thinking" and holds a fixed seven-line viewport, keeping its newest line in view and fading older lines out at the top. Once the agent moves on, it folds as before. A folded thought now reads "Thought for 12s" instead of a preview of its text.
agentPane.debug.liveThoughtViewport), is on by default; off streams the thought in full.agentPane.debug.thoughtHeader), keeps the old preview style on "preview"; "duration" (default) adds the newtools.thoughtForstring in all 21 pane locales.Picked up from
feat-cmux-nextvia mergesacpmuxallows no-ask start modes when a caller session inherits the mode or a person approved the preset.Written for commit 27da1cc. Summary will update on new commits.