Skip to content

fix(run-board): align Cloud Run protocol - #21513

Closed
teamleaderleo wants to merge 5 commits into
manaflow-ai:run-board-teamfrom
teamleaderleo:codex/run-board-cloud-contract
Closed

teamleaderleo wants to merge 5 commits into
manaflow-ai:run-board-teamfrom
teamleaderleo:codex/run-board-cloud-contract

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Align the cmux-next Run board transport with the existing Cloud Run API.

  • normalize flat Cloud receipts (id, status, attempts, events) while preserving the nested gallery fixture shape
  • send cmux.run/v1 with SHA-256 intent.digest and per-variant raw instruction plus instructionDigest
  • replay embedded receipt events while the event route rolls out
  • fail closed before network use when Huge Blue is requested
  • require a real attach route, token, provider session identity, and live expiry at the native run.attach bridge; never synthesize workspace or terminal IDs

Validation

  • cd webviews && bun test src/agent-session/acpmux/run-board/runApi.test.ts src/agent-session/acpmux/run-board/model.test.ts (18 passed)
  • cd webviews && bun run vp check --no-fmt --no-lint (no type errors in 1,490 files)
  • git diff --check

The native bridge currently starts cmux remote connect using the endpoint route and rejects a missing provider session; it does not invent or substitute a terminal ID. Selecting a provider terminal by ID still requires a Cloud endpoint/daemon RPC that targets that terminal. Attach-ticket/redeem and promotion remain separate Cloud API capabilities; this patch does not claim those endpoints exist.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 01678eda-f372-4b1f-9aed-69a3a7397f04

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Unclear: CI fast guards failed: no known signature; failed step: Run the fast guard tests.

CI failed on a3f98854e4 (run 39104408672 attempt 1): 2 code, 8 unknown.

Job Verdict Why
CI fast guards unknown no known signature; failed step: Run the fast guard tests
Fast static checks code a static check failed
guards / workflow-guard-tests / preflight unknown no known signature; failed step: Validate macOS runner guards
guards / workflow-guard-tests / release-ios unknown no known signature; failed step: Validate iOS simulator build-once contract
guards / workflow-guard-tests / quality-determinism code a Python test failed
guards / workflow-guard-tests / app-host-cache unknown no known signature; failed step: Validate iOS video recording failures
guards / workflow-guard-tests / release-tooling unknown no known signature; failed step: Validate retried Ghostty Zig package fetches
web / react-apps-check (1) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (2) unknown no known signature; failed step: Build the web bundles
web / react-apps-check unknown no known signature; failed step: Check webview test shards
Matched log lines
Fast static checks: FAILED localization (0.82s)
guards / workflow-guard-tests / quality-determinism: FAIL: test_scans_only_test_sources (__main__.CommandLine.test_scans_only_test_sources)

Not re-run automatically: CI fast guards, Fast static checks, guards / workflow-guard-tests / preflight, guards / workflow-guard-tests / release-ios, guards / workflow-guard-tests / quality-determinism are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

Copy link
Copy Markdown
Contributor

CI fast guards failed on a3f98854e4 (https://github.com/manaflow-ai/cmux/actions/runs/39104408672). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as superseded: its base run-board-team (#21394) is closed, and #22408 rebuilt the Run board client and native run.attach checks (live expiry, Cloud-only) on feat's run API; Huge Blue is out of scope there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant