Skip to content

fix(cmux-next): surface summary-only nightly What’s New entries - #21458

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/nightly-whats-new-summary-fallback
Oct 18, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/nightly-whats-new-summary-fallback

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Recent nightly feeds can contain validated user-facing summaries while omitting a whatsNew digest. The app then falls back to the generic “All Changes” fold, which makes the What’s New page look stale and loses the New/Improved hierarchy.

Change

  • Generate a validated What's New digest from summary lines when no highlight digest is available.
  • Add an app-side fallback for already-published summary-only notes, preserving categories and ignoring empty lines.
  • Keep the existing embedded digest/highlight paths unchanged.

Validation

  • python3 -m unittest tests/test_cmux_next_release_notes.py — 7/7 passed.
  • swiftc -parse Packages/macOS/CmuxNext/Sources/CmuxNextUpdater/WhatsNew/WhatsNewSources.swift Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/FeedWhatsNewSourceTests.swift — passed.
  • git diff --check — passed.
  • Live feed samples observed summaries with whatsNew: false on builds 3909161799401, 3908291645501, and 3907660300601.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the What's New page falling back to the generic "All Changes" fold when a nightly build ships validated summaries but no highlight digest. Summary lines now generate a What's New digest with the New/Improved/Fixed/Security hierarchy, and existing embedded digest and highlight paths are unchanged.

New Features

  • The release-notes generator produces a validated whatsNew digest from user-facing summary lines when no highlight digest exists.
  • The macOS app builds a fallback What's New document from summary-only feeds, preserving categories and skipping empty lines.

Written for commit d32818c. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d1f2cc1c-b5da-4d7f-be73-2120ea027ded

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on d32818c444; ci-status is green without them.

CI passes on d32818c444 (run 39102792580 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@cursor

cursor Bot commented Oct 18, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Implementation receipt for exact head 4382e2809efdd03a2577759da98145555a2ea194:

  • Live nightly feed evidence: builds 3909161799401, 3908291645501, and 3907660300601 contained summary lines but whatsNew: false, causing the generic Changes fold.
  • python3 -m unittest tests/test_cmux_next_release_notes.py — 7/7 passed on the implementation worktree.
  • swiftc -parse Packages/macOS/CmuxNext/Sources/CmuxNextUpdater/WhatsNew/WhatsNewSources.swift Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/FeedWhatsNewSourceTests.swift — passed.
  • git diff --check — passed.
  • Release-notes executable mode preserved as 100755 on this head.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-swam1 created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo force-pushed the codex/nightly-whats-new-summary-fallback branch from 4382e28 to d32818c Compare October 18, 2026 06:05
@teamleaderleo
teamleaderleo merged commit b620b97 into feat-cmux-next Oct 18, 2026
100 checks passed
@teamleaderleo
teamleaderleo deleted the codex/nightly-whats-new-summary-fallback branch October 18, 2026 06:26
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39104072536 at e9c0782 failed: cmux app scheme compile (Debug).
Those jobs last passed at 64a50c4. This pull request is one of 5 merged since: #21458, #21461, #21504, #21459, #21509.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant