Skip to content

feat(next): carry workspace name provenance in Swift daemon client - #21441

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
feat/next-workspace-name-source-swift
Oct 18, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
feat/next-workspace-name-source-swift

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add the cmux-next Swift daemon-client compatibility layer for workspace name provenance from #20710. Workspace snapshots and deltas now preserve name_source (user/auto) and decimal-string name_revision, while the rename request can carry source, expected_name_revision, and release.

Automatic renames are capability-gated by workspace-name-source-v1 and carry the current daemon generation through the existing mutation envelope. Manual rename calls keep the legacy wire shape and older-daemon behavior. Missing provenance fields decode as user-owned revision zero so existing names remain protected.

Dependency

Validation

  • git diff --check passed.
  • Managed fleet lane e1dcbd84d224e612db3dd6a6 passed on exact head f0bb37ecb4d9e30931e4335ff2774a605f9c1158 (aws-m4pro-5, Xcode 26.6): package test build completed and WorkspaceNameSourceTests passed 5/5.
  • No local Swift tests/builds were run.

Changelog

none

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 298c1dfc-c2ff-4bc4-acab-170d041cea5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 76c6e706e2; ci-status is green without them.

CI passes on 76c6e706e2 (run 39103435060 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-b5cdj created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Follow-up from the app lane: PR #21445 now consumes this wire as its daemon compatibility dependency. Exact app head 205fd094d5e348f94a7bba394ba023b952191c3b sends source:auto, expected_name_revision, and the daemon generation fence to every capable local/remote connection. Its managed fleet naming suites pass on that exact head. Please keep the capability spelling and legacy user/0 decode stable while reviewing #21441; no app merge claim until both lanes are green.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delegated review of exact PR head f0bb37ecb4d9e30931e4335ff2774a605f9c1158 (base feat-cmux-next at b2c655a2f57953c18862c637e488c6f58c5d6be2).

I inspected the full 8-file diff. The Swift wire changes are internally consistent: legacy snapshots default to user/revision 0; automatic rename fields use workspace-name-source-v1, decimal-string expected_name_revision, and generation fencing; manual rename keeps the legacy shape. The added WorkspaceNameSourceTests cover these compatibility cases. I found no code-level correctness issue in this diff.

Verdict: changes look reviewable, but merge readiness is blocked by hosted evidence. The exact-head CI run 39093561233 reports ci-status green while the required macOS lane and compile/app tests were skipped (macos, macOS admission gate, and the compile/app-test jobs). The repository's own attribution comment says to rerun CI once those jobs pass before merging. The managed fleet evidence in the PR description (e1dcbd84d224e612db3dd6a6, exact head above) only covers the package test build and WorkspaceNameSourceTests 5/5, so it does not replace the skipped hosted macOS checks.

@teamleaderleo
teamleaderleo force-pushed the feat/next-workspace-name-source-swift branch from dbcb34f to 76c6e70 Compare October 18, 2026 06:16

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary review refreshed for exact head 76c6e706e2e6fe859bf08a76cd75d3268cecbdc9:

The product diff remains correct and unchanged. This head adds only the CI reliability repair: the defaults-guard review workflow now treats the GitHub API 404/no-run case as the documented no-run path instead of failing before the guard can run. The earlier full-coverage dispatch was invalid for this PR because routed guard checks used workflow-dispatch context; the branch workflow repair is the correct fix and will produce fresh PR checks on this exact head.

Evidence:

  • Original product diff independently reviewed; no code finding
  • CI repair is the previously validated 404-tolerance change
  • New hosted checks are required before merge

@teamleaderleo
teamleaderleo merged commit 64a50c4 into feat-cmux-next Oct 18, 2026
98 checks passed
@teamleaderleo
teamleaderleo deleted the feat/next-workspace-name-source-swift branch October 18, 2026 06:23
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39103930511 at 4d4cd2b failed: cmux app scheme compile (Debug).
Those jobs last passed at 8743c08. This pull request is one of 2 merged since: #21441, #21461.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

cmux-next tour of 76c6e706e2e6fe859bf08a76cd75d3268cecbdc9 (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.

lawrencecchen added a commit that referenced this pull request Oct 18, 2026
teamleaderleo added a commit that referenced this pull request Oct 18, 2026
… the app half landed (hq#1957)

The CLI flags, RegistryWorkspace provenance and name_pinned refusals exist
only in #20710; the app half (WorkspaceAutoNamer, the
workspaces.autoName.variant tunable, the workspaces.autoName setting) landed
first in #21441 and #21445.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 18, 2026
* plan(next): workspace auto-naming that keeps up (hq#1957)

The design for automatic workspace names: the daemon is the single writer
of a workspace's name source and revision, the app's namer sends automatic
renames fenced by that revision, and a person's rename always wins.

Carved from #20710.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* plan(next): mark the workspace name protocol as proposed, record what the app half landed (hq#1957)

The CLI flags, RegistryWorkspace provenance and name_pinned refusals exist
only in #20710; the app half (WorkspaceAutoNamer, the
workspaces.autoName.variant tunable, the workspaces.autoName setting) landed
first in #21441 and #21445.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant