Repository navigation
feat(next): carry workspace name provenance in Swift daemon client - #21441
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
Bead |
|
Follow-up from the app lane: PR #21445 now consumes this wire as its daemon compatibility dependency. Exact app head |
teamleaderleo
left a comment
There was a problem hiding this comment.
Delegated review of exact PR head f0bb37ecb4d9e30931e4335ff2774a605f9c1158 (base feat-cmux-next at b2c655a2f57953c18862c637e488c6f58c5d6be2).
I inspected the full 8-file diff. The Swift wire changes are internally consistent: legacy snapshots default to user/revision 0; automatic rename fields use workspace-name-source-v1, decimal-string expected_name_revision, and generation fencing; manual rename keeps the legacy shape. The added WorkspaceNameSourceTests cover these compatibility cases. I found no code-level correctness issue in this diff.
Verdict: changes look reviewable, but merge readiness is blocked by hosted evidence. The exact-head CI run 39093561233 reports ci-status green while the required macOS lane and compile/app tests were skipped (macos, macOS admission gate, and the compile/app-test jobs). The repository's own attribution comment says to rerun CI once those jobs pass before merging. The managed fleet evidence in the PR description (e1dcbd84d224e612db3dd6a6, exact head above) only covers the package test build and WorkspaceNameSourceTests 5/5, so it does not replace the skipped hosted macOS checks.
dbcb34f to
76c6e70
Compare
teamleaderleo
left a comment
There was a problem hiding this comment.
Primary review refreshed for exact head 76c6e706e2e6fe859bf08a76cd75d3268cecbdc9:
The product diff remains correct and unchanged. This head adds only the CI reliability repair: the defaults-guard review workflow now treats the GitHub API 404/no-run case as the documented no-run path instead of failing before the guard can run. The earlier full-coverage dispatch was invalid for this PR because routed guard checks used workflow-dispatch context; the branch workflow repair is the correct fix and will produce fresh PR checks on this exact head.
Evidence:
- Original product diff independently reviewed; no code finding
- CI repair is the previously validated 404-tolerance change
- New hosted checks are required before merge
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39103930511 at 4d4cd2b failed: cmux app scheme compile (Debug). |
|
cmux-next tour of The tour job failed before the tour ran (build or setup); the run log has the output. The tour produced no media. Tours are data in |
… the app half landed (hq#1957) The CLI flags, RegistryWorkspace provenance and name_pinned refusals exist only in #20710; the app half (WorkspaceAutoNamer, the workspaces.autoName.variant tunable, the workspaces.autoName setting) landed first in #21441 and #21445. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* plan(next): workspace auto-naming that keeps up (hq#1957) The design for automatic workspace names: the daemon is the single writer of a workspace's name source and revision, the app's namer sends automatic renames fenced by that revision, and a person's rename always wins. Carved from #20710. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * plan(next): mark the workspace name protocol as proposed, record what the app half landed (hq#1957) The CLI flags, RegistryWorkspace provenance and name_pinned refusals exist only in #20710; the app half (WorkspaceAutoNamer, the workspaces.autoName.variant tunable, the workspaces.autoName setting) landed first in #21441 and #21445. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Add the cmux-next Swift daemon-client compatibility layer for workspace name provenance from #20710. Workspace snapshots and deltas now preserve
name_source(user/auto) and decimal-stringname_revision, while the rename request can carrysource,expected_name_revision, andrelease.Automatic renames are capability-gated by
workspace-name-source-v1and carry the current daemon generation through the existing mutation envelope. Manual rename calls keep the legacy wire shape and older-daemon behavior. Missing provenance fields decode as user-owned revision zero so existing names remain protected.Dependency
CmuxNextDaemonSwift wire/model/request parity; it does not implement the app-side namer or cloud-machine rename.Validation
git diff --checkpassed.e1dcbd84d224e612db3dd6a6passed on exact headf0bb37ecb4d9e30931e4335ff2774a605f9c1158(aws-m4pro-5, Xcode 26.6): package test build completed andWorkspaceNameSourceTestspassed 5/5.Changelog
none