Skip to content

perf(webviews): avoid redundant New Tab motion scans #21320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 5 commits into from
Oct 18, 2026
Merged

perf(webviews): avoid redundant New Tab motion scans #21320

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29f3597
fix(webviews): keep motion effect dependency-safe
teamleaderleo Oct 17, 2026
2a4db79
perf(acpmux): avoid redundant turn marker scans (#21327)
teamleaderleo Oct 17, 2026
c68832b
chore(next): PR autofix at 2a4db7994fa8
Oct 18, 2026
9b32c39
style(webviews): format list motion hook
teamleaderleo Oct 18, 2026
2fdb8ad
chore(next): PR autofix at 9b32c39839cb
Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions webviews/src/agent-session/acpmux/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,13 +1981,16 @@ export function VirtualTranscript({
let lastTurnId: string | undefined;
for (let index = rows.length - 1; index >= 0 && !lastTurnId; index -= 1)
if (rows[index]!.kind === "turnSummary") lastTurnId = rows[index]!.id;
const markTurns = () => {
const markTurns = useCallback(() => {
for (const node of thread.current?.querySelectorAll<HTMLElement>(".acpmux-row") ?? []) {
node.toggleAttribute("data-last-turn", node.dataset.rowId === lastTurnId);
node.toggleAttribute("data-turn-revealed", node.dataset.rowId === pointedTurn.current);
}
};
useLayoutEffect(markTurns);
}, [lastTurnId]);
// Mark only when the mounted rows, their range, or the last turn changes. The old no-deps
// layout effect scanned every commit, including scroll/follow state commits that cannot change
// these attributes. `pointAt` still calls the callback directly for pointer-driven updates.
useLayoutEffect(markTurns, [markTurns, rows, range.first, range.last]);
// Older history pages in before the reader reaches it: whenever the view is within two viewports
// of the first loaded row, including a tail too short to fill them. The anchoring above keeps the
// reader's row in place as each page lands.
Expand Down
Loading