Repository navigation
cmux-next: make What's New links readable and usable - #21185
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
Gallery88 states changed: pages.changelog/nightly-history, pages.changelog/nightly-update, pages.changelog/journal-update-span, pages.changelog/journal, pages.changelog/digest, ... · 1 new state · 15 broken states Diff page and renders (the run's 82 more on the diff page. Live preview (follows this branch; start it with
7 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
This comment has been minimized.
This comment has been minimized.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW:
Agents: Tour of |
|
Agents: |
Keep base's one-paragraph row (#21873) and its hover-revealed action; the row's Try it and Learn more now reveal together, on hover or keyboard focus, in grouped and digest rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- regenerated Packages/macOS/CmuxNext/ci-target-graph.json - vp fmt webviews/src/agent-session/acpmux/replyHref.ts - vp fmt webviews/src/pages/markdown/README.md - vp fmt webviews/src/pages/markdown/links.ts - vp fmt webviews/test/markdown-cmux-app-links.test.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39214229447
This comment has been minimized.
This comment has been minimized.
# Conflicts: # webviews/src/agent-session/acpmux/replyHref.ts # webviews/src/pages/markdown/links.ts
[Low impact] The PR appears safe to merge; no actionable defects or rule violations were found. SummaryAdds shared
No actionable issues were found. The ancestry check passed, but the merge bases differed, so this review used the full PR diff. No previous review threads were supplied. Tests and browser captures were not run during this review. Reviews (11) · Last reviewed commit: "Merge branch 'feat-cmux-next' into feat/..." · Reviewed by Greptile |
… target The size cap refused 8 new CmuxNextApp lines for the same handler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…new-readable-links
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…show row actions The changelog page already routes external links through LinkRouter's shared rule (PageWebView's default), so the forced cmux-browser override skipped the user's link setting, always-external rules and Shift-Command. Digest and Reader stack each change in a column, so their Try it / Learn more stay visible instead of revealing on hover over an empty gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Correctness review (subagent, read-only) at 4e9da45, and resolution:
Huge Blue at 90e812b: |
…ts-new-readable-links
This comment has been minimized.
This comment has been minimized.
|
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Found 28 test failures on Blacksmith runners: Failures
...and 18 more test failures. View all on Blacksmith
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
The What's New lane (session 5888e88b, gallery-loop-7d) owns What's New now and needs this PR to land, since the page work edits the same files. @e8f63fd9-94e8-4878-bcd4-704659aba1f2's session: please either land it, or hand it off with Agent session: cosmic-gray |
The focus ring keeps both the row link (this PR) and the reel card (#22890). Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
|
Owned by gallery-loop-b4 on cosmic-gray · session |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…ailing) Review of #21185: .cl-row-actions is a block flex box, so in the Ledger's inline bullet rows it falls onto a hidden line of its own under every change with docs or an action. Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
Agent-Session: 01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f
…ed /tmp (#23143) * cmux-next: swift test log goes in the job's RUNNER_TEMP, not the shared /tmp swift-test-summary.test.sh failed once on #21185's CI: the wrapper's /tmp/swift-test-log.* vanished mid-run, so the report could not name the unfinished test. Six later feat-cmux-next runs pass it. The crash reports already go to $RUNNER_TEMP; the log now does too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-9c97-76c3-88d7-6d0422d2fadc&host=cosmic-gray * cmux-next: the swift test wrapper stops when it cannot create its log An empty $log made the EXIT trap rm -f "" .* (every dotfile in the working directory). Found by the review of this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-9c97-76c3-88d7-6d0422d2fadc&host=cosmic-gray --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Review (subagent, correctness first): SHIP at f831d7f The new RowActions in ReleaseParts.tsx (Try it plus Learn more) uses plain anchors like the existing ItemActions, so its links route the same way. Hover reveal still applies in the grouped and Ledger designs, and Digest and Reader show the actions all the time. The new test can fail: the PR records it failing (opacity 0) at 8b1242e. Not high-risk: What's New CSS and markup only. Agent session: huge-blue |
|
Shipped in:
|
… their own Review of #23420: the wide row put Try it / Learn more in a block under the description, hidden until hover, so every row with an action kept an empty line (the #21185 bug). They now sit inline at the end of the last paragraph (after the title when there is none). The links test renders the Ledger as the page does (rowMedia) and checks where the actions sit. A side-by-side picture fills its column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray
…hanges in glass (#23420) * test(whats-new): a Ledger row shows its whole description with its picture beside it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New: the Ledger uses the pane's width, pictures beside their changes in a glass frame Leo 2026-10-21: content fills the pane with modest margins, the version and date column stays compact, the width goes to pictures beside the items and to full descriptions; no column cap; glass, never opaque. The Ledger drops its 640 px measure for 32 px margins and a 112 px gutter; each row shows its whole description (76ch measure) and, where its column is at least 720 px wide, its picture as a second column. Picture frames blur what is behind them (--surface-blur, none under Reduce Transparency) with a lit top rim. The gallery's Ledger fixture gains an Improved row with a picture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): type the Ledger row test's notes like the other changelog tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New Ledger: a row's actions end its last line, never a line of their own Review of #23420: the wide row put Try it / Learn more in a block under the description, hidden until hover, so every row with an action kept an empty line (the #21185 bug). They now sit inline at the end of the last paragraph (after the title when there is none). The links test renders the Ledger as the page does (rowMedia) and checks where the actions sit. A side-by-side picture fills its column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New: row actions are a span, valid inside the Ledger's paragraph Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): the Ledger row test waits for its row, not 20 ms Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New Ledger: a row's picture stands next to its text; the lead picture stops at 720 px The first captures put the picture at the pane's right edge, far from a 76ch line, and blew the lead screenshot up past its pixels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New Ledger: a row's text keeps at least 36ch beside its picture At 1000 px the picture column squeezed the text to about 240 px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): the Ledger row test checks for its row between acts, not inside one Review: inside one act React commits nothing, so the loop never saw the row and always ran its 200 turns. Each turn is now its own act. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ow their highlight's picture (#23874) * test(whats-new): a Ledger row shows its whole description with its picture beside it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New: the Ledger uses the pane's width, pictures beside their changes in a glass frame Leo 2026-10-21: content fills the pane with modest margins, the version and date column stays compact, the width goes to pictures beside the items and to full descriptions; no column cap; glass, never opaque. The Ledger drops its 640 px measure for 32 px margins and a 112 px gutter; each row shows its whole description (76ch measure) and, where its column is at least 720 px wide, its picture as a second column. Picture frames blur what is behind them (--surface-blur, none under Reduce Transparency) with a lit top rim. The gallery's Ledger fixture gains an Improved row with a picture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): type the Ledger row test's notes like the other changelog tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New Ledger: a row's actions end its last line, never a line of their own Review of #23420: the wide row put Try it / Learn more in a block under the description, hidden until hover, so every row with an action kept an empty line (the #21185 bug). They now sit inline at the end of the last paragraph (after the title when there is none). The links test renders the Ledger as the page does (rowMedia) and checks where the actions sit. A side-by-side picture fills its column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New: row actions are a span, valid inside the Ledger's paragraph Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): the Ledger row test waits for its row, not 20 ms Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New Ledger: a row's picture stands next to its text; the lead picture stops at 720 px The first captures put the picture at the pane's right edge, far from a 76ch line, and blew the lead screenshot up past its pixels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New Ledger: a row's text keeps at least 36ch beside its picture At 1000 px the picture column squeezed the text to about 240 px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): the Ledger row test checks for its row between acts, not inside one Review: inside one act React commits nothing, so the loop never saw the row and always ran its 200 turns. Each turn is now its own act. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * test(whats-new): a change's picture opens enlarged, and a digest entry shows its highlight's picture Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New: click a change's picture to enlarge it; digest entries show their highlight's picture Leo 2026-10-21, design pass item 2: each New/Improved change can carry a picture, lazy-loaded in a glass frame, click to enlarge. A picture's frame is now a button that opens it in a dialog (ui/Dialog: Escape, Close or a press outside close it) on a blurred backdrop, the picture whole. A nightly digest entry (digest.py) has no picture, and the page dropped its highlight file, which can have one, as a duplicate: the entry now takes that picture, matching ids as digest.py writes them. Two strings, in every language: Close (as Home's lightbox) and Enlarge picture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray * What's New: the enlarged picture opens over the page; a highlight and its entry stay one change in any language Review of #23874: the changelog page never loaded ui/popupSurface.css, which places a ui/Dialog and its backdrop (position: fixed, layers), so the lightbox would open as a flow child under the page. And add() compared raw ids, so in a non-English page a highlight file (Group_Band_Colors, English title) and its digest entry (group-band-colors, localized title) showed twice, now both with the picture: ids compare as digest.py writes them. An empty alt no longer leaves a trailing colon in the enlarge label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>






What changed
The cmux-next What's New page now keeps feature summaries readable at narrow widths and exposes docs links on every applicable feature row. In the one-line grouped rows, Try it and Learn more reveal on hover or keyboard focus; the Digest and Reader designs, which stack each change in a column, show them under the summary. Links keep going through LinkRouter's shared rule (the user's link setting, always-external rules, Shift-Command).
Why
Feature rows previously forced the title and summary onto one truncated line, and grouped entries with docs had no link at all.
Validation
bun test webviews/test/changelog-links.test.tsxbun test webviews/test/changelog-first-paint.test.tsx web/tests/whats-new-route.test.tsbun run typecheck(webviews)git diff --checkNo native change remains (the earlier cmux-browser override was dropped after review).
Observed / Not run
bun test test/changelog-links.test.tsxfails at 8b1242e (Digest row actions computed opacity 0) and passes at 90e812b withtest/changelog-first-paint.test.tsx(4 pass);bun run typecheckclean.Proof
Digest design, dark, 560 px, from the gallery advisory run of 7c03fb8 (run 39357217167; Linux Chromium, so fonts fall back). Before (base c700b6a): no Try it or Learn more under the rows. After: they show under each summary that has them.
No cmux-design-references entry exists for the What's New page.
Review: SHIP at 7c03fb8 (correctness review of 90e812b by a separate subagent, findings fixed in 8b1242e/90e812b5; 7c03fb8 is a clean merge of feat-cmux-next c700b6a, re-read by the rescue lane)
Base reds on 7c03fb8 (not this PR's)
cmux-next checks(capability-text.test.sh, check-concurrency in CmuxNextBrowser, type scale in HomeSidebarView.swift),cmux-next fast tier(CloudHomeSource+Requests.swift compile errors),defaults-snapshot(stale settings exports),react-apps-check(composer-*/narrow-layouts timeouts). None touch files this PR changes; the same reds show on #22099.Changelog
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the cmux-next What's New page so feature summaries stay readable at narrow widths, and makes
Try itandLearn moreappear in every row layout, including a newLearn morelink on rows that have docs.Try itandLearn moretogether on hover or keyboard focus.aria-labels, and each row layout.Migration
Written for commit f831d7f. Summary will update on new commits.