Skip to content

cmux-next: tune thread minimap contrast - #21183

Open
teamleaderleo wants to merge 2 commits into
feat/thread-minimap-codexfrom
fix/thread-minimap-contrast
Open

teamleaderleo wants to merge 2 commits into
feat/thread-minimap-codexfrom
fix/thread-minimap-contrast

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Tune the thread minimap's resting and current tick contrast to match the Codex reference measured by PR #20560. The first pass was approximately 25/255 too bright, so quiet ticks now use 0.28 opacity and current viewport ticks use 0.48; hover, focus, and bookmarks still reach full contrast.

This is a focused follow-up to #20560 and is based on feat/thread-minimap-codex.

Validation

  • git diff --check
  • Static CSS regression assertions passed with Bun.
  • The repository's scoped Bun test could not start because this fresh worktree has no installed @base-ui/utils dependency; no source test failure was observed.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Tunes the thread minimap resting and current tick contrast to match the measured Codex reference. Quiet ticks now use 0.28 opacity and current viewport ticks 0.48, correcting the first pass which was about 25/255 too bright while hover, focus, and bookmark states still reach full contrast.

Written for commit 74a6641. Summary will update on new commits.

View guided diff Turn on auto-fix

@cursor

cursor Bot commented Oct 16, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3d4de690-377f-420f-ada4-ad56de7865c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Found 5 test failures on Blacksmith runners:

Failures

Test View Logs
GitHub-hosted runner label: .github/workflows/
intent-familiar-review.yml:21: runs-on: ubuntu-24.04
View Logs
GitHub-hosted runner label: .github/workflows/
pr-red-checks-comment.yml:16: runs-on: ubuntu-24.04
View Logs
test_scans_only_test_sources (main.CommandLine.test_scans_only_test_sources)/
test_scans_only_test_sources (main.CommandLine.test_scans_only_test_sources)
View Logs
test_scans_the_ui_test_sources (main.CommandLine.test_scans_the_ui_test_sources) (p
ath='ios/cmuxUITests/ProbeTests.swift')
View Logs
two failed fetches then a success did not pass/
two failed fetches then a success did not pass
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Unclear: CI fast guards failed: no known signature; failed step: Run the fast guard tests.

CI failed on 74a664146e (run 38982093945 attempt 1): 2 code, 5 unknown.

Job Verdict Why
CI fast guards unknown no known signature; failed step: Run the fast guard tests
Fast static checks code a static check failed
guards / workflow-guard-tests / app-host-cache unknown no known signature; failed step: Validate iOS video recording failures
guards / workflow-guard-tests / preflight unknown no known signature; failed step: Validate macOS runner guards
guards / workflow-guard-tests / quality-determinism code a Python test failed
guards / workflow-guard-tests / release-tooling unknown no known signature; failed step: Validate retried Ghostty Zig package fetches
guards / workflow-guard-tests / release-ios unknown no known signature; failed step: Validate iOS simulator build-once contract
Matched log lines
Fast static checks: FAILED localization (0.92s)
guards / workflow-guard-tests / quality-determinism: FAIL: test_scans_only_test_sources (__main__.CommandLine.test_scans_only_test_sources)

Not re-run automatically: CI fast guards, Fast static checks, guards / workflow-guard-tests / app-host-cache, guards / workflow-guard-tests / preflight, guards / workflow-guard-tests / quality-determinism are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards failed on 74a664146e (https://github.com/manaflow-ai/cmux/actions/runs/38982093945). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant