Skip to content

next: use type-scale weight for tab overflow hint - #21153

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
fix/tab-overflow-type-scale
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
fix/tab-overflow-type-scale

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

The cmux-next Type scale check fails on TabOverflowHintView.swift:51 because the new overflow hint button uses a raw .medium font weight. This failure also appeared on UI PRs #21069, #21051, and #21053 after they incorporated the same base change.

Use Typography.system with the existing caption size and TypeScale.emphasis for the button. This keeps the hint within the shared type scale and avoids creating a fresh NSFont in applyTokens().

Validation: python3 -I scripts/cmux-next/check-swift-type-scale.py and git diff --check pass. Native build remains with CI/fleet.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the cmux-next type scale check failure on the tab overflow hint button by using Typography.system with TypeScale.emphasis instead of a raw NSFont weight.

  • Removes the need to create a fresh NSFont in applyTokens().

Written for commit 3bde12a. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d23fba3b-4457-430b-8f4e-943a92d2dfef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-jdve9 created for this PR by the cmux coordinator.

@github-actions

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 3bde12a184; ci-status is green without them.

CI passes on 3bde12a184 (run 38866102324 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

I own the shared overflow-hint lint repair in #21152 (opened before this PR). It fixes the same font-weight violation and also replaces .controlAccentColor with Palette.accent. The exact head 62a8ee8b4f86fd062636a2c48c2df5356f4c5abf passed the type-scale check and managed fleet build c601a7b73e9d85db6a0f1995; the artifact digest was verified.

Please coordinate this overlap through #21152 so the shared base gets one repair. I will not alter this branch or merge either PR.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing this duplicate repair in favor of #21152, which independently fixes the same TabOverflowHintView type-scale failure. Commit 3bde12a is already folded into existing gallery PR #21020 and additionally uses the cached Typography.system API. The source type-scale guard and ci-status passed; a full managed Mac build of this commit passed on aws-m4pro-6 (job 2f4b3e387f9c68d6132f6ef7). No source is lost by closing this duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant