Repository navigation
next: use type-scale weight for tab overflow hint - #21153
teamleaderleo wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
I own the shared overflow-hint lint repair in #21152 (opened before this PR). It fixes the same font-weight violation and also replaces Please coordinate this overlap through #21152 so the shared base gets one repair. I will not alter this branch or merge either PR. |
|
Closing this duplicate repair in favor of #21152, which independently fixes the same TabOverflowHintView type-scale failure. Commit 3bde12a is already folded into existing gallery PR #21020 and additionally uses the cached Typography.system API. The source type-scale guard and ci-status passed; a full managed Mac build of this commit passed on aws-m4pro-6 (job 2f4b3e387f9c68d6132f6ef7). No source is lost by closing this duplicate. |
The cmux-next Type scale check fails on
TabOverflowHintView.swift:51because the new overflow hint button uses a raw.mediumfont weight. This failure also appeared on UI PRs #21069, #21051, and #21053 after they incorporated the same base change.Use
Typography.systemwith the existing caption size andTypeScale.emphasisfor the button. This keeps the hint within the shared type scale and avoids creating a freshNSFontinapplyTokens().Validation:
python3 -I scripts/cmux-next/check-swift-type-scale.pyandgit diff --checkpass. Native build remains with CI/fleet.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the cmux-next type scale check failure on the tab overflow hint button by using
Typography.systemwithTypeScale.emphasisinstead of a rawNSFontweight.NSFontinapplyTokens().Written for commit 3bde12a. Summary will update on new commits.