Skip to content

cmux-next: session rail Connectors card and polish (cx-ncc.105, cx-ncc.101) - #21111

Merged
teamleaderleo merged 8 commits into
feat-cmux-nextfrom
op-next-parity-surface/session-rail-connectors
Oct 19, 2026
Merged

teamleaderleo merged 8 commits into
feat-cmux-nextfrom
op-next-parity-surface/session-rail-connectors

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #20901 (session side rail, Debug Settings agent.sessionRail).

Connectors card (cx-ncc.105).

  • Shows the MCP servers the session's harness reported loading, from acpmux's mcpServers (acpmux: session summary lists the MCP servers the harness loaded (cx-ncc.105) #20924).
  • Folded, it reads "N connected"; open, it lists each server and marks any that failed or are still connecting.
  • Only a harness that reports servers gets the card, which today means Claude Code. ACP harnesses and Codex report none, so they get no card rather than an empty one.
  • Order: Environment, Context, Connectors, Outputs.

Rail polish (cx-ncc.101), from #20901's captures:

  • In a row, the file or folder name keeps its room, and the folder path after it gives way first. Before, "Grid.tes…" and "ac…" truncated while the path took the space.
  • Opening an output's diff beside the chat can leave the pane narrower than the rail's overlay width (560px). The rail would then cover the chat, so it closes. It closes for that moment only, without remembering; the header button opens it again.

New strings (rail.connectors, rail.connected, rail.connectorFailed, rail.connectorPending) ship in all 21 locales.

Verification

  • Red, then green: bun test test/session-rail.test.tsx.
    • Narrow-overlay test: red on a86698b (the rail stayed open), green on 4ea8200.
    • Connectors test: red on bb73c01 (no card), green on df64733.
  • bun test test/session-rail.test.tsx test/ui-rules.test.ts test/tooltip-rules.test.ts test/gallery-coverage.test.ts: 16 pass.
  • vp fmt --check and vp lint are clean on the touched files.
  • Gallery: new agent-pane.session-rail variant connectors.
  • Real-app light/dark captures from a DEV build on cosmic-gray will be added to this body.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Follow-up to the session side rail (Debug Settings agent.sessionRail): adds the Connectors card and fixes two layout issues from the previous release's captures.

  • The rail now lists the MCP servers the harness reported loading (mcpServers), folded as "N connected" and open with per-server state (Failed or Connecting) where not connected. Only harnesses that report servers get the card — today that means Claude Code; ACP harnesses get none rather than an empty one.
  • Row truncation now keeps the file or folder name and gives the folder path up first, instead of truncating both equally.
  • Opening an output's diff beside the chat closes the rail when the pane narrows below the overlay width (560px), so the rail no longer covers the chat. The close is momentary and not remembered; the header button reopens it.
  • New string keys (rail.connectors, rail.connected, rail.connectorFailed, rail.connectorPending) ship in all 21 locales, with a gallery variant for the new card.
  • App-link regexes in replyHref.ts and markdown links.ts drop a useless \- escape to satisfy the no-useless-escape lint rule.

Written for commit 4e16dab. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 5 commits October 15, 2026 09:27
…the rail (red, cx-ncc.101)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ver folders (cx-ncc.101)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ported (red, cx-ncc.105)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ers (cx-ncc.105)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…105)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c3185b22-8fc5-4261-9ff4-bbbdf7a2074f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

This comment has been minimized.

@teamleaderleo teamleaderleo added area:sidebar difficulty:2 Focused: one package or feature boundary labels Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

all web/size checks green

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Passes: CI passes on 4e16dab558.

CI passes on 4e16dab558 (run 39214049384 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

CI fast guards passes on 4e16dab558 (run). This covers only the fast guards, not CI: CI's result is ci-status.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards failed on 5b2bd040ca (https://github.com/manaflow-ai/cmux/actions/runs/39210675138). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

Resolve Localizable.xcstrings by keeping base and adding the four rail.connector
keys; generated/strings.json is build output on base now (#21970). The rail's
header comment no longer says Connectors are pending.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 19, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Receipt for 4e16dab (this PR's head; a new push replaces it)

  • Visual review: HQ feed card · gallery before/after runs
  • Checks: this head
  • App of this head (app.zip, kept 1 day): gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21111 -f ref=op-next-parity-surface/session-rail-connectors -f platform=macos -f backend_mode=local

- vp fmt webviews/src/agent-session/acpmux/replyHref.ts
- vp fmt webviews/src/pages/markdown/README.md
- vp fmt webviews/src/pages/markdown/links.ts
- vp fmt webviews/test/markdown-cmux-app-links.test.ts

Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39210674968
@cursor

cursor Bot commented Oct 19, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

vp check fails react-apps-check on no-useless-escape in replyHref.ts and
markdown links.ts (red on feat-cmux-next too). The hyphen moves to the end of
each class so it stays literal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Merged feat-cmux-next in (Localizable.xcstrings: kept base, added the four rail.connector keys; generated/strings.json is build output since #21970) and fixed the no-useless-escape lint in replyHref.ts / markdown links.ts that turned react-apps-check red on base. The web checks are green at 4e16dab.

The two remaining reds are base reds, not this PR (it changes only webviews/):

  • cmux-next fast tier: MarkdownViewerWritableTests.Host does not conform to FilePageHosting. That's on base at merge-base 3a6b2b2 and fixed on base by 91418a6.
  • defaults-snapshot: also red on feat-cmux-next d3c2b25 (job 117932684971).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

merge-override: fast tier + defaults-snapshot are base reds (91418a6 fixes fast tier on base; defaults-snapshot red on d3c2b25); PR is webviews-only

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39312014758 at db370d0 failed: cmux-next web bundles (source-keyed cache).
Those jobs last passed at a79d2d7. This pull request is one of 3 merged since: #21856, #21932, #21111.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39312265470 at 41cd51f failed: cmux-next web bundles (source-keyed cache).
Those jobs last passed at a79d2d7. This pull request is one of 3 merged since: #21932, #21111, #21729.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39312344912 at 3888f63 failed: cmux-next web bundles (source-keyed cache).
Those jobs last passed at a79d2d7. This pull request is one of 4 merged since: #21932, #21111, #21729, #21272.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39312688402 at 016dffb failed: cmux-next web bundles (source-keyed cache).
Those jobs last passed at a79d2d7. This pull request is one of 5 merged since: #21932, #21111, #21729, #21272, #22012.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sidebar difficulty:2 Focused: one package or feature boundary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant