Skip to content

Agent composer: plain top strip leaves no stray hairline above the card's corners - #21031

Merged
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
cg-composer/top-strip-fixforward
Oct 15, 2026
Merged

teamleaderleo merged 6 commits into
feat-cmux-nextfrom
cg-composer/top-strip-fixforward

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

With agentPane.debug.topStripStyle = plain, a short stroke stood in the 4 px gap above both of the new chat composer's top corners (#20984). It came from the default tab's foot, .acpmux-composer > .acpmux-composer-strip::after: plain cleared the strip's own fill and hairlines but not the foot's side hairlines. It shows in light themes (Apple light, Catppuccin Latte), where the edge tone contrasts with the page. plain now drops the foot. The default and bump variants are unchanged: the new rule matches only data-top-strip="plain".

Test: composer-top-strip-variants.test.ts checks, for plain on the new chat strip, the mid-chat queue and the New Tab strip, in Catppuccin Latte, Apple System Colors Light and Catppuccin Mocha, that the strip, the queue, their pseudo-elements and the card's ::before paint no border, shadow or fill in the gap above the card.

  • 0bb5753 (test only): 3 fails, all on the new chat strip, naming acpmux-composer-strip::after with its two inset side hairlines; the queue and New Tab cases pass.
  • 95766d8 (fix): 27/27 pass locally. composer-location-strip (22/22) and composer-row-layout (27/27) pass, and so does bun run check.

The browser runs used #21020's gallery reader fix, applied locally and not committed. Base gallery browser tests fail without it.

Plain, before (484eb88) and after, at 760 px, with a zoomed crop of the top-left corner:

Theme Before: corner After: corner
Apple light
Catppuccin Latte
Catppuccin Mocha

760 px

Theme Before After
Apple light
Catppuccin Latte
Catppuccin Mocha

400 px

Theme Before After
Apple light
Catppuccin Latte
Catppuccin Mocha

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 15, 2026 04:12
The default tab's foot (.acpmux-composer > .acpmux-composer-strip::after,
side hairlines below the strip) still paints under data-top-strip=plain:
a short stroke stands in the 4 px gap above both of the card's top
corners on the new chat strip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under agentPane.debug.topStripStyle=plain the default tab's foot
(.acpmux-composer > .acpmux-composer-strip::after) kept its side
hairlines, so a 2.5 px stroke stood in the gap above both of the card's
top corners, visible in light themes. plain now drops the foot; default
and bump are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 15, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: bfe50393-2628-4313-b23b-13215814754e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-5ugyp created for this PR by the cmux coordinator.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

all web/size checks green

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Gallery

Review in feed

155 states changed: agent-pane.artifact-panel/versions, agent-pane.chat-width/standard, agent-pane.transcript/long-code, agent-pane.chat-width/wide, agent-pane.chat-width/wide-blocks, ... · 69 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State Before · after
agent-pane.artifact-panel/versions (Apple System Colors, webkit)
agent-pane.chat-width/standard (Apple System Colors, chromium)
agent-pane.transcript/long-code (Apple System Colors Light, webkit)
agent-pane.transcript/long-code (Apple System Colors Light, chromium)
agent-pane.chat-width/standard (Apple System Colors Light, webkit)
agent-pane.chat-width/wide (Apple System Colors Light, webkit)

149 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

  • agent-pane.artifact-panel/versions: /wt/cg-composer-top-strip-fixforward/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/versions
  • agent-pane.chat-width/standard: /wt/cg-composer-top-strip-fixforward/?entry=agent-pane.chat-width#/agent-pane.chat-width/standard
  • agent-pane.transcript/long-code: /wt/cg-composer-top-strip-fixforward/?entry=agent-pane.transcript#/agent-pane.transcript/long-code
  • agent-pane.chat-width/wide: /wt/cg-composer-top-strip-fixforward/?entry=agent-pane.chat-width#/agent-pane.chat-width/wide
  • agent-pane.chat-width/wide-blocks: /wt/cg-composer-top-strip-fixforward/?entry=agent-pane.chat-width#/agent-pane.chat-width/wide-blocks
  • agent-pane.edited-files-settings/defaults: /wt/cg-composer-top-strip-fixforward/?entry=agent-pane.edited-files-settings#/agent-pane.edited-files-settings/defaults
  • 86 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

  • agent-pane.artifact-panel/versions (Apple System Colors, webkit): play: waitFor did not hold within 5000 ms
  • agent-pane.artifact-panel/versions (Apple System Colors Light, webkit): play: waitFor did not hold within 5000 ms
  • agent-pane.artifact-panel/versions (Apple System Colors Light, chromium): play: no element for button "Open preview"
  • agent-pane.bottom-stack/trust-then-individual (Apple System Colors Light, chromium): step 1 click button "Trust": layout shift 0.1064 (limit 0) · step 3 click .acpmux-access-grant-remove: layout shift 0.1064 (limit 0)
  • agent-pane.bottom-stack/trust-then-individual (Apple System Colors, chromium): step 1 click button "Trust": layout shift 0.0924 (limit 0) · step 3 click .acpmux-access-grant-remove: layout shift 0.0924 (limit 0)
  • agent-pane.bottom-stack/trust-then-permission (Apple System Colors, chromium): step 1 click button "Trust": layout shift 0.1658 (limit 0) · step 3 click .acpmux-access-grant-remove: layout shift 0.1658 (limit 0)
  • 288 more on the diff page

310 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

2119 unchanged · base 799a5bf · head fefdc01

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on fefdc010bc.

CI passes on fefdc010bc (run 38753806116 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on fefdc010bc (https://github.com/manaflow-ai/cmux/actions/runs/38753806116). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

@cursor

cursor Bot commented Oct 15, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo
teamleaderleo merged commit 78d543d into feat-cmux-next Oct 15, 2026
107 of 109 checks passed
@teamleaderleo
teamleaderleo deleted the cg-composer/top-strip-fixforward branch October 15, 2026 15:28
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
github-actions Bot added a commit that referenced this pull request Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

cmux-next tour of fefdc010bc70d0b8d52729da81165979321935c6 (run)

Path-selected interactions

Interaction Changed paths
agent-pane webviews/src/agent\-session/acpmux/composerLocation.css
core webviews/test/composer\-top\-strip\-variants.test.ts

Agent pane (before): 3 ok

tour

Video (mp4)

# Step Result Command
1 Launch ok
2 Open agent chat ok cmux agent new-chat
3 Queue a second chat ok cmux agent new-chat
Screenshots (3)

1. Launch
Launch

2. Open agent chat
Open agent chat

3. Queue a second chat
Queue a second chat

### Agent pane \(after\): 3 ok

tour

Video (mp4)

# Step Result Command
1 Launch ok
2 Open agent chat ok cmux agent new-chat
3 Queue a second chat ok cmux agent new-chat
Screenshots (3)

1. Launch
Launch

2. Open agent chat
Open agent chat

3. Queue a second chat
Queue a second chat

### Core UI \(before\): 12 ok

tour

Video (mp4)

# Step Result Command
1 Launch ok
2 New workspace ok cmux workspace new --name Tour
3 Type in the terminal ok cmux workspace name:Tour screen current pane current tab current terminal current write --text "echo hello from the cmux-next tour\r"
4 Split right ok cmux action run splitRight
5 Split down ok cmux action run splitDown
6 New terminal tab ok cmux action run newSurface
7 Browser tab ok cmux tab new-browser --url https://example.com
8 Hide the sidebar ok cmux action run toggleSidebar
9 Show the sidebar ok cmux action run toggleSidebar
10 Notification ok cmux notify --title Tour --body "Hello from CI"
11 Notifications panel ok cmux action run showNotifications
12 Agent chat ok cmux agent new-chat
Screenshots (11)

1. Launch
Launch

2. New workspace
New workspace

3. Type in the terminal
Type in the terminal

4. Split right
Split right

5. Split down
Split down

6. New terminal tab
New terminal tab

7. Browser tab
Browser tab

8. Hide the sidebar
Hide the sidebar

10. Notification
Notification

11. Notifications panel
Notifications panel

12. Agent chat
Agent chat

### Core UI \(after\): 12 ok

tour

Video (mp4)

# Step Result Command
1 Launch ok
2 New workspace ok cmux workspace new --name Tour
3 Type in the terminal ok cmux workspace name:Tour screen current pane current tab current terminal current write --text "echo hello from the cmux-next tour\r"
4 Split right ok cmux action run splitRight
5 Split down ok cmux action run splitDown
6 New terminal tab ok cmux action run newSurface
7 Browser tab ok cmux tab new-browser --url https://example.com
8 Hide the sidebar ok cmux action run toggleSidebar
9 Show the sidebar ok cmux action run toggleSidebar
10 Notification ok cmux notify --title Tour --body "Hello from CI"
11 Notifications panel ok cmux action run showNotifications
12 Agent chat ok cmux agent new-chat
Screenshots (11)

1. Launch
Launch

2. New workspace
New workspace

3. Type in the terminal
Type in the terminal

4. Split right
Split right

5. Split down
Split down

6. New terminal tab
New terminal tab

7. Browser tab
Browser tab

8. Hide the sidebar
Hide the sidebar

10. Notification
Notification

11. Notifications panel
Notifications panel

12. Agent chat
Agent chat

Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant