Skip to content

Gallery: composer-context computer-menu play matches the computer's new accessible name - #20997

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
cg-composer/fix-computer-play
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
cg-composer/fix-computer-play

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

#20791 put the machine in the composer strip's computer button name ("Computer: This Mac", so the icon-only computer under 460 px stays named). The agent-pane.composer-context computer-menu play still clicked an exact "Computer", found nothing, and test/composer-type-scale.test.ts failed on feat-cmux-next.

Now the play matches /^Computer\b/.

Tests: CMUX_BROWSER_TESTS=1 bun test test/composer-type-scale.test.ts -t composer-context (4 pass, was 1 fail), plus the other browser tests that open composer-context; bun run check clean. No UI change.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the composer-context gallery play so it finds the computer button by its new accessible name. #20791 changed the button's name to include the machine ("Computer: This Mac"), so the exact "Computer" match failed and test/composer-type-scale.test.ts broke on feat-cmux-next. The play now matches /^Computer\b/. No UI change.

Written for commit af7952b. Summary will update on new commits.

View guided diff Turn on auto-fix

#20791 put the machine in the computer button's accessible name
("Computer: This Mac"), so the computer-menu play's exact "Computer"
match found nothing and composer-type-scale failed on feat-cmux-next.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 01090aee-5ee0-4162-87b4-5a91a2e2122e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-re28x created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 15, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Gallery

Review in feed

8 states changed: agent-pane.composer-context/computer-menu · 2 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State Before · after
agent-pane.composer-context/computer-menu (Apple System Colors Light, webkit)
agent-pane.composer-context/computer-menu (Apple System Colors Light, chromium)
agent-pane.composer-context/computer-menu (Apple System Colors, chromium)
agent-pane.composer-context/computer-menu (Apple System Colors, webkit)
agent-pane.composer-context/computer-menu (Apple System Colors Light, webkit)
agent-pane.composer-context/computer-menu (Apple System Colors Light, chromium)

2 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

  • agent-pane.composer-context/computer-menu: /wt/cg-composer-fix-computer-play/?entry=agent-pane.composer-context#/agent-pane.composer-context/computer-menu

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

  • agent-pane.composer-context/duplicate-search (Apple System Colors Light, chromium): step 2 type "adopt": layout shift 0.0315 (limit 0)
  • agent-pane.composer-context/duplicate-search (Apple System Colors Light, chromium): step 1 click button "Folder": 1 frame(s) over 33 ms (longest 53.3 ms) · step 2 type "adopt": layout shift 0.0131 (limit 0)
  • agent-pane.composer-context/folder-menu (Apple System Colors Light, chromium): step 1 click button "Folder": 1 frame(s) over 33 ms (longest 51.5 ms)

1 nondeterministic state differed from a second render of the same head (a clock or fixture leak) and is not counted as changes.

55 unchanged · base 348609e · head af7952b

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Duplicate of #20995, which makes the same one-line fix to the computer-menu gallery play in ComposerContext.gallery.tsx and opened first. The play now matches the button by /^Computer/ because #20791 renamed it to "Computer: This Mac". #20995 is the fix to keep. No more pushes here; leaving this open for a human to close.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #20995, merged into feat-cmux-next at 4ee725e. That change already matches the renamed Computer button with /^Computer/ in ComposerContext.gallery.tsx and fixes this exact gallery setup failure. The remaining duplicate change is a word-boundary refinement and comment; no outstanding review threads remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant