Repository navigation
Gallery: composer-context computer-menu play matches the computer's new accessible name - #20997
teamleaderleo wants to merge 1 commit into
Conversation
#20791 put the machine in the computer button's accessible name ("Computer: This Mac"), so the computer-menu play's exact "Computer" match found nothing and composer-type-scale failed on feat-cmux-next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
|
Found 1 test failure on Blacksmith runners: Failure
|
Gallery8 states changed: agent-pane.composer-context/computer-menu · 2 play checks failed Diff page and renders (the run's 2 more on the diff page. Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
1 nondeterministic state differed from a second render of the same head (a clock or fixture leak) and is not counted as changes. |
|
Duplicate of #20995, which makes the same one-line fix to the computer-menu gallery play in |
|
Closing as superseded by #20995, merged into feat-cmux-next at 4ee725e. That change already matches the renamed Computer button with /^Computer/ in ComposerContext.gallery.tsx and fixes this exact gallery setup failure. The remaining duplicate change is a word-boundary refinement and comment; no outstanding review threads remain. |






#20791 put the machine in the composer strip's computer button name ("Computer: This Mac", so the icon-only computer under 460 px stays named). The
agent-pane.composer-contextcomputer-menuplay still clicked an exact "Computer", found nothing, andtest/composer-type-scale.test.tsfailed on feat-cmux-next.Now the play matches
/^Computer\b/.Tests:
CMUX_BROWSER_TESTS=1 bun test test/composer-type-scale.test.ts -t composer-context(4 pass, was 1 fail), plus the other browser tests that open composer-context;bun run checkclean. No UI change.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the composer-context gallery play so it finds the computer button by its new accessible name. #20791 changed the button's name to include the machine ("Computer: This Mac"), so the exact "Computer" match failed and
test/composer-type-scale.test.tsbroke on feat-cmux-next. The play now matches/^Computer\b/. No UI change.Written for commit af7952b. Summary will update on new commits.