[teamleaderleo]

An agent chat that waits on a tool permission now gets a banner with Allow once and Deny (destructive), as classic's feed permission banners have. The banner body says what the agent asks to do (the tool call's title and command, secrets scrubbed) instead of the chat's last message. Parity gap row 2 of cmuxterm-hq#2099, bead cx-kz6m0.2.

How it answers:

• When an agent chat's "needs input" notification arrives for a tab whose session runs on this Mac's acpmux, the app reads the chat's pending prompts (_acpmux/info) on a short connection proven as the person (the same initialize + _acpmux/person_prove handshake the feed bridge uses). The category is attached only when exactly one tool permission is pending and it offers allow_once and a reject option. Questions, several prompts, terminal tabs, and chats on another Mac keep the plain banner.
• Allow once needs the Mac unlocked (.authenticationRequired). Each button re-reads the prompt and answers with _acpmux/permission_respond only while the same request (sha256, as the feed bridge checks) is pending. The decision-to-option mapping is now one function shared with AcpmuxPermissionFeedBridge. A prompt that ended or changed answers nothing and opens the tab.
• Only banners this launch posted answer; one left in Notification Center from an earlier launch does nothing. A newer banner on the same tab retires the older one's buttons, so the app keeps at most one approval entry per tab.
• The banner waits for the prompt read before it posts. If the tab was read meanwhile (focused, or answered in the chat) or a newer notification of it arrived, it posts nothing.
• Where macOS hides previews (locked screen, Show Previews off), the approval category shows "An agent is waiting for your approval" instead of the command.
• debug.notifications gains allow / deny actions and an approval field per banner, for dogfooding without clicking.

Not covered: terminal agents' hook approvals ("Claude needs approval", body "Bash"). NEXT's hooks only notify and nothing blocks on an answer, so there is no prompt to answer from a banner. That needs a blocking hook path in cmux-tui and is left for a follow-up.

Where the code lives: CmuxNextApp is size-capped (code-quality.md SW14), so the answerer, the person-proven acpmux line, the banner bookkeeping and category, and the prompt helpers the feed bridge shares (digest, request frame, shown command, option mapping), plus FeedSecretScrubber, are in CmuxNextAgentPane/Approvals/. The prompt helpers and the scrubber stay internal there; the feed bridge reaches them through extensions on the request dictionary, the offered options, String and Data (package-conventions-lint refuses all-static public enums). That target already holds the acpmux connection types. CmuxNextApp keeps the wiring in NotificationCenterService+Approvals.swift and DesktopNotifier, and ends 57 Swift lines smaller than its base. Package.swift is unchanged.

Verification

Fleet scripts/ci/run-swift-testing-suites.sh Packages/macOS/CmuxNext, focused on ApprovalBannerTests (boundary test: a daemon notification goes through NotificationCenterService.deliver, the test reads desktop.posted and the answers a stand-in answerer got):

• Red, test plus empty seams at 8d46d0b (step bdb2f4b8c04b83008f424056): Suite ApprovalBannerTests failed after 0.013 seconds with 5 issues (no approval category, body is the last message, buttons answer nothing).
• Green at 04c964e (step 32ce136bb3b15fb50135bb21): Suite ApprovalBannerTests passed after 0.011 seconds.
• Green again at 04c964e (step 89d253e03c2487a618cd4920): Suite ApprovalBannerTests passed after 0.009 seconds, and every suite in the run passed.
• Other suite failures in those runs (RapidWorkspaceCreateTests, ThemeEditsTests, ThemeLivePreviewTests, SidebarInsertWhileDisplayAsleepTests, BranchStateResourcesTests) differ between runs and touch none of these files.
• Release compile scripts/cmux-next/check-release-compile.sh at 04c964e (step d18f6ef576562df80edd4be2): ** BUILD SUCCEEDED **.
• check-concurrency, crash_ratchet, check-no-godfiles (--base), check-state-roots, check-system-blue, check-test-notification-centers, check-l10n: ok.

Review fixups, red then green with ApprovalBannerTests (three new cases: a read outlived by an acknowledge, a newer ask during a read, an older banner's buttons):

• Red at 2f5efe1 (step bdf6fe00da27516b606efdb7): Suite ApprovalBannerTests failed after 0.018 seconds with 3 issues.
• Green at f2721f4 (steps b81a6584555bdf1fe4b19278 and 2aa254edd299e889e5a75107): Suite ApprovalBannerTests passed, and every suite in both runs passed.
• Release compile at f2721f4 (step f3f8e6ed209223e6ea562a86): ** BUILD SUCCEEDED **.

After the move, at b893776 (check-app-size.sh: ok, 113672 lines, 20 under the cap 113692):

• Green twice (steps d8d59294a32b40474a2a6a86 and 1162006d98b89753bb52b53c): Suite ApprovalBannerTests passed. Other failures in those runs: SidebarInsertWhileDisplayAsleepTests (also red before this change), and one CloudBringBackTests or CloudMoveTests case per run, each a different test timing out on the same worker.
• Release compile (step 8cc76f09baeae2769c048f33): ** BUILD SUCCEEDED **.
• Pre-push checks, check-layers, check-module-resources and the freeze check pass.

After the lint fix, at ca386d5 (check-app-size.sh: ok, 113672 lines; lint-ios-package-conventions.sh: no ERROR lines):

• Green (step de9ad588c557d96a73ae3ff6): Suite ApprovalBannerTests passed, and every suite in the run passed.
• Release compile (step 160255c8408dcc48f8b513e3): ** BUILD SUCCEEDED **.

After merging feat-cmux-next with #20960 (finished-banner bursts), at f99c1fe (check-app-size.sh .: ok, 113665 lines, 70 under the cap 113735). Approvals are warnings and never join a burst; an acknowledge clears both:

• Green (step b35665aa19b42530cb8eeb8f): Suite ApprovalBannerTests passed and Suite FinishedBannerBurstTests passed. ClassicShortcutsUpgradeTests and SettingsSchemaExportTests failed in that run; this branch touches no settings, shortcut or schema files.
• Release compile (step 39adbfbaf193cdaaa11ebe18): ** BUILD SUCCEEDED **.

Not verified live: no capture of the banner's buttons on a real Mac yet; the acpmux connection path is exercised only by Release compile, not by a running acpmux.

Localization: three new strings (notifications.approval.allowOnce, notifications.approval.deny, notifications.approval.hiddenBody) with all 21 locales in CmuxNextApp's Localizable.xcstrings.

Base reds in cmux-next checks, not this change and not gating (coordinator): Motion tokens (ColorTransition.swift), Type scale (BrowserFitFrameView.swift), Package conventions lint (BuiltInAdBlockerSetting.swift). The compile queue check is stuck and does not gate; the fleet Release compile above covers it.

Changelog

• Added: Agent chat approval notifications in cmux NEXT have Allow once and Deny buttons and say what the agent asks to run.

🤖 Generated with Claude Code

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 7238c39b-280c-4aa4-afe3-309b34bae307

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

all web/size checks green

[github-actions]

Not verified: macOS jobs did not run: compile and app tests were skipped on f99c1fe37a; ci-status is green without them.

CI passes on f99c1fe37a (run 38738233773 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
convention violations found (ERROR lines above)./ convention violations found (ERROR lines above).	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Current head is green on the portable/static checks, but the target branch skipped the macOS compile and app/UI checks. I’m keeping this open until an exact-head macOS build exercises the approval banner in a narrow pane, including stale-prompt retirement, Allow once, Deny, reconnect, and focus restoration.

[github-actions]

cmux-next tour of f99c1fe37a5e37f69143432b9567b120bcbf885b (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

_{Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.}