Repository navigation
Status icon on the left or right of rows and tabs, by default - #20900
teamleaderleo wants to merge 11 commits into
Conversation
Red: with Debug Settings sidebar.rowBadge on the new Status icon style, a sidebar row still draws its kind icon and corner badge, a tab keeps its mark on the icon's corner, and sidebar.statusIconSide is not a Debug choice yet. SidebarRowBadgeStyle moves to CmuxNextDesign so tabs can follow it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Debug Settings sidebar.rowBadge gains Status icon: a row drops its kind icon and badge for one status icon (its most urgent state), on the side the new Debug choice sidebar.statusIconSide names (left or right, default left). Tabs follow it: the mark sits before the icon or at the title's end. The corner badge stays the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
Bead |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Red: rows still default to the corner badge with a kind icon, and in the Status icon style a browser row without a favicon shows no icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leo 2026-10-15: agent chat rows draw no chat icon by default; their status icon sits on the left (or the right, sidebar.statusIconSide), tabs match, and a browser row keeps its favicon, else a globe, on the left. The corner badge tests pin the corner look. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Found 1 test failure on Blacksmith runners: Failure
|
Red: with the Status icon look an agent chat tab still draws its chat icon, its status mark sits outside the icon slot on the left, and on the right its title starts after the empty slot. TabItem.isAgentChat marks those tabs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leo 2026-10-15: tabs match rows. With the Status icon look an agent chat tab draws no chat icon or agent mark: on the left its status icon takes the icon's slot, on the right its title starts there. Terminal and browser tabs keep their icons, browser tabs their favicon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Red: a browser row without a favicon draws a globe, and a terminal tab keeps its kind icon. TabItem.isAgentChat becomes iconIsKind (still set for agent chats only), the flag the fix reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leo 2026-10-15: no chat or kind icon on any sidebar row by default, tabs to match. Browser rows drop the globe fallback; a page's favicon still draws. Tabs hide their kind icon or agent mark (not a favicon, a user's icon or a pinned tab's), and the status icon takes the icon's slot on the left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leo and Lawrence's team call asked for status icons on sidebar rows and tabs in place of kind icons with a corner badge, on the left or the right, with tabs matching rows. Leo 2026-10-15: no chat or kind icon on any sidebar row by default, the status icon follows
sidebar.statusIconSide, and tabs match.sidebar.rowBadge, new default Status icon): no kind icon on any row (agent, terminal, browser), no corner badge, no unread count. One status icon shows the row's most urgent state (error, then needs input, then working, then done for unread work); its tooltip lists every pending item.sidebar.statusIconSide, left or right, default left): a Debug Settings choice until it is promoted.Call for Leo: browser favicons. A browser row or tab keeps its page's favicon on the left, since it is the page's own icon, not a kind icon (you asked for favicons there separately). Until a page reports one, the row shows no icon (the globe kind icon is gone).
SidebarRowBadgeStylemoves to CmuxNextDesign so the tab strip can read it.Stills
Real cmux NEXT DEV build of this head. Same window and workspaces in each: deploy (needs permission), review (question), tests (done), api (needs permission in a tab, with working, permission, done and browser tabs), notes (quiet), docs (github.com).
A browser row keeps its favicon (docs, left):
The github.com tab in the api strip shows no favicon in these stills because its page had not loaded yet; it showed the globe kind icon in base.
Tests
StatusIconSideTestscovers the default (no chat icon, status on the left), no kind icon on any row, rows left and right, unread work showing done, titles on one column, tabs left and right, tabs without kind icons with a browser favicon kept, and tabs following the row style. Each behavior commit follows a red test commit. The corner badge tests now pin the corner look.Changelog
Changed: Sidebar rows and tabs show one status icon (on the left by default) in place of kind icons and the corner badge.
🤖 Generated with Claude Code