[teamleaderleo]

Summary

If a saved tab group was closed and then reopened, the group came back unsaved. On a partial reopen, the tabs restored later were also appended to the end of the live group instead of returning to their own places.

• When a close records a tab group, its saved-group link (saved_id) is stored with it (state/closed_tab_groups.rs).
• When reopen forms the group again, it relinks it to that saved group. It skips this if the saved group has been deleted or another live group took it (Reopen Saved Group since the close). The saved record is refreshed in the same strip change.
• Tabs that a later partial reopen brings back rejoin the live group in strip order. Each has already been put back at its recorded index, so the group keeps the order it closed in. This uses rejoin_closed_tab_group instead of tab_group_add(.., None).

Testing

• Red: at a7302081eb9a, a_closed_saved_group_reopens_linked_and_in_order failed on Linux and macOS in hosted run 38680818338 (the saved_tab_group_id was Null).
• Green: at ecce626488a9, hosted run 38682764116 with the reopen filter. Result to follow in a comment.

Changelog

Fixed: A reopened saved tab group stays saved, and its tabs keep their order.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes reopening a saved tab group so it stays linked to its saved record and keeps its tab order.

• When a group closes, its saved-group link is stored with the archive.
• Reopen relinks the group to that saved group unless the saved group is gone or another live group took it.
• The saved record stays untouched — it still names every closed tab, not only the ones reopened so far.
• Tabs restored by a later partial reopen rejoin the live group in strip order instead of appending at the end.

^{Written for commit 4a95acf. Summary will update on new commits.}

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 66a686a1-be60-4d2f-a138-efbc4f9b3651

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[teamleaderleo]

Merge receipts for head 4a95acf:

• PR checks: 85/85 green on this head.
• Hosted cmux-tui focused run (reopen filter) on this head: https://github.com/manaflow-ai/cmux/actions/runs/38692924055 green. a_closed_saved_group_reopens_linked_and_in_order and the four reopen_closed_kinds group tests pass on Linux and macOS.
• Red then green: the new test fails without the fix on two assertions, the saved-group link and the member order.
• Review subagent, second pass: the shrink fix holds, and no defects block. The edge cases after a partial reopen (order after strip edits, the saved record shrinking on edits, Reopen Saved Group on a partial group, the relink retry) are filed as cx-vh6js.