Repository navigation
webviews test: warm Vite in claude-reasoning-default (base red) - #20885
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
check:browser-lanes requires every browser test that starts Vite to warm it first; #20592 added this one without the call, so bun run check failed on base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Bead |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a feat-cmux-next base red. #20592 added
webviews/test/claude-reasoning-default.test.ts, which starts a Vite dev server without warming it. As a result,bun run checkfails atcheck:browser-lanesand makes react-apps-check red for every web PR.This adds one
warmViteServer(vite, "/gallery/frame.html")call afterlisten(), the same as the other gallery-dev browser tests (composer-capture, changes-review-threads). The assertions are unchanged.Red: on base 82e0e8c,
bun run check:browser-lanesfails:test/claude-reasoning-default.test.ts: starts a Vite dev server without warming it.Green: on this head, same Linux builder:
check:browser-lanespasses.bun run checkpasses.CMUX_BROWSER_TESTS=1 bun test test/claude-reasoning-default.test.tspasses 2 of 2.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a red base on
feat-cmux-nextby warming the Vite dev server in theclaude-reasoning-defaultwebview test.#20592 added this test without the
warmViteServer(vite, "/gallery/frame.html")call that other gallery-dev browser tests use, sobun run checkfailed atcheck:browser-lanes. This adds the missing call afterlisten(); assertions are unchanged.Written for commit 276fb7d. Summary will update on new commits.