Skip to content

webviews test: warm Vite in claude-reasoning-default (base red) - #20885

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
op-next-reasoning-default-warm
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
op-next-reasoning-default-warm

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a feat-cmux-next base red. #20592 added webviews/test/claude-reasoning-default.test.ts, which starts a Vite dev server without warming it. As a result, bun run check fails at check:browser-lanes and makes react-apps-check red for every web PR.

This adds one warmViteServer(vite, "/gallery/frame.html") call after listen(), the same as the other gallery-dev browser tests (composer-capture, changes-review-threads). The assertions are unchanged.

Red: on base 82e0e8c, bun run check:browser-lanes fails:
test/claude-reasoning-default.test.ts: starts a Vite dev server without warming it.

Green: on this head, same Linux builder:

  • check:browser-lanes passes.
  • bun run check passes.
  • CMUX_BROWSER_TESTS=1 bun test test/claude-reasoning-default.test.ts passes 2 of 2.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes a red base on feat-cmux-next by warming the Vite dev server in the claude-reasoning-default webview test.

#20592 added this test without the warmViteServer(vite, "/gallery/frame.html") call that other gallery-dev browser tests use, so bun run check failed at check:browser-lanes. This adds the missing call after listen(); assertions are unchanged.

Written for commit 276fb7d. Summary will update on new commits.

View guided diff Turn on auto-fix

check:browser-lanes requires every browser test that starts Vite to warm it
first; #20592 added this one without the call, so bun run check failed on base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b7eeb78a-bf75-42c7-9ad8-f8ac03d8193d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-ukk7e created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Duplicate of #20884 (landed as a49002b), which adds the same warmViteServer call. Closing.

@teamleaderleo
teamleaderleo deleted the op-next-reasoning-default-warm branch October 15, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant