Repository navigation
cx-6uj1l: agent pages follow Labs and page settings from launch - #20878
Conversation
…tings Launch binds the actions before Settings start, and those bindings make the agent tabs store, which then never follows cmux.json: Labs on shows in Settings and the sidebar, never on an agent page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AppActions.bind runs before startSettingsAndControl, and FilePageHandlers, AgentHandlers and the Cloud move bindings touch services.agentTabs, so the store was made with services.settings nil and never followed cmux.json: labs.previewFeatures (session coverage label, plan card), agentPane.editedFiles, zoom, composer and diff colors stayed at their fallbacks on every agent page, and toggling did nothing. Setting AppServices.settings now makes an existing store follow it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
all web/size checks green |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
… test restores env Review on #20878: cancel the old observation tasks before following a new controller, check the store exists before Settings (the case under test), and put the test's process environment back afterwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cursors/labs-page-follow
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cursors/labs-page-follow
…cursors/labs-page-follow
|
cmux-next tour of Path-selected interactions
Agent pane (before): 3 ok
Screenshots (11)1. Launch
Screenshots (11)1. Launch Tours are data in |
































cx-6uj1l. With
labs.previewFeatureson, agent pages never got preview, whether at launch or when it was turned on while the app ran. The setting read true and the sidebar showed Lanes, but the agent pane's Labs surfaces (the session coverage label, and the plan card in #20833 and recap card in #20867) never appeared. The same bug left the other page settings at their fallbacks on every agent page:agentPane.editedFiles.*, zoom, composer anddiff.colors.Cause. At launch,
AppActions.bindruns before Settings start. Three bindings readservices.agentTabsright away:FilePageHandlers(openFiles)AgentHandlers(moveToFloatingChat)CloudHandlers+Move(uploader)That creates the lazy store while
services.settingsis nil, and the store follows the page settings only when it gets them in its init. So it never followed them.Fix.
AppServices.settingsnow has adidSetthat makes an already-created store follow the settings. A store made later still follows them through its init, so it works whatever touches the store first.Testing
AgentPageLabsFollowTests. It binds the actions, then sets Settings with Labs on, opens an agent view and expects preview on. Then it turns Labs off and expects preview off.SidebarInsertWhileDisplayAsleepTests. It is likely display-host dependent, but that isn't confirmed. It also had the known same-tree skip guard.Changelog
🤖 Generated with Claude Code