Repository navigation
Fix Codex memory worker session ownership - #20849
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
austinywang
force-pushed
the
fix/20739-codex-memory-session
branch
from
October 15, 2026 01:20
9031b93 to
76f4dd4
Compare
Contributor
|
Merge receipt for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20739. Codex's internal memory-consolidation worker can run hooks from
~/.codex/memorieswithout a durable transcript while sharing the visible Codex process. cmux now drops those internal or explicitly marked subagent hook events before they can create a session record or replace the foreground surface's resume binding. The regression test keeps the user's binding in place when the memory worker starts.Testing
CodexTurnCompletionOwnershipTests.internalMemorySessionCannotReplaceForegroundResumeBinding.python3 scripts/verify-local.py— passed localization-defaults, test-wiring, and feature-flags; Swift syntax was unsupported becauseswiftcis not installed../scripts/test-unit.sh -only-testing:cmuxTests/CodexTurnCompletionOwnershipTests test— unavailable locally becausexcodebuildis not installed in this environment.glaeda-gh wait pr manaflow-ai/cmux#20849 --until green— completed successfully; macOS compile admission, CLI product tests, and all three CLI regression shards passed.The regression test is committed before the fix in
06200474; the fix is76f4dd4e.Changelog
Fixed: Codex memory-consolidation sessions no longer replace the foreground tab's resume session
Proof
Hosted macOS app-host execution completed successfully; no screenshot is applicable.
Checklist