Repository navigation
Custom sidebar: expose workspace emoji in data context - #20828
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
Dogfood tours of
|
|
Closeout verification update:\n\n- The PR head matches the verified local and remote branch head.\n- The PR is open, non-draft, mergeable, and clean.\n- Required checks are green or intentionally skipped.\n- No unresolved review threads remain.\n\nThis PR is ready for review. No merge was performed. |
|
Merge receipt for |
Custom JavaScript sidebars can already write the system clipboard through the gesture-gated
clipboard.write(text)API from #19333, but their workspace context still has no separate emoji value. This adds an optionalworkspaces[i].emojifield derived from the display title's leading emoji grapheme, while preserving the fulltitlevalue for existing sidebars.The value travels through the typed workspace snapshot, is omitted when no leading emoji is present, and is covered by projection tests and the custom-sidebar contract documentation.
Closes #18988
Verification
python3 scripts/localize-changes(passed; no localization keys changed)python3 scripts/localization_catalog.py check(passed)python3 scripts/verify-local.py --only test-wiring(passed)swiftc/Swift toolchain; CI should executeCustomSidebarDataContextBuilderTests.Changelog
Added
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds an optional
workspaces[i].emojifield to the custom sidebar data context, derived from the leading emoji grapheme of the workspace display title. Sidebars using the fulltitlevalue are unaffected, and the field is omitted when no leading emoji exists. Closes #18988.New Features
CustomSidebarWorkspaceSnapshotwith the optionalemojiproperty and documents the new field indocs/custom-sidebars.md.Written for commit c72fdff. Summary will update on new commits.