Repository navigation
Composer: the location strip stands a few px apart from the card - #20789
teamleaderleo wants to merge 5 commits into
Conversation
The location strip (and the queued prompts riding on it) sat flush on the composer card, its fill and edge the card's and the card's rim cut out under it, so the tab merged into the composer. It now stands 3px above the card inside its own closed hairline rim (the composer edge token), with small bottom corners, and the card keeps its whole rim. No new border weight or color; the queue stays flush on the strip as one tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
|
all web/size checks green |
This comment has been minimized.
This comment has been minimized.
|
Passes: CI passes on CI passes on Written by |
|
|
Gallery1872 states changed: agent-pane.transcript/long-code, agent-pane.artifact-panel/versions, agent-pane.reply-paths/path-forms, agent-pane.transcript/mark-unread-menu, agent-pane.new-tab/template-threads, ... · 59 play checks failed Diff page and renders (the run's 1866 more on the diff page. Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
184 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Visual preview of 663fb04: in the maintainers' private review feed. |
…/top-bump-separation
…/top-bump-separation
|
Superseded by #20984: this look is now the |
…bug toggle (#20984) agentPane.debug.topStripStyle (default | bump | plain) picks what stands on the composer card's top edge: the new chat's location strip, the New Tab's, and a started chat's queued prompts. The app sets data-top-strip on <html> for bump and plain; default sets nothing, so today's tab is unchanged. - bump (#20789): the strip, or the queue with no strip, stands 4px above the card inside its own closed hairline; the card draws its whole rim. - plain: no fill, rim or tab; muted text 4px above the card with its ink on the card's content edge (where the prompt's text starts). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>






The location strip on top of the chat composer (folder · computer · branch, the "top bump") merged into the composer card. It shared the card's fill and edge, sat flush on the card's top edge, and the card's rim was masked out under it, so the tab and the card read as one blob. Leo asked for a bit of separation, not a heavy border.
Now the strip stands 4px above the card inside its own closed hairline rim, and the card keeps its whole rim. The queued-prompts tray still sits flush on the strip, so the queue and the strip read as one tab over the card. The same change applies to the New Tab composer, which uses the same strip.
What changed
composerLocation.css: the strip gets a bottom margin (--acpmux-strip-gap, 4px), one inset hairline ring on all four sides in--acpmux-composer-edge(the existing hairline token,--cmux-hairlinewide, clear underappearance.borders = none), and small bottom corners (5px). Under a queue, its top corners stay square and its top edge gives way to the queue as before, but it keeps its bottom hairline and corners.::beforelayer with a cutout under the strip. It draws its normal--acpmux-card-ring, including focus and shell-mode states.composerStates.cssandnewtab/screen.cssupdated to match.Stills (before → after)
Catppuccin Latte / Mocha, chat composer with a project:
With queued prompts (the queue and strip are one tab, now separated from the card):
Apple System Colors light / dark (after):
Borrowed from AI Elements
From the shadcn AI Elements study (
cmux-cgc-notes/ai-elements.md):border-inputrim with no shadows layered on top. Here the strip uses one hairline ring in the existing composer edge token. There is no heavier border, no new color, and no fill step, so the strip and the card are still the same material.font-medium.Verification
test/composer-location-strip.test.ts: the strip now sits 2–6px above the card (chat, new chat, New Tab at 420/720px). The old "no hairline across the seam" pixel probe is replaced with a check that the strip draws one whole inset hairline ring and the card draws its own unmasked rim.test/agent-pane-bottom-stack.test.ts: new boundary test at 760 and 480px pane heights. With the queue and the strip both shown, the queue sits flush on the strip and the tab stands 2–6px above the card.CMUX_BROWSER_TESTS=1(composer-location-strip, agent-pane-bottom-stack, composer-edges, composer-rim-hairline, new-tab-composer-layout): 26 pass.bun run checkpasses (layers, type-scale, status-glyphs, system-blue, text-focus, fmt, lint, typecheck).🤖 Generated with Claude Code