Skip to content

settings: give freeModel.enabled a home in Agents (fix base web red) - #20568

Closed
teamleaderleo wants to merge 8 commits into
feat-cmux-nextfrom
op-next-theme/freemodel-home
Closed

teamleaderleo wants to merge 8 commits into
feat-cmux-nextfrom
op-next-theme/freemodel-home

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Base web is red: webviews/src/pages/settings/categories.test.ts "every page row has exactly one home" fails because freeModel.enabled (cx-ds09i part 1) has no card on the settings page.

This gives it one. SettingsPageLayout now lists the schema group settings.group.freeModel ("AI Models", already in the catalog and strings.json) in the Agents category, after Computer Use. The setting is about which model agents use, and its keywords are agents and models, so Agents fits it better than Accounts. Accounts has only host cards and no schema groups. No new strings and no new category.

If Lawrence's cx-ds09i part 2 places this row differently, his PR simply moves it.

The settings export was regenerated on the fleet (export-settings step 06c1a34e213c91bf2153ab93, exclusive). The only change is the new group in page.agents. The MDM exports are unchanged.

No UI recording: this adds one settings row to an existing card layout.

Testing

  • Red on base ee8d80672c35: heavy --mem 4G bun test src/pages/settings/categories.test.ts gives 5 pass, 1 fail (- "freeModel.enabled" missing from the placed rows).
  • Green on head: the same command gives 6 pass, 0 fail.
  • heavy --mem 4G bun run check (webviews): pass.
  • The Swift export suite (scripts/measure/export-settings-artifacts.sh on the fleet) exited 0 on the layout commit.
  • crash_ratchet.py ok. lint-ios-package-conventions.sh ok. check-concurrency.sh reports one existing base hit in ControlWorkspaceInfoCache.swift (cx-1ox9m). This PR does not touch that file.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the failing settings categories test by giving freeModel.enabled a home: an "AI Models" group in the Agents category, after Computer Use. The setting controls the free AI model agents use while signed out; no new strings or categories were added.

The settings schema export was regenerated on the merged head. The setting.sidebar.workspaceRow.notification default stays false to match base; the earlier autofix had regenerated it with the pre-#20483 value (true), so the fleet export was kept.

Written for commit d9f9a87. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 2 commits October 14, 2026 03:37
The categories test fails on base: freeModel.enabled (cx-ds09i part 1) had
no card on the settings page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mux-ci step 06c1a34e213c91bf2153ab93)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 14, 2026 10:44 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 46964d09-eb03-4a3c-8e51-5c128be9f729

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on d9f9a87eb4; ci-status is green without them.

CI passes on d9f9a87eb4 (run 38559603899 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

cmux-next tour of d9f9a87eb4f83ff5e9ede5514194246bf94a0654 (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.

@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 14, 2026 11:14 — with GitHub Actions Inactive
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 14, 2026 11:19 — with GitHub Actions Inactive
teamleaderleo and others added 3 commits October 14, 2026 04:50
…ings step 5dee6e63098a)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…faults to false on base (#20483)

The autofix at ee990fe regenerated these with the pre-#20483 default (true).
The export-settings step 5dee6e63098a on the same head, and base, both say false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

2 inactive deployments
artifacts — d9f9a87e Deployed Oct 14, 2026 by teamleaderleo via publish to R2 #13016
cmux-tui-merge-tree — d9f9a87e Deployed Oct 14, 2026 by teamleaderleo via publish the merge tree #653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant