Repository navigation
settings: give freeModel.enabled a home in Agents (fix base web red) - #20568
teamleaderleo wants to merge 8 commits into
Conversation
The categories test fails on base: freeModel.enabled (cx-ds09i part 1) had no card on the settings page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mux-ci step 06c1a34e213c91bf2153ab93) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
cmux-next tour of The tour job failed before the tour ran (build or setup); the run log has the output. The tour produced no media. Tours are data in |
…theme/freemodel-home
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
- regenerated schemas/defaults/cmux-next.json Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/38555713445
…ings step 5dee6e63098a) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…to op-next-theme/freemodel-home
Base web is red:
webviews/src/pages/settings/categories.test.ts"every page row has exactly one home" fails becausefreeModel.enabled(cx-ds09i part 1) has no card on the settings page.This gives it one.
SettingsPageLayoutnow lists the schema groupsettings.group.freeModel("AI Models", already in the catalog andstrings.json) in the Agents category, after Computer Use. The setting is about which model agents use, and its keywords are agents and models, so Agents fits it better than Accounts. Accounts has only host cards and no schema groups. No new strings and no new category.If Lawrence's cx-ds09i part 2 places this row differently, his PR simply moves it.
The settings export was regenerated on the fleet (export-settings step 06c1a34e213c91bf2153ab93, exclusive). The only change is the new group in
page.agents. The MDM exports are unchanged.No UI recording: this adds one settings row to an existing card layout.
Testing
ee8d80672c35:heavy --mem 4G bun test src/pages/settings/categories.test.tsgives 5 pass, 1 fail (- "freeModel.enabled"missing from the placed rows).heavy --mem 4G bun run check(webviews): pass.scripts/measure/export-settings-artifacts.shon the fleet) exited 0 on the layout commit.crash_ratchet.pyok.lint-ios-package-conventions.shok.check-concurrency.shreports one existing base hit inControlWorkspaceInfoCache.swift(cx-1ox9m). This PR does not touch that file.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the failing settings categories test by giving
freeModel.enableda home: an "AI Models" group in the Agents category, after Computer Use. The setting controls the free AI model agents use while signed out; no new strings or categories were added.The settings schema export was regenerated on the merged head. The
setting.sidebar.workspaceRow.notificationdefault staysfalseto match base; the earlier autofix had regenerated it with the pre-#20483 value (true), so the fleet export was kept.Written for commit d9f9a87. Summary will update on new commits.