Repository navigation
docs(notifications): remove outdated pre-0.60 Claude Code hooks section - #2036
BillionClaw wants to merge 1 commit into
Conversation
The Claude Code hooks section documented manual JSON configuration for notification hooks. Since PR manaflow-ai#247 (released in 0.60.0), Claude Code integration is enabled by default — cmux automatically injects notification hooks when the claude command is invoked. This manual configuration is no longer needed and is misleading for users on 0.60+.
|
@BillionClaw is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes the outdated "Claude Code Hooks" integration section from the notifications documentation. The section contained configuration instructions for versions prior to 0.60.0 that are no longer relevant following the architectural changes introduced in that release. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the now-obsolete "Claude Code Hooks" section from
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant CC as claude (wrapped binary)
participant cmux as cmux wrapper
participant N as Notification Panel
Note over CC,cmux: Automatic since v0.60.0 — no ~/.claude/settings.json config needed
U->>CC: runs claude command
CC->>cmux: hooks injected automatically by wrapper
cmux->>N: cmux notify --title 'Claude Code' --body 'Waiting for input'
N-->>U: macOS notification shown
Note over CC,cmux: Pre-0.60.0 (removed section)
U-->CC: manually add JSON hooks to ~/.claude/settings.json
Reviews (1): Last reviewed commit: "docs(notifications): remove pre-0.60 Cla..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ## Integration Examples | ||
|
|
||
| ### Claude Code Hooks | ||
|
|
||
| Add to `~/.claude/settings.json`: | ||
|
|
||
| ```json | ||
| { | ||
| "hooks": { | ||
| "Notification": [ | ||
| { | ||
| "matcher": "idle_prompt", | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "command -v cmux &>/dev/null && cmux notify --title 'Claude Code' --body 'Waiting for input' || osascript -e 'display notification \"Waiting for input\" with title \"Claude Code\"'" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "matcher": "permission_prompt", | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "command -v cmux &>/dev/null && cmux notify --title 'Claude Code' --subtitle 'Permission' --body 'Approval needed' || osascript -e 'display notification \"Approval needed\" with title \"Claude Code\"'" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### OpenAI Codex |
There was a problem hiding this comment.
The document intro (line 2) still advertises "AI agents like Claude Code" and the ## Integration Examples section now jumps straight to OpenAI Codex with no mention of Claude Code at all. A user arriving here specifically to configure Claude Code notifications will find no guidance and may incorrectly assume manual setup is still needed.
A short note at the top of the section (or a dedicated stub entry) would make the automatic-since-0.60.0 behaviour discoverable:
| ## Integration Examples | |
| ### Claude Code Hooks | |
| Add to `~/.claude/settings.json`: | |
| ```json | |
| { | |
| "hooks": { | |
| "Notification": [ | |
| { | |
| "matcher": "idle_prompt", | |
| "hooks": [ | |
| { | |
| "type": "command", | |
| "command": "command -v cmux &>/dev/null && cmux notify --title 'Claude Code' --body 'Waiting for input' || osascript -e 'display notification \"Waiting for input\" with title \"Claude Code\"'" | |
| } | |
| ] | |
| }, | |
| { | |
| "matcher": "permission_prompt", | |
| "hooks": [ | |
| { | |
| "type": "command", | |
| "command": "command -v cmux &>/dev/null && cmux notify --title 'Claude Code' --subtitle 'Permission' --body 'Approval needed' || osascript -e 'display notification \"Approval needed\" with title \"Claude Code\"'" | |
| } | |
| ] | |
| } | |
| ] | |
| } | |
| } | |
| ``` | |
| ### OpenAI Codex | |
| ## Integration Examples | |
| ### Claude Code | |
| Claude Code integration is automatic since v0.60.0 — no manual configuration required. cmux wraps the `claude` command and injects notification hooks for idle and permission prompts automatically. | |
| ### OpenAI Codex |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
Thanks for the contribution! This has been addressed by #2053 which was merged. |
2 participants
The Claude Code hooks section in the notifications docs documented manual JSON hook configuration for idle and permission prompts. This was relevant before 0.60.0.
Since PR #247 (released in 0.60.0), Claude Code integration is enabled by default — cmux automatically wraps the claude command to inject notification hooks. Users on 0.60+ no longer need this manual configuration, so the section is misleading and has been removed.
Fixes #2009.
Summary by cubic
Removed the outdated pre-0.60 Claude Code hooks section from the notifications docs to avoid misleading setup steps. Since 0.60.0,
cmuxauto-wraps theclaudecommand to inject notification hooks, so manual JSON config is unnecessary—fixes #2009.Written for commit d57f7cb. Summary will update on new commits.
Summary by CodeRabbit