Repository navigation
test: run the matrix's sidebar-order cases on the app's placement (cx-rq6i5) - #20332
Conversation
…-rq6i5) Positioned creates and Move to Bottom resolve their slot through WorkspaceVerbHandlers.place against a seeded personal order, with and without personal-mixed-order-v1, and check the sidebar's order at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
Creates take applyPendingPlacements' path (slot position, bridge.place), start where the case does not expect them, and the plan's personal rows are applied as the daemon applies set-personal-workspace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Runs the shared matrix's sidebar-order cases (
Tests/Matrix/cases.json) headless on the app's own placement code. This covers cx-rq6i5, the follow-up to cx-gkyi1. The core runner (#20253) can't check these cases, because sidebar order is the home session's personal order: the app computes it and the daemon only stores it.ModelMatrixPersonalOrderTestscovers 15 cases: New Workspace Above, Below, At Top and At Bottom from the context menu, palette and CLI, plus Move to Bottom. For each case it:WorkspaceVerbHandlers.place, the step every positioned create and Move to Bottom ends in;order-is.It runs once with
personal-mixed-order-v1and once without. It needs no daemon, window or clock, and every failure starts withMATRIX <id>:.Not covered: Move Up/Down.
movePersonalWorkspaceonly writes to the daemon and needs an active window, so a headless test sees no change. Those cases stay with the HID runner. Routing them throughplacewould make them testable here, but it changes behavior, so it is not in this PR.Verification
run-swift-testing-suites.shon 7941bea:ModelMatrixPersonalOrderTestspassed in both modes (0.23 s), andModelMatrixTestspassed.DaemonCapabilityExportTests.exportIsFresh.plans/cmux-next/daemon-capabilities.jsonis stale on the base; this PR only adds one test file.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds
ModelMatrixPersonalOrderTeststo run the shared matrix's sidebar-order cases against the app's own placement logic, which the core runner can't check because sidebar order is the home session's personal order. The test seeds three workspaces, runs each case through the app's placement code (creates via the pending-placements path, Move to Bottom viaWorkspaceVerbHandlers.place), and checks both the sidebar's immediate order and the personal order written to the daemon, once withpersonal-mixed-order-v1and once without. Move Up/Down cases remain with the HID runner because they only write to the daemon and require an active window.Written for commit 4b54607. Summary will update on new commits.