Repository navigation
cmux-next: the sidebar row's status marks are crisp, badge-tall and on the title's line (cx-b8idn) - #20320
Conversation
… title's line (red) debug.sidebar_rows now reports each visible status glyph: its box, the box its mark draws (from the mark's mask), how soft that mask is at 1x and 2x, its row title's cap-height center and the badge. sidebar-status-glyph-live.py reports an agent working and then done in a running tagged app and checks each mark. On base the SF Symbol mark is rendered at 2x and resampled into the mask (soft 0.80 at 2x), the glyph box is 12 pt next to a 16 pt badge, and it sits on the row's box center rather than the title's capitals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and on the title's line Leo 2026-10-13 (cosmic-gray): the green done check and the working mark read tiny, blurry and low beside the "1" badge. StatusMarkArt now renders an SF Symbol mark at the whole-pixel size it fills and draws it 1:1; it was rendered at the screen's scale and resampled into the mask. The row's status mark (the shared indicator, or the agent mark in its place) is as tall as the unread badge and centered on the middle of the title's capitals, on the pixel grid, instead of a 10 pt box on the row's center. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
all web/size checks green |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
…phs by row The beside-title agent mark keeps its 10 pt image; only the mark standing in for the status takes the badge height. The status frame snaps x as well as y. The live check matches each mark by its workspace's title and allows half a point at 1x, where the pixel snap alone can move it that far. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The status-glyph reporter moves out of CmuxNextApp (size cap) into CmuxNextSidebar as SidebarView.debugStatusGlyphs(), which reads the row's title, badge and SidebarStyle.badgeHeight directly; debug.sidebar_rows keeps a short JSON adapter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/SidebarStyle.swift
At the shared 10 pt status size the SF Symbol's box put its ink a quarter point low. The mark's ink is centered in whole pixels so it stays crisp. The live check's softness bounds now cover a 10 pt mark drawn at its pixel size, still far below a resampled one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Across, the symbol's box keeps its side bearings (the raised hand and the question bubble are drawn off-center on purpose). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Batch queue: dropped from this batch, conflict.
Next: merge feat-cmux-next, resolve, push. |
Leo's sidebar (cmux NEXT, macOS 27.0.1): the green done check and the gray working mark on a workspace row were tiny, blurry and sat low next to the "1" unread badge.
Why:
StatusMarkArttook the SF Symbol'scgImage(forProposedRect: nil), a 2x bitmap, and resampled it into the mask.Fix:
WorkspaceRowView+StatusGlyph.swift).SidebarStyle.statusGlyphSizeisbadgeHeight. After CmuxNext: sidebar rows tile so hover moves row to row with no flicker #20315 (op-next-theme), both read one token,Metrics.statusMarkSize(10 pt). To make both bigger, change that one token.Test
scripts/cmux-next/sidebar-status-glyph-live.py --tag <tag>attaches to a running tagged app. It makes two workspaces whose programs report done (left unseen) and working over OSC 7501. It then reads a newstatus_glyphsfield ondebug.sidebar_rows(measured in CmuxNextSidebar,SidebarView.debugStatusGlyphs()), which reports each mark's mask at 1x and 2x, its drawn box, the badge height and the title's cap center. For the mark on each named row it checks:Run against a tagged DEV build on macOS 27.0.1 (Xcode 26.6) with Leo's compact density:
Review notes (two review passes, no blockers):
Known gap: on compact rows that also show a subtitle, the status mark follows the title line while the badge stays on the row's center. op-next-theme owns the badge and has been told.
The live check ran on macOS 27 only. macOS 26 was not run.
Changelog
Fixed: The sidebar's done and working marks are crisp, as tall as the unread badge, and centered on the workspace name.
🤖 Generated with Claude Code