Repository navigation
Shift titlebar folder icon 7px left - #2030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughWhen Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c544d49b79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Draggable folder icon + focused command name | ||
| if let directory = focusedDirectory { | ||
| DraggableFolderIcon(directory: directory) | ||
| .padding(.leading, -7) |
There was a problem hiding this comment.
Preserve full hit area when shifting folder icon
Applying padding(.leading, -7) to DraggableFolderIcon shifts the rendered image left by drawing it outside its layout bounds, which can shrink the interactive region used for drag and double-click. In this titlebar stack, the leftmost visible pixels can stop hitting DraggableFolderIcon and instead fall through to the underlying drag handle, making folder dragging intermittently fail near the icon’s left edge. Use an offset/container adjustment that keeps the icon’s full 16×16 hit box intact.
Useful? React with 👍 / 👎.
Greptile SummaryThis PR makes a minimal, targeted visual adjustment to the custom titlebar by adding Key changes:
Notes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Titlebar HStack — spacing: 8"] --> B{"isFullScreen and sidebar hidden?"}
B -- Yes --> C[fullscreenControls]
C --> D{"focusedDirectory set?"}
B -- No --> D
D -- Yes --> E["DraggableFolderIcon\n.padding leading -7\n16×16 pt"]
E --> F["Text titlebarText\nbold 13pt"]
D -- No --> F
F --> G[Spacer]
style E fill:#ffd700,stroke:#333,stroke-width:2px
Reviews (1): Last reviewed commit: "Shift titlebar folder icon left" | Re-trigger Greptile |
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Sources/ContentView.swift">
<violation number="1" location="Sources/ContentView.swift:2468">
P3: The new leading padding uses `-6`, which does not match the stated 7px left shift and leaves the icon 1pt short of the requested offset.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| // Draggable folder icon + focused command name | ||
| if let directory = focusedDirectory { | ||
| DraggableFolderIcon(directory: directory) | ||
| .padding(.leading, -6) |
There was a problem hiding this comment.
P3: The new leading padding uses -6, which does not match the stated 7px left shift and leaves the icon 1pt short of the requested offset.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Sources/ContentView.swift, line 2468:
<comment>The new leading padding uses `-6`, which does not match the stated 7px left shift and leaves the icon 1pt short of the requested offset.</comment>
<file context>
@@ -2465,7 +2465,7 @@ struct ContentView: View {
if let directory = focusedDirectory {
DraggableFolderIcon(directory: directory)
- .padding(.leading, -7)
+ .padding(.leading, -6)
}
</file context>
| .padding(.leading, -6) | |
| .padding(.leading, -7) |
…lder-icon-left Shift titlebar folder icon 7px left
Summary
Testing
./scripts/download-prebuilt-ghosttykit.sh./scripts/reload.sh --tag task-titlebar-folder-icon-leftIssues
Summary by cubic
Move the draggable folder icon in the custom titlebar 6px to the left to match the task’s visual alignment. Achieved with negative leading padding (
.padding(.leading, -6)), after nudging right by 1px from the initial 7px shift.Written for commit 7f1e883. Summary will update on new commits.
Summary by CodeRabbit