Skip to content

docs(notifications): remove outdated Claude Code hooks section - #2026

Closed
BillionClaw wants to merge 1 commit into
manaflow-ai:mainfrom
BillionClaw:clawoss/fix/docs-notifications-2009
Closed

BillionClaw wants to merge 1 commit into
manaflow-ai:mainfrom
BillionClaw:clawoss/fix/docs-notifications-2009

Conversation

@BillionClaw

@BillionClaw BillionClaw commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

The pre-0.60 'Claude Code hooks' section in the Notifications docs is outdated after PR #247. Removed as suggested. Fixes #2009


Summary by cubic

Removed the outdated "Claude Code hooks" section from the Notifications docs (pre-0.60). This removes incorrect guidance and aligns the page with current notification integrations.

Written for commit a5e5a04. Summary will update on new commits.

Summary by CodeRabbit

Documentation

  • Removed integration documentation for Claude Code Hooks from notification settings guide.

The pre-0.60 "Claude Code hooks" section is no longer relevant
after PR manaflow-ai#247. Fixes manaflow-ai#2009
@vercel

vercel Bot commented Mar 24, 2026

Copy link
Copy Markdown

@BillionClaw is attempting to deploy a commit to the Manaflow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 383530a0-84a2-4e47-a9bc-7316a9b15feb

📥 Commits

Reviewing files that changed from the base of the PR and between 142c62c and a5e5a04.

📒 Files selected for processing (1)
  • docs/notifications.md
💤 Files with no reviewable changes (1)
  • docs/notifications.md

📝 Walkthrough

Walkthrough

Removed the outdated "Claude Code Hooks" integration section from the notifications documentation, including configuration snippets for idle_prompt and permission_prompt notifications that are no longer relevant after version 0.60.0.

Changes

Cohort / File(s) Summary
Documentation Cleanup
docs/notifications.md
Removed the "Claude Code Hooks" integration section including the ~/.claude/settings.json example that defined obsolete notification hooks and macOS osascript fallbacks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Hop, hop, the old hooks are gone,
No more Claude Code to carry on,
Version 0.60 brought the change,
Docs now clean, fresh, and rearranged!
✨ Obsolete code bid farewell,
Cleaner docs have tales to tell.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the outdated Claude Code hooks section from notifications documentation.
Description check ✅ Passed The description provides a clear summary and references the linked issue, but lacks detailed testing information and doesn't follow the template structure completely.
Linked Issues check ✅ Passed The changes directly address the requirement in issue #2009 to remove the outdated Claude Code hooks section from the Notifications documentation.
Out of Scope Changes check ✅ Passed All changes are in scope—only the outdated Claude Code hooks section was removed from the documentation as requested in issue #2009, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the outdated "Claude Code Hooks" integration example from docs/notifications.md, which referenced the pre-0.60 ~/.claude/settings.json hook format (idle_prompt / permission_prompt matchers) that was superseded by PR #247.

  • Change is clean and correct — the deleted JSON block is a dead-end for users on current Claude Code versions and its removal prevents confusion.
  • Minor doc gap — the file's opening sentence still lists Claude Code as the first example integration, but the "Integration Examples" section now only covers Codex and OpenCode. A follow-up PR adding an updated Claude Code hooks example (or adjusting the intro) would close the gap cleanly.

Confidence Score: 5/5

  • Safe to merge — docs-only removal of an outdated snippet with no behavioral impact.
  • Single-file documentation change that removes misleading content. The only remaining concern (intro copy referencing Claude Code without a matching example) is a non-blocking P2 that can be addressed in a follow-up.
  • No files require special attention.

Important Files Changed

Filename Overview
docs/notifications.md Removes the pre-0.60 Claude Code hooks JSON snippet from the Integration Examples section; the rest of the file is untouched. Minor doc inconsistency: the intro still lists Claude Code first despite having no corresponding integration example.

Sequence Diagram

sequenceDiagram
    participant Agent as AI Agent (Codex / OpenCode)
    participant Shell as Shell / Script
    participant cmux as cmux CLI
    participant Panel as cmux Notification Panel
    participant OS as macOS Notifications

    Agent->>Shell: trigger notify event
    Shell->>Shell: command -v cmux
    alt cmux available
        Shell->>cmux: cmux notify --title ... --body ...
        cmux->>Panel: display in-panel notification
    else cmux not available
        Shell->>OS: osascript display notification
        OS->>OS: show system alert
    end
Loading

Comments Outside Diff (1)

  1. docs/notifications.md, line 3 (link)

    P2 Introduction still leads with Claude Code

    The opening sentence lists Claude Code as the first example integration, but the "Integration Examples" section no longer includes a Claude Code entry after this removal. Readers following the intro's implied promise of Claude Code support will find no example to follow. Consider either updating the intro to reflect the current integrations or tracking a follow-up PR to add an updated hooks section (using the post-PR Enable Claude Code integration by default again #247 format).

Reviews (1): Last reviewed commit: "docs(notifications): remove outdated Cla..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@BillionClaw

Copy link
Copy Markdown
Contributor Author

This is BillionClaw. Happy to discuss the approach or make adjustments to the fix.

@lawrencecchen

Copy link
Copy Markdown
Contributor

Thanks for the contribution! This has been addressed by #2053 which was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs (Notifications): Clean up pre-0.60 "Claude Code hooks" section in "Notifications" docs

2 participants