Repository navigation
Focus Sidebar and Focus Pane 1…9 are unbound by default (restore pre-#19324/#19263 defaults) - #20172
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#19324 (Ctrl+Cmd+E) and #19263 (Ctrl+Cmd+1..9) added new default classic keys without a call. Leo's review: restore the old default (no key). The actions stay in the palette and Settings > Shortcuts so people can bind them. The socket tests bind the keys first, and the sidebar test checks the key does nothing by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
This comment has been minimized.
This comment has been minimized.
|
Passes: CI passes on CI passes on Written by |
|
|
Dogfood tours of
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge receipt for |
Leo's review of classic changes merged without a call: #19324 (Ctrl+Cmd+E, Focus Sidebar) and #19263 (Ctrl+Cmd+1…9, Focus Pane 1…9) added new default keys. This restores the old default: both are unbound. The actions stay in the command palette and in Settings > Shortcuts, so people can bind them.
ShortcutAction+Defaults.swift(package table) andKeyboardShortcutSettings.swift(app table): both actions default to unbound.web/data/cmux-shortcuts.ts: no combo, "unbound by default" note (en/ja).debug.shortcut.setlearnsfocus_sidebarandpane_digits.test_focus_sidebar_keyboard.pychecks that Ctrl+Cmd+E does nothing by default, then binds it.test_focus_pane_by_number.pybinds the key first.Austin was mailed (team mailbox) the full list of classic changes for his calls; this one was already decided by Leo.
Verification
f3cd5189):focusSidebarAndFocusPaneByNumberAreUnboundByDefaultin CmuxSettingsTests; fleetrun-swift-testing-suites.sh Packages/macOS/CmuxSettings.4ec36726): same command.Changelog
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Restores the old default for Focus Sidebar and Focus Pane 1…9: both are now unbound instead of Ctrl+Cmd+E and Ctrl+Cmd+1…9. Those defaults were added without approval in #19324 and #19263. The actions remain in the command palette and Settings > Shortcuts, so users can bind them.
debug.shortcut.setsocket command now acceptsfocus_sidebarandpane_digits; the sidebar test verifies Ctrl+Cmd+E does nothing by default, and the other tests bind the keys before exercising them and then restore the unbound default.cmux-shortcuts.ts), the package and app default tables, and the pane-number handler comments reflect the unbound defaults.Written for commit 63a8153. Summary will update on new commits.
Summary by CodeRabbit