Skip to content

Focus Sidebar and Focus Pane 1…9 are unbound by default (restore pre-#19324/#19263 defaults) - #20172

Merged
teamleaderleo merged 4 commits into
mainfrom
leo/classic-unbind-focus-keys
Oct 18, 2026
Merged

teamleaderleo merged 4 commits into
mainfrom
leo/classic-unbind-focus-keys

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Leo's review of classic changes merged without a call: #19324 (Ctrl+Cmd+E, Focus Sidebar) and #19263 (Ctrl+Cmd+1…9, Focus Pane 1…9) added new default keys. This restores the old default: both are unbound. The actions stay in the command palette and in Settings > Shortcuts, so people can bind them.

  • ShortcutAction+Defaults.swift (package table) and KeyboardShortcutSettings.swift (app table): both actions default to unbound.
  • web/data/cmux-shortcuts.ts: no combo, "unbound by default" note (en/ja).
  • Socket tests: the DEBUG debug.shortcut.set learns focus_sidebar and pane_digits. test_focus_sidebar_keyboard.py checks that Ctrl+Cmd+E does nothing by default, then binds it. test_focus_pane_by_number.py binds the key first.

Austin was mailed (team mailbox) the full list of classic changes for his calls; this one was already decided by Leo.

Verification

  • Red (test only, f3cd5189): focusSidebarAndFocusPaneByNumberAreUnboundByDefault in CmuxSettingsTests; fleet run-swift-testing-suites.sh Packages/macOS/CmuxSettings.
  • Green (4ec36726): same command.
  • The tests_v2 socket tests need a tagged app build; not run (they run in the app-host lanes).

Changelog

  • Changed: Focus Sidebar (was Ctrl-Cmd-E) and Focus Pane 1…9 (was Ctrl-Cmd-1…9) are unbound by default; bind them in Settings > Shortcuts.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Restores the old default for Focus Sidebar and Focus Pane 1…9: both are now unbound instead of Ctrl+Cmd+E and Ctrl+Cmd+1…9. Those defaults were added without approval in #19324 and #19263. The actions remain in the command palette and Settings > Shortcuts, so users can bind them.

  • The debug.shortcut.set socket command now accepts focus_sidebar and pane_digits; the sidebar test verifies Ctrl+Cmd+E does nothing by default, and the other tests bind the keys before exercising them and then restore the unbound default.
  • Docs (cmux-shortcuts.ts), the package and app default tables, and the pane-number handler comments reflect the unbound defaults.

Written for commit 63a8153. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Changes
    • Sidebar focus and pane-by-number shortcuts are no longer assigned by default. You can still bind them in shortcut settings.
    • Shortcut configuration now recognizes additional names for sidebar focus and pane-number navigation.

teamleaderleo and others added 2 commits October 12, 2026 22:07
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#19324 (Ctrl+Cmd+E) and #19263 (Ctrl+Cmd+1..9) added new default
classic keys without a call. Leo's review: restore the old default (no
key). The actions stay in the palette and Settings > Shortcuts so
people can bind them. The socket tests bind the keys first, and the
sidebar test checks the key does nothing by default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 13, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 199e8c53-7b12-4698-a209-9490c1d22c5d
📥 Commits

Reviewing files that changed from the base of the PR and between 7a70def and 63a8153.

📒 Files selected for processing: 8
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/ShortcutAction+Defaults.swift
  • Packages/macOS/CmuxSettings/Tests/CmuxSettingsTests/ShortcutActionNumberedDigitTests.swift
  • Sources/AppDelegate+PaneNumberShortcut.swift
  • Sources/KeyboardShortcutSettings.swift
  • Sources/TerminalController+ShortcutConfiguration.swift
  • tests_v2/test_focus_pane_by_number.py
  • tests_v2/test_focus_sidebar_keyboard.py
  • web/data/cmux-shortcuts.ts
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@blacksmith-sh

This comment has been minimized.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

On hold (coordinator): Austin's side is reverting #19263/#19324 directly. Leaving this open untouched; it lands only if Austin asks.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on 63a8153544.

CI passes on 63a8153544 (run 39136574246 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on 63a8153544 (https://github.com/manaflow-ai/cmux/actions/runs/39136574246). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Dogfood tours of 63a81535

sidebar-and-chrome-tour at 63a81535: not run

skipped: CI built this head on a runner pool whose products the UI test Macs cannot load, and media never compiles one; gh workflow run pr-media.yml -f pr=&lt;n&gt; -f allow_compile=true does

Tours are picked by the paths globs in dogfood/scenarios/*.json; a Dogfood-tours: a, b line in the description picks them instead (none turns this off). Look at every frame before merging: a green tour only means no step failed.

@teamleaderleo teamleaderleo added the needs a call Finished and held for a team design or product decision (see #13742 and the gallery in #15427) label Oct 13, 2026
teamleaderleo and others added 2 commits October 18, 2026 14:26
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo merged commit fd65693 into main Oct 18, 2026
91 checks passed
@teamleaderleo
teamleaderleo deleted the leo/classic-unbind-focus-keys branch October 18, 2026 15:06
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 63a8153544: every check was green at merge (35 verified; 22 skipped by policy). Full suite runs on main after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs a call Finished and held for a team design or product decision (see #13742 and the gallery in #15427)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant