Repository navigation
New Tab suggestions: solid, deduped, ranked, dismissable - #20153
Merged
Merged
Conversation
Red: two Reddit rows plus the open tab on the same ?solution= address, a press outside or Escape leaves the rows open (Escape clears the text), and the popover's fill falls back to the transparent page background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The popover's fill sits on the opaque popup surface instead of the see-through page background. Rows dedupe by canonical address (tracking and one-off token parameters stripped); a page an open tab shows is that tab, as Switch to tab, with a clean title and the host. The order is the top hit, open tabs, workspaces, visited pages, the web search and Ask, capped at eight. A press outside or Escape closes the rows and keeps the text; a second Escape leaves the field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Escape Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Escape Only tracking parameters and a bot check's answer are noise, so two Drive files or playlists never merge and a typed link never switches to another page's tab. A site name heads the title only on its front page. Return on closed suggestions takes their top row. A file page shows its path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Unclear: CI failed on
Not re-run automatically: Written by |
Contributor
Gallery113 states changed: agent-pane.artifact-panel/markdown, agent-pane.artifact-panel/versions, agent-pane.transcript/long-code, agent-pane.artifact-panel/closed, agent-pane.header-tools/customize-menu, ... · 16 new states · 42 play checks failed Diff page and renders (the run's
107 more on the diff page. Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
265 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
teamleaderleo
added a commit
that referenced
this pull request
Oct 13, 2026
…1925 12) The live overlap (No agent to ask through Search the web, Search the web for ... through the New terminal / browser / chat row) was a see-through popover; #20153 made it solid after the audited build. This gallery play keeps it covered: with no harness and typed text, the popover is opaque and every item it reaches hits the popover, not the page under it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 14, 2026
…Send, then the project row (#20148) * test: New Tab offers Integrate a harness only when none is installed, quietly, and a dismissal sticks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: Integrate a harness only when none is installed, as one dismissible line (cx-udtm2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: Integrate a harness waits for acpmux's list, counts an unavailable harness, and its dismissal outlives a relaunch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: the harness hint dismissal rides newTab.remember with the page's other choices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: Integrate a harness waits for acpmux's list, counts any listed harness, and the app keeps its dismissal (cx-udtm2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: the New Tab card is the composer's, field then model and Send then the project row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: the New Tab card is the agent composer's: field, model and Send, then its location row The project picker leaves the bar for the composer's own location row (ComposerContext) at the card's bottom, as in the agent composer; the mic and Send sit in the bar's end group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: the New Tab location row names the machine the chat starts on and offers no other Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux NEXT: the New Tab location row offers only the page's machine, by its name; the field keeps focus after a pick Review of #20148: the composer's Computer menu listed remote machines, but a New Tab chat starts where the page runs. The add-project browser test opens the location row's Add project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: New Tab suggestions cover the line and row under the field (hq#1925 12) The live overlap (No agent to ask through Search the web, Search the web for ... through the New terminal / browser / chat row) was a see-through popover; #20153 made it solid after the audited build. This gallery play keeps it covered: with no harness and typed text, the popover is opaque and every item it reaches hits the popover, not the page under it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: the overlap play must reach No agent to ask Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: New Tab's location row leaves All chats the page's only scroller In a 360px pane the card's new location row (36px) pushed the page past the window: .nt-screen scrolled beside the list and the list shrank to its 60px floor. Red: new-tab-scroll "with All chats, the list is the page's only scroller" in react-apps-check on 8a02ddc. A pane under 480px now takes the row's room from the space above the card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: base lint red, the field row's press handler takes no role (cx-d0d.80) c4b5aee added onMouseDown on .nt-input, which vp check warns on (jsx-a11y/no-static-element-interactions) and bun run check fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The New Tab search suggestions (Leo 10-13: "red" typed on a wallpaper theme):
--surface-popup), not the page background, which is see-through on a wallpaper theme. The New Tab rows and Chats list no longer show through the suggestions.www., fragment or trailing slash, no tracking parameters (utm_*,fbclid,gclid,si, …), and a bot check's answer (?solution=…&js_challenge=1&token=…) dropped. Parameters that name a page (id,list,v,q,sha, page tokens,ref) stay, so two Drive files never merge. A page an open browser tab shows is that tab, "Switch to tab".Testing
Red then green:
test/new-tab-suggestions.test.ts(new): the photo's data gives one Reddit row (the tab, "Reddit",reddit.com); the order; a typed address switches to its tab; the cap; canonical addresses; titles; page ids kept; a typed link to another Drive file stays an open row; file pages.test/new-tab-omnibar.test.tsx: outside press, Escape then Escape, Return after Escape.test/popup-surface.test.ts(browser lane):.nt-popoveris the opaque popup surface over a see-through page. Run locally withCMUX_BROWSER_TESTS=1: on the red CSS, the agent-pane case fails in Chromium and WebKit (new-tab-suggestionshas the page's transparent fill); on the fix, all 6 pass. CI'swebviews-checksstops at the base'svp checkerrors before it reachesbun test.agent-pane.new-tabvariantstyped-red-duplicates(the photo's data) andtyped-dismissed.Locally (merged head):
bun run checkis green except 4 type errors inNewTabPage.gallery.tsx(defaultKind), which are on base since #19041/#20127 and untouched here.bun test test/new-tab-*.test.* test/ui-rules.test.ts: all pass.Reviewed by a review subagent; its findings (page ids merged by a long-token rule, GitHub repo titles collapsing to "GitHub", Return doing nothing after Escape, file pages showing "file:") are fixed with tests.
Coordinated with op-next-appstore (composer rebuild) and op-next-icons (visual styling): no overlapping hunks.
Changelog
Fixed: New Tab search suggestions are a solid surface, list each page once (the open tab first), rank like a browser's address bar, and close on a click outside or Escape without losing the text.
🤖 Generated with Claude Code