Skip to content

fix(webviews): the chip skeleton bar is a small-radius rect (base red) - #20139

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
op-next-icons/skeleton-bar-rect
Oct 13, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
op-next-icons/skeleton-bar-rect

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the base red in agent-pane-no-capsules (seen on #20127). The composer chip skeleton's placeholder bar (.acpmux-chip-skeleton-bar, from cx-ncc.58) was 8px tall with a 4px radius, which makes it a capsule. POLISH.md asks for small-radius rects, so it now uses a 2px radius.

  • red: web / react-apps-check on base, run 38342112364: agent-pane-no-capsules.test.ts reports ".acpmux-chip-skeleton-bar (radius 4px, height 8px)".
  • green: this PR's web / react-apps-check (run 38343807855): PASS test/agent-pane-no-capsules.test.ts. The only remaining failure there is the known base red model-chip-fresh-chat.test.tsx ("a resumed or remote chat's chip does not guess a model"), which is already listed on cx-39b5r: New Tab always lands on the New Tab page; drop the template dots #20127.

Skipped locally: bun run check, because the new worktree has no installed dependencies. CI's react-apps-check builds the page and runs the test.

Changelog

none

🤖 Generated with Claude Code

…e red)

agent-pane-no-capsules fails on .acpmux-chip-skeleton-bar: an 8px bar with
a 4px radius is a capsule (POLISH.md: small-radius rects).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: cd5a702e-2905-49df-bbe0-591ca18cf262

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 13, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test/model-chip-fresh-chat.test.tsx/model-chip-fresh-chat.test.tsx View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 43ddf88ef9 (run 38343807855 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

Copy link
Copy Markdown
Contributor

CI fast guards failed on 43ddf88ef9 (https://github.com/manaflow-ai/cmux/actions/runs/38343807855). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

@teamleaderleo
teamleaderleo merged commit 9417d91 into feat-cmux-next Oct 13, 2026
99 of 102 checks passed
@teamleaderleo
teamleaderleo deleted the op-next-icons/skeleton-bar-rect branch October 13, 2026 04:08
@github-actions

Copy link
Copy Markdown
Contributor

Gallery

Review in feed

238 states changed: agent-pane.artifact-panel/versions, agent-pane.artifact-panel/html, agent-pane.transcript/long-code, agent-pane.chat-gallery/open, agent-pane.artifact-panel/closed, ... · 34 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State Before · after
agent-pane.artifact-panel/versions (Apple System Colors, webkit)
agent-pane.artifact-panel/html (Apple System Colors, chromium)
agent-pane.transcript/long-code (Apple System Colors Light, chromium)
agent-pane.chat-gallery/open (Apple System Colors Light, webkit)
agent-pane.artifact-panel/versions (Apple System Colors Light, chromium)
agent-pane.artifact-panel/closed (Apple System Colors Light, chromium)

232 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

  • agent-pane.artifact-panel/versions: /wt/op-next-icons-skeleton-bar-rect/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/versions
  • agent-pane.artifact-panel/html: /wt/op-next-icons-skeleton-bar-rect/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/html
  • agent-pane.transcript/long-code: /wt/op-next-icons-skeleton-bar-rect/?entry=agent-pane.transcript#/agent-pane.transcript/long-code
  • agent-pane.chat-gallery/open: /wt/op-next-icons-skeleton-bar-rect/?entry=agent-pane.chat-gallery#/agent-pane.chat-gallery/open
  • agent-pane.artifact-panel/closed: /wt/op-next-icons-skeleton-bar-rect/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/closed
  • agent-pane.transcript/github-references: /wt/op-next-icons-skeleton-bar-rect/?entry=agent-pane.transcript#/agent-pane.transcript/github-references
  • 84 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

  • agent-pane.artifact-panel/versions (Apple System Colors, webkit): play: no element for button "Open preview"
  • agent-pane.artifact-panel/html (Apple System Colors, chromium): play: no element for button "Open preview"
  • agent-pane.artifact-panel/versions (Apple System Colors Light, chromium): play: no element for button "Open preview"
  • agent-pane.start-folder/home-question (Apple System Colors Light, chromium): play: no element for menuitemradio "/\/Users\/you$/"
  • agent-pane.start-folder/root-refused (Apple System Colors Light, chromium): play: no element for menuitemradio "/\/Users\/you$/"
  • agent-pane.start-folder/home-question (Apple System Colors Light, webkit): play: no element for menuitemradio "/\/Users\/you$/"
  • 181 more on the diff page

267 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

1463 unchanged · base 6b7ab55 · head 43ddf88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant