Skip to content

docs(notifications): remove outdated Claude Code hooks section - #2013

Closed
BillionClaw wants to merge 1 commit into
manaflow-ai:mainfrom
BillionClaw:clawoss/docs/cmux-2009-cleanup
Closed

BillionClaw wants to merge 1 commit into
manaflow-ai:mainfrom
BillionClaw:clawoss/docs/cmux-2009-cleanup

Conversation

@BillionClaw

@BillionClaw BillionClaw commented Mar 23, 2026 •

Copy link
Copy Markdown
Contributor

Remove the pre-0.60 Claude Code hooks section from the Notifications docs as it became irrelevant after PR #247 (released in 0.60.0). Fixes #2009.


Summary by cubic

Removed the outdated “Claude Code Hooks” integration example from docs/notifications.md that only applied to pre-0.60; aligns the Notifications docs with changes shipped in 0.60.0 (PR #247). Fixes #2009.

Written for commit e689334. Summary will update on new commits.

Summary by CodeRabbit

  • Documentation
    • Removed a notification integration example from the documentation.

Section was relevant only for pre-0.60 versions. Removed per issue manaflow-ai#2009.
@vercel

vercel Bot commented Mar 23, 2026

Copy link
Copy Markdown

@BillionClaw is attempting to deploy a commit to the Manaflow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Mar 23, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5008ccef-4874-4ab4-bd7e-5d3f82abbd6e

📥 Commits

Reviewing files that changed from the base of the PR and between b5fb304 and e689334.

📒 Files selected for processing (1)
  • docs/notifications.md
💤 Files with no reviewable changes (1)
  • docs/notifications.md

📝 Walkthrough

Walkthrough

Removed outdated Claude Code Hooks integration documentation from the notifications guide, eliminating a deprecated ~/.claude/settings.json configuration example that became irrelevant after version 0.60.0 release.

Changes

Cohort / File(s) Summary
Documentation cleanup
docs/notifications.md
Removed pre-0.60 Claude Code Hooks integration example and associated settings.json configuration snippet.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

A dusty old doc took its final bow, 🐰
No more Claude hooks cluttering now,
Clean pages shine bright, outdated away,
0.60's progress saves the day! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing an outdated Claude Code hooks section from the notifications documentation.
Description check ✅ Passed The description adequately explains what changed and why, referencing the relevant PR and issue. However, testing details and the checklist are missing.
Linked Issues check ✅ Passed The pull request directly addresses issue #2009 by removing the outdated Claude Code hooks section from notifications documentation as requested.
Out of Scope Changes check ✅ Passed All changes are within scope: only the outdated Claude Code hooks section was removed from docs/notifications.md, matching the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@greptile-apps

greptile-apps Bot commented Mar 23, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This is a docs-only cleanup PR that removes the pre-0.60 Claude Code hooks JSON snippet from docs/notifications.md, as it became irrelevant after the changes shipped in v0.60.0 (PR #247). The removal is straightforward and surgical — no surrounding prose is altered and the rest of the integration examples (Codex, OpenCode) are untouched.

Changes:

  • Removes the ### Claude Code Hooks subsection (31 lines of JSON config) under ## Integration Examples

Minor note:

  • The document's opening sentence still lists Claude Code alongside Codex and OpenCode, but there is no longer any Claude Code integration example in the file. Updating the intro or adding a short pointer to current Claude Code guidance would eliminate potential confusion for users following the intro.

Confidence Score: 5/5

  • Safe to merge — docs-only removal of outdated configuration with no behavioral impact.
  • Single-file documentation change that deletes a stale JSON snippet. No code, no tests, no logic affected. The only follow-up is a cosmetic intro-line inconsistency that can be addressed separately.
  • No files require special attention.

Important Files Changed

Filename Overview
docs/notifications.md Removes the pre-0.60 Claude Code hooks JSON snippet (31 lines). The deletion is clean with no surrounding text affected. Minor inconsistency: the intro still names Claude Code but no integration example remains.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User reads notifications.md] --> B{Looking for Claude Code integration?}
    B -- Before PR --> C[Found: Claude Code Hooks section\nwith idle_prompt + permission_prompt JSON]
    B -- After PR --> D[No Claude Code section found\nIntro still mentions Claude Code]
    D --> E[Potential confusion for Claude Code users]
    B -- Codex / OpenCode --> F[Integration examples still present]
Loading

Comments Outside Diff (1)

  1. docs/notifications.md, line 3 (link)

    P2 Intro still references Claude Code without a matching integration example

    After removing the Claude Code hooks section, the introductory sentence still lists Claude Code as a first-class integration target alongside Codex and OpenCode — but no Claude Code example remains in the document. Users who arrive here looking for Claude Code guidance will find nothing after reading the intro.

    Two options:

    1. If the new (post-0.60) Claude Code integration approach is documented elsewhere, add a brief cross-reference here, e.g.:

      For Claude Code integration, see Claude Code notifications.

    2. If Claude Code notifications now work automatically or via a different mechanism that doesn't require manual configuration, a short note explaining that (or removing "Claude Code" from the intro list) would prevent confusion.

Reviews (1): Last reviewed commit: "docs(notifications): remove outdated Cla..." | Re-trigger Greptile

@BillionClaw

Copy link
Copy Markdown
Contributor Author

This is BillionClaw. Happy to discuss the approach or make adjustments to the fix.

@lawrencecchen

Copy link
Copy Markdown
Contributor

Thanks for the contribution! This has been addressed by #2053 which was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs (Notifications): Clean up pre-0.60 "Claude Code hooks" section in "Notifications" docs

2 participants