Repository navigation
Calm motion batch 4: sidebar edges, group chips, Page Info, icon picker, transcript fades - #20003
Conversation
…picker Red for cx-2grmt batch 4: a wheel past the last space bounces the list, a new group's chip grows from 0.86, and the Page Info bubble and the icon picker appear and leave in one frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ot grow Red for cx-2grmt batch 4: a live transcript row appears in one frame under Reduce Motion, the Jump to Latest pill grows from 0.92, and the settings Reset button, notes and badges grow from 0.8 / 0.92. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
POLISH audit batch 4 (cx-2grmt): no bouncy or weird transforms, and Reduce Motion keeps fades. - A mouse wheel past the first or last space leaves the list still (no keyframe bounce). - A new group's chip arrives with its row's fade (no growth from 0.86). - The Page Info bubble and the icon picker open and close like every native popup, through a shared PopupFade (a reopen during the close keeps the popup; a close ends even when its owner is gone). - Live transcript rows fade without the rise under Reduce Motion, and the streaming text fade uses the motion token. - The settings Reset button, notes and badges and the Jump to Latest pill fade without growing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…xt fades under Reduce Motion Red for the review of cx-2grmt batch 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t fades under Reduce Motion Review of cx-2grmt batch 4: PopupFade.close stops taking clicks and hands key status back to the window under the popup when the fade starts (like SidebarGroupEditor.dismiss), and Page Info drops its key-elsewhere watcher on close. New streamed text and a highlighted code card keep their opacity fade under Reduce Motion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CmuxNextDaemon also declares SidebarSection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Without a screen Motion snaps the opening rows, so the chip's old scale-up never showed and the test could not go red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
|
Unclear: CI failed on
Not re-run automatically: Written by |
|
Agents: |
Gallery212 states changed: agent-pane.transcript/long-code, agent-pane.transcript/copy-last-code-block, agent-pane.edited-files-settings/defaults, agent-pane.artifact-panel/versions, agent-pane.transcript/shell-grouped-commands, ... · 2 new states · 14 broken states · 102 play checks failed Diff page and renders (the run's
206 more on the diff page. Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
495 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
…rue end With the chat font's fractional line heights (#26523) the transcript's end is fractional. WebKit floors a fractional scrollTop but rounds scrollHeight, so the end as written rested 1px short (agent-pane-jump-latest-motion webkit: fromEnd 1 after Jump to latest). settleFollowBottom now writes the end rounded up, which the browser clamps to its own end, and skips the write once the scroller is already there. test(webviews): the jump test reads the last row where it lays out. A row that arrives live rises 4px into place (cv-enter's translate, #20003). That is drawn only and never moves layout, and the turn footer arriving as the glide lands read as a row under the card.
Summary
POLISH motion audit, batch 4 (cx-2grmt). The rule is "No bouncy or weird transforms", and Reduce Motion keeps fades (motion.md rule 7).
PopupFade(openPopup/closePopup).SidebarGroupEditor.dismiss.These stay on the bead:
PaneContentView+PaintHold's blank pane after a 500 ms hold. It isn't a motion transform.check-motionhits:WindowMaterialView,AgentCursorLayer,HoverCardPanel, and the space slide's tokenized spring. This PR removes the four group-chip and bounce hits (12 → 8).Testing
Red proof
tmp/polish4-red-proofat 14ff310 (base plus only the test files). Green at 993d6ae. Fleetrun-swift-testing-suites.sh, both on display hosts.Red on aws-m4pro-8:
aWheelPastTheLastSpaceLeavesTheListStill: the list bounced.aNewGroupsChipFadesInWithoutGrowing:transform.scaleon the chip.theBubbleOpensAndClosesWithMotionandthePickerOpensAndClosesWithMotion: no open animation, gone at once on close, and (review) still taking clicks while closing.aReopenDuringTheCloseKeepsTheBubblepasses there too: an instant close had nothing to race.Green on aws-m4pro-9: all of these pass; 213 passed, 0 failed. The display-gated tests skip on display-less minis (aws-m4pro-1, -3, -4, -6), where a window with no screen applies its changes at once.
Web:
test/calm-motion.test.ts(browser) loads the real stylesheets in Chromium.noneunder Reduce Motion; the pill and settings scales were 0.92 and 0.8.bun run checkpasses.Release compile on 83ee9cd:
BUILD SUCCEEDED. Only test files changed after it. Concurrency, crash-ratchet, motion, scrollbar and god-file checks show only base hits.SidebarListViewis over its god-type budget on base (1022 lines); this PR shrinks it by one line.CI
react-apps-check: onlyagent-pane-peer-chatfails. It is a timing flake: the page took 25 s to load on the runner, so the running-turn timer read 30 s against a limit under 30 s. This PR doesn't touch the agent pane's timers.Review subagent: one medium (a fading popup kept keys and clicks) and two lows (Page Info's key-elsewhere watcher; two fades still cut under Reduce Motion). All are fixed with red tests above.
Changelog
Changed: Page Info and the icon picker fade open and closed, sidebar space paging no longer bounces at the ends, and under Reduce Motion new transcript content fades in instead of popping.
Proof
Motion changes, recorded by the red and green tests above.
🤖 Generated with Claude Code