Skip to content

webviews: agent-pane-seen waits for a slow first attach (no bead) - #19897

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
webviews-seen-cold-start
Oct 12, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
webviews-seen-cold-start

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

agent-pane-seen.test.ts went red on unrelated feat-cmux-next PRs: #19881, #19883, #19885 and #19831 in the last 6 h, 4 of the last 10 react-apps-check runs. Both cases failed together:

  • the pane tells acpmux whether it shows its chat: attach undefined at line 132. The test gave the first page 10 s to attach. Since ci: webviews dev server files run at once, each on its own warm Vite cache (no bead) #19831, dev server files run side by side, and on a busy runner the first page's cold modules load slowly, so its attach came later than that.
  • a pane hidden while its attach is in flight …: a knock-on failure. The first case threw before closing its page, so that page's late attach took the second case's held attach slot.

Fix:

  • The first attach gets 60 s; later waits keep their 10 s.
  • Each case closes its page even when it fails, so one failure can't cascade into the next case.
  • Red test: the stand-in daemon answers the first initialize after 11 s, reproducing the slow first page.

Testing

  • Red then green in this PR's react-apps-check: the red commit adds only the 11 s cold start.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Stabilizes the agent-pane-seen.test.ts flake on busy CI runners, where the first page's attach could arrive after the 10 s wait and its unclosed page would then steal the next test case's held-attach slot.

  • The first attach now gets 60 s; later waits keep their 10 s.
  • Each test case closes its page on failure, so one failure can't cascade into the next.
  • The red commit reproduces the slow cold start by answering the first initialize after 11 s.

Written for commit 8e632dc. Summary will update on new commits.

View guided diff Turn on auto-fix

Red: the stand-in answers the first initialize after 11 s, as a cold
dev server page on a busy runner reaches its attach (dev server files
run side by side since #19831). The test gives the attach 10 s, so it
fails, and its open page then takes the next test's held attach.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 148922bf-d763-40f8-bec2-b7492d5c6028

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on 8e632dca09.

CI passes on 8e632dca09 (run 38263785398 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

The first attach gets 60 s (its cold modules load slowly on a busy
runner); later waits keep 10 s. Each case closes its page even on a
failure, so a late attach cannot take the next case's held attach.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on 8e632dca09 (https://github.com/manaflow-ai/cmux/actions/runs/38263785398). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant