Repository navigation
webviews: agent-pane-seen waits for a slow first attach (no bead) - #19897
Conversation
Red: the stand-in answers the first initialize after 11 s, as a cold dev server page on a busy runner reaches its attach (dev server files run side by side since #19831). The test gives the attach 10 s, so it fails, and its open page then takes the next test's held attach. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
|
Passes: CI passes on CI passes on Written by |
The first attach gets 60 s (its cold modules load slowly on a busy runner); later waits keep 10 s. Each case closes its page even on a failure, so a late attach cannot take the next case's held attach. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Summary
agent-pane-seen.test.tswent red on unrelated feat-cmux-next PRs: #19881, #19883, #19885 and #19831 in the last 6 h, 4 of the last 10 react-apps-check runs. Both cases failed together:the pane tells acpmux whether it shows its chat:attachundefined at line 132. The test gave the first page 10 s to attach. Since ci: webviews dev server files run at once, each on its own warm Vite cache (no bead) #19831, dev server files run side by side, and on a busy runner the first page's cold modules load slowly, so its attach came later than that.a pane hidden while its attach is in flight …: a knock-on failure. The first case threw before closing its page, so that page's late attach took the second case's held attach slot.Fix:
initializeafter 11 s, reproducing the slow first page.Testing
Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Stabilizes the
agent-pane-seen.test.tsflake on busy CI runners, where the first page's attach could arrive after the 10 s wait and its unclosed page would then steal the next test case's held-attach slot.initializeafter 11 s.Written for commit 8e632dc. Summary will update on new commits.