Repository navigation
test: the Changes button's keycap is its tooltip's shortcut hint (no bead) - #19794
teamleaderleo wants to merge 1 commit into
Conversation
#19770 moved header keycaps out of the title into the tooltip's shortcut hint and updated chat-header-tooltips, but chat-header-changes still expected "Changes (⌃⇧⌘G)" as the title, so react-apps-check is red on feat-cmux-next for every PR (#19780, #19782, #19779). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Unclear: CI failed on
Not re-run automatically: Written by |
|
Agents: |
|
Superseded by #19805, which landed the same test fix on feat-cmux-next first. |
Summary
webviews/test/chat-header-changes.test.tsx:66fails on feat-cmux-next (bf3cac7):Expected "Changes (⌃⇧⌘G)", Received "Changes". It has been red inweb / react-apps-checkon every PR since 08:10Z (#19780, #19782, #19779).#19770 intentionally moved header keycaps out of
titleinto the tooltip's shortcut hint (data-tooltip-shortcut, drawn in secondary ink like the native tooltip). It updatedchat-header-tooltips.test.tsxbut not this older test. The test now asserts the new contract: titleChanges, shortcut hint⌃⇧⌘G.Testing
heavy --mem 4G bun test test/chat-header-changes.test.tsx test/chat-header-tooltips.test.tsx:bun run checkpasses.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Updates
chat-header-changes.test.tsxto match the tooltip behavior change from #19770, where the Changes button's keycap moved from thetitleattribute intodata-tooltip-shortcut. This fixes the failing test that had been red inreact-apps-checkonfeat-cmux-nextfor every PR.The test now asserts
titleis"Changes"anddata-tooltip-shortcutis"⌃⇧⌘G".Written for commit 885c9aa. Summary will update on new commits.