Skip to content

test: the Changes button's keycap is its tooltip's shortcut hint (no bead) - #19794

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
op-next-call-keys/header-changes-hint
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
op-next-call-keys/header-changes-hint

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

webviews/test/chat-header-changes.test.tsx:66 fails on feat-cmux-next (bf3cac7): Expected "Changes (⌃⇧⌘G)", Received "Changes". It has been red in web / react-apps-check on every PR since 08:10Z (#19780, #19782, #19779).

#19770 intentionally moved header keycaps out of title into the tooltip's shortcut hint (data-tooltip-shortcut, drawn in secondary ink like the native tooltip). It updated chat-header-tooltips.test.tsx but not this older test. The test now asserts the new contract: title Changes, shortcut hint ⌃⇧⌘G.

Testing

heavy --mem 4G bun test test/chat-header-changes.test.tsx test/chat-header-tooltips.test.tsx:

  • Red on feat-cmux-next bf3cac7: 0 pass, 1 fail, at the line above.
  • Green on this branch: 2 pass.

bun run check passes.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Updates chat-header-changes.test.tsx to match the tooltip behavior change from #19770, where the Changes button's keycap moved from the title attribute into data-tooltip-shortcut. This fixes the failing test that had been red in react-apps-check on feat-cmux-next for every PR.

The test now asserts title is "Changes" and data-tooltip-shortcut is "⌃⇧⌘G".

Written for commit 885c9aa. Summary will update on new commits.

View guided diff Turn on auto-fix

#19770 moved header keycaps out of the title into the tooltip's
shortcut hint and updated chat-header-tooltips, but chat-header-changes
still expected "Changes (⌃⇧⌘G)" as the title, so react-apps-check is red
on feat-cmux-next for every PR (#19780, #19782, #19779).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8012af97-8ad0-440e-8e34-5a79a6a7e797

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 12, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test/chat-find.test.ts/chat-find.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 885c9aae32 (run 38226213477 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

Copy link
Copy Markdown
Contributor

CI fast guards failed on 885c9aae32 (https://github.com/manaflow-ai/cmux/actions/runs/38226213477). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded by #19805, which landed the same test fix on feat-cmux-next first.

@teamleaderleo
teamleaderleo deleted the op-next-call-keys/header-changes-hint branch October 12, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant