Skip to content

cmux-next: New Worktree says Creating worktree… (cx-bopcl) - #19703

Merged
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
polish-worktree-create
Oct 12, 2026
Merged

teamleaderleo merged 6 commits into
feat-cmux-nextfrom
polish-worktree-create

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

POLISH for New Worktree in a new chat's folder menu (worktree UI polish, cx-bopcl). The host's git worktree add can take seconds, and the click looked dead until the folder changed. A muted line above the composer now says "Creating worktree…" until the chat starts there, the host refuses, or a newer folder pick replaces it.

The gallery can now delay a native answer (nativeDelayMs), which the new agent-pane.start-folder/worktree-creating play uses. The start-folder inProject fixture now counts as a new chat (sessionId: ""). Before this, its New Worktree plays never reached the folder menu.

Evidence

  • test/worktree-creating.test.ts, which runs that play. Red on the test commit (CI run 38207467330): the play clicks New Worktree and no Creating worktree… line appears. Green on c695ef8: react-apps-check passes.
  • Localization audit: one new key, worktree.creating, in all 21 locales, and strings.json is regenerated.

Changelog

  • Fixed: New Worktree shows "Creating worktree…" while the worktree is made.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 745cf093-7c48-420a-97d6-79cbe01e7d6b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test/gallery-coverage.test.ts/gallery-coverage.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on c695ef8a1d.

CI passes on c695ef8a1d (run 38209476123 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on c695ef8a1d (https://github.com/manaflow-ai/cmux/actions/runs/38209476123). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

@teamleaderleo
teamleaderleo force-pushed the polish-worktree-create branch 3 times, most recently from d522d91 to f7d3919 Compare October 12, 2026 05:08
teamleaderleo and others added 2 commits October 11, 2026 22:19
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo force-pushed the polish-worktree-create branch from f7d3919 to cce6559 Compare October 12, 2026 05:19
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

teamleaderleo and others added 3 commits October 11, 2026 22:34
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo merged commit 07baede into feat-cmux-next Oct 12, 2026
96 checks passed
@teamleaderleo
teamleaderleo deleted the polish-worktree-create branch October 12, 2026 06:07
@github-actions

Copy link
Copy Markdown
Contributor

Gallery

Review in feed

174 states changed: gallery.visual-media-board/all-previews, pages.settings/general-group-2, agent-pane.start-folder/worktree-refused, agent-pane.start-folder/new-worktree, pages.settings/browser-group-4, ... · 8 new states · 39 broken states · 80 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State Before · after
gallery.visual-media-board/all-previews (Apple System Colors Light, chromium)
gallery.visual-media-board/all-previews (Apple System Colors, chromium)
pages.settings/general-group-2 (Apple System Colors, webkit)
agent-pane.start-folder/worktree-refused (Apple System Colors Light, webkit)
agent-pane.start-folder/worktree-refused (Apple System Colors Light, chromium)
agent-pane.start-folder/new-worktree (Apple System Colors Light, webkit)

168 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

  • gallery.visual-media-board/all-previews: /wt/polish-worktree-create/?entry=gallery.visual-media-board#/gallery.visual-media-board/all-previews
  • pages.settings/general-group-2: /wt/polish-worktree-create/?entry=pages.settings#/pages.settings/general-group-2
  • agent-pane.start-folder/worktree-refused: /wt/polish-worktree-create/?entry=agent-pane.start-folder#/agent-pane.start-folder/worktree-refused
  • agent-pane.start-folder/new-worktree: /wt/polish-worktree-create/?entry=agent-pane.start-folder#/agent-pane.start-folder/new-worktree
  • pages.settings/browser-group-4: /wt/polish-worktree-create/?entry=pages.settings#/pages.settings/browser-group-4
  • pages.settings/browser-group-7: /wt/polish-worktree-create/?entry=pages.settings#/pages.settings/browser-group-7
  • 97 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

  • gallery.visual-media-board/all-previews (Apple System Colors Light, chromium): step 1 click button "Pause previews": layout shift 0.0002 (limit 0) · step 2 click button "Play previews": layout shift 0.0002 (limit 0) · play: waitFor did not hold within 5000 ms
  • gallery.visual-media-board/all-previews (Apple System Colors, chromium): step 1 click button "Pause previews": layout shift 0.0002 (limit 0) · step 2 click button "Play previews": layout shift 0.0002 (limit 0) · play: waitFor did not hold within 5000 ms
  • agent-pane.artifact-panel/versions (Apple System Colors Light, webkit): play: waitFor did not hold within 5000 ms
  • agent-pane.composer/model-menu-keyboard (Apple System Colors, chromium): step 1 click .acpmux-model .acpmux-picker-button: layout shift 0.0403 (limit 0.03)
  • agent-pane.composer-pickers/effort-press-drag-release (Apple System Colors Light, chromium): step 3 up text "High": layout shift 0.0010 (limit 0)
  • agent-pane.composer-pickers/effort-press-drag-release (Apple System Colors, chromium): step 3 up text "High": layout shift 0.0001 (limit 0)
  • 402 more on the diff page

499 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

6060 unchanged · base eb30538 · head c695ef8

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Batch queue: dropped from this batch, turns heavy tier red.

  • cmux-next checks (god files, concurrency, crash safety, l10n)

Next: fix, push.

teamleaderleo added a commit that referenced this pull request Oct 12, 2026
* test: a gallery format edit warns on a base coverage gap

#19699 and #19703 edited webviews/src/gallery/format.ts and went red on
ThemeFiles' missing gallery entry from #19688: format.ts is in the
coverage check's rules, so editing it owned every finding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: gallery format edits own only entry problems

The gallery coverage check listed validateEntries and its helpers
(format.ts, play.ts, experiments) as the whole check's own code, so a
pull request editing format.ts owned every base coverage gap. They now
decide only "the entries are valid"; the coverage tests keep the test
file, prScope.ts and entries.ts as their rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: entry constructors stay in the coverage check's rules

Review: format.ts also held componentEntry and the other entry
constructors, which build the covers and ids the coverage tests read.
They move to src/gallery/entry.ts (format.ts re-exports them, so no
importer changes) and that file stays a rule of every gallery test.
format.ts edits still own entry problems.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant