Repository navigation
cmux-tui pin: the PR probe waits for main's merge-tree publisher (cx-73f2) - #19616
Merged
Merged
Conversation
A same-repository PR's token gets 403 on the pin ref and the dispatch, so the probe failed same-tree at once (55 reds on 33 PRs in a day). Red: with every write refused, the probe fails even though a publish starts two seconds later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (cx-73f2) A same-repository pull request's token cannot create the pin ref or dispatch the artifacts run (403), so the probe failed same-tree at once. main's cmux-next-pr-merge-tree.yml (pull_request_target, the same push) now starts that publish; when the probe cannot start one itself it waits up to 90 s (CMUX_TUI_TREE_PUBLISHER_WAIT_SECONDS) for an artifacts run for the merge commit or the same tree and defers to it. Pull requests only: other callers keep their own waits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The first probe already waited up to 90 s for main's merge-tree publisher; a second wait only lengthened path_route on every miss. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the feat-cmux-next half of #19615, which adds main's merge-tree publisher (cx-73f2).
A same-repository PR's token can't create the
cmux-tui-pin-*ref or dispatch the artifacts run; it gets a 403. Sopin-cmux-tui.sh probefailedsame-tree cmux-tuiimmediately, 55 times on 33 PRs in a day.Once #19615 is on main, the same push also starts its
pull_request_targetpublisher. Now, when the probe can't start a publisher itself,await_outside_publisherwaits for one:CMUX_TUI_TREE_PUBLISHER_WAIT_SECONDS; path routing has 5 minutes).deferredpath: that run's publish starts the tree jobs.Testing
scripts/cmux-next/tests/pin-cmux-tui-probe.test.shgets a new case (d): every write is refused, and a publisher run appears 2 s later.pin-cmux-tui,-run-check,-resolve-newestand-host-targettests are green, and shellcheck is clean.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the
cmux-tuipin probe failing immediately on same-repository pull requests, whose token gets a 403 when creating the pin ref or dispatching the artifacts run.When the probe can't start a publisher itself, it now waits for main's
pull_request_targetmerge-tree publisher (started by the same push):CMUX_TUI_TREE_PUBLISHER_WAIT_SECONDS; path routing gets 5 minutes) for an artifacts run for the merge commit or one with the same tree, and defers to it.CMUX_TUI_TREE_PUBLISHER_WAIT_SECONDSto 0, since the first already waited.Adds test case (d): every write is refused, with a publisher run appearing 2s later; the probe defers to it, and fails bounded without one.
Written for commit 8057c76. Summary will update on new commits.