Repository navigation
web(devbox): devbox source drift base red, excuse the digest awaiting its rebake (no bead) - #19553
Merged
Merged
Conversation
… exactly (base red) vm-image-manifest's drift test failed every Web tests (1/4) shard since 0174c11, 0c91f5f and 2190154 changed the desktop sources (cx-6so.49 L1, the devbox metadata service) without promoting a bake: the defaults are the 20261003-130941 ladder, baked from 082484bccc9a. The test now excuses exactly this checkout's digest 4b22f8bbeb1b until that rebake; any further source change still fails, and a second test fails once the entry is not needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…fest:check too (review) The Cloud VM image contract job runs devbox:manifest:check before the manifest test, so the excuse lives in devbox-image-common.ts and both use it; promote stays strict. An entry now matches the baked digest as well as this checkout's, and the pending check runs per entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base red: the devbox drift check fails every
Web tests (1/4)run (27 of 27 in the last 24h, seen on #19549) and the Cloud VM image contract job'sdevbox:manifest:check. The test isweb/tests/vm-image-manifest.test.ts, "every default was baked from this checkout's devbox sources".The Freestyle defaults are the
freestyle-cmux-devbox-20261003-130941ladder, baked from desktop sources082484bccc9a. Walking the commits that touch the devbox sources shows the digest moved three times with no bake promoted:3690d43a9383at 0174c116421b50e38b1at 0c91f5f4b22f8bbeb1bat 2190154The first two are cx-6so.49 L1 and the last is the devbox metadata service.
The real fix is a rebake and promotion, which is an outward-facing Freestyle operation in Lawrence's image pipeline. This PR doesn't do that and doesn't change the drift logic. It adds
DEVBOX_AWAITING_REBAKEindevbox-image-common.ts. Each entry excuses exactly one drift: defaults baked frombakedagainst this checkout'scurrentdigest.devbox:manifest:checkand the manifest test filterdevboxSourceDriftProblemsthrough it.promotestays strict.Testing
vm-image-manifest.test.tsgives21 pass, 1 fail, andbun scripts/validate-devbox-ladder.tsexits 1 with 12 drift lines.vm-image-manifest.test.tsplusvm-devbox-image.test.tsgive61 pass, 0 fail. The validator exits 0 with "sources awaiting their rebake: desktop 4b22f8bbeb1b…".desktop/desktop-env.sh: 2 tests fail (the drift check and the pending check) and the validator exits 1. The guard still catches new drift.Correctness review: the first version excused the drift only in the test, so the contract job's validate step would have stayed red. That's fixed in b3d22b8, which also takes the review's nits (match the baked digest, check each entry on its own).
Changelog
none
🤖 Generated with Claude Code