Repository navigation
cx-13w3: an expanded row's hover pin runs Pin/Unpin Workspace - #19475
Conversation
On hover an expanded row shows a pin left of its menu button (Pin or Unpin by the workspace's pin state). It runs palette.toggleWorkspacePin on the row's workspace, the same action as the row menu, the palette and the CLI, so a layout tile or the daemon flag pins it as PinCommands decides. The App gives the sidebar the state and the action through SidebarModel.workspacePin; compact rows are unchanged. A workspace row's per-dequeue wiring moves to WorkspaceRowView.wire (SidebarListView is at its type budget). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
Summary
cx-13w3, slice 2 (expanded rows are opt-in; compact stays the default). An expanded row shows a pin on hover, left of its menu button, as in the T3 Code / Codex sidebars.
palette.toggleWorkspacePin) on the row's workspace. That is the action the row menu, the palette and the CLI run, soPinCommandsdecides whether a layout tile or the daemon flag pins it.SidebarModel.workspacePin. Without it the button never shows.WorkspaceRowView.wire(_:in:), becauseSidebarListViewis at its type budget.Strings:
sidebar.a11y.pinWorkspaceandsidebar.a11y.unpinWorkspace("Pin workspace" / "Unpin workspace", the button's accessibility label and tooltip), in all 21 locales, translations taken from the app's existingpins.pinWorkspace/pins.unpinWorkspace.Archive or settle from the brief is not in this slice: workspaces have no archive. Close stays on hover as before.
Testing
BUILD SUCCEEDED.Changelog
Added: expanded sidebar rows show a Pin button on hover.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Expanded sidebar rows now show a Pin/Unpin button on hover, left of the row menu. The button reads the workspace’s pin state and runs the same Pin/Unpin Workspace action (
palette.toggleWorkspacePin) used by the row menu, palette, and CLI. Compact rows are unchanged.The App supplies the pin state and toggle action via
SidebarModel.workspacePin; without it the button never shows. Per-dequeue wiring for workspace rows moved toWorkspaceRowView.wire(_:in:). Accessibility and tooltip strings were added for all 21 locales.Written for commit d45ec7c. Summary will update on new commits.
Showcase
Open the live gallery