-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix Ghostty resize_split keybind support #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lawrencecchen
merged 7 commits into
manaflow-ai:main
from
jorgitin02:issue-1882-resize-split
Mar 25, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
365306b
test: add resize_split regression coverage
jorgitin02 2e13c97
fix: implement Ghostty resize_split behavior
jorgitin02 75c9424
test: cover more resize_split cases
jorgitin02 1ad9017
test: deduplicate split snapshot helper
jorgitin02 413adbd
Merge remote-tracking branch 'origin/main' into pr-1899-resize-split
lawrencecchen 98d33eb
Resolve merge conflict: keep both splitNodes and waitForCondition hel…
lawrencecchen 8c5eec0
Merge remote-tracking branch 'origin/main' into pr-1899-resize-split
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TerminalControllerResizeSplitCandidate,ResizeSplitTrace, andresizeSplitCollectCandidatesare near-identical copies ofV2PaneResizeCandidate,V2PaneResizeTrace, andv2PaneResizeCollectCandidates(lines ~5853–5944 inTerminalController.swift). Similarly, the newsplitOrientation,requiresPaneInFirstChild, anddividerDeltaSignproperties onResizeDirectionare functionally identical to those on the privateV2PaneResizeDirectionenum.Now that
TabManager.resizeSplitis correctly implemented,TerminalController.v2PaneResizecould be simplified to call it (mappingV2PaneResizeDirectiontoResizeDirection), or both could share a common internal helper. Leaving these two paths to diverge independently will make future changes (e.g., changing clamp bounds, fixing a traversal bug) error-prone — they'd need to be applied in two places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the refactor out of this PR to keep the fix scope narrow. I addressed the missing coverage feedback in follow-up test commit
75c94247; if maintainers want the shared-helper consolidation, I’d treat that as a separate cleanup change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is worth consolidating. Keeping it out of this PR to avoid scope creep. The merge-with-main push (8c5eec0) resolves the conflict; a follow-up cleanup PR can unify the two paths.