Repository navigation
Add failing regression test for browser find focus #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
396aeb9
a30e698
af1175a
0e232cd
af93cc2
717ac6d
6844d25
97b2202
b35dfc4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12463,6 +12463,13 @@ private extension NSWindow { | |
| in window: NSWindow, | ||
| event: NSEvent? | ||
| ) -> CmuxWebView? { | ||
| // Browser find runs in the portal slot alongside the hosted WKWebView. | ||
| // Treat its native field editor chain as browser chrome, not as web content, | ||
| // so Cmd+F can move first responder into the find field while web focus is suppressed. | ||
| if BrowserWindowPortalRegistry.searchOverlayPanelId(for: responder, in: window) != nil { | ||
| return nil | ||
|
Comment on lines
+12469
to
+12470
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This new early check runs before any responder-type filtering, so every Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| if let webView = cmuxOwningWebView(for: responder) { | ||
| return webView | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.