Repository navigation
Show the 0.65.1 Cloud welcome whether Cloud is on or off - #18886
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughCloud welcome eligibility now uses the campaign’s seen-version marker and managed-device policy. The CI workflow updates guard routing and preflight checks. The nightly notarization workflow sets polling paths through the runner environment and adds polling test coverage. ChangesCloud welcome eligibility
CI guard workflow
Nightly notarization checks
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The welcome eligibility and CI guard routing appear ready for normal validation before merge. No actionable issue was established by this review. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (3 skipped: 3… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (24 passed)
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Cmux Cloud Persistent Session And Early Input | |
PASS. The reviewed diff changes Cloud welcome eligibility/tests and CI workflow routing only. It does not change Cloud terminal creation, cmux-tui clients, physical transports, PTY or shell readiness,… |
| Cmux Swift Actor Isolation | |
The production diff keeps CloudWelcomeWindowController as an intentionally @MainActor UI coordinator. Its existing nonisolated helper remains a synchronous launch-gating function; the diff only … |
| Cmux Swift Blocking Runtime | |
The production Swift diff only changes Cloud welcome eligibility inputs and comments. It adds no semaphore, blocking wait, sleep, delayed dispatch, polling, main-queue sync, or manual lock. The remain… |
| Cmux Browser Automation Off-Main | |
The pull request does not modify either browser-automation target: Sources/TerminalController.swift and `Packages/macOS/CmuxControlSocket/Sources/CmuxControlSocket/Wire/ControlCommandExecutionPolicy… |
| Cmux Expensive Synchronous Load | |
The only production Swift change is CloudWelcomeWindowController. Its @MainActor launch path now reads a UserDefaults marker and checks ManagedDevicePolicy.isEnforced(.disableCloud). The diff … |
| Cmux Cache Substitution Correctness | |
The changed production code does not substitute a cached value for a fresh authoritative read in a persistence, history, undo, or snapshot path. It still reads the campaign marker from the supplied `U… |
| Cmux No Hacky Sleeps | |
PASS: The pull request does not introduce or worsen a covered hacky sleep. The changed non-Swift files are GitHub Actions YAML and a test registry; the rule explicitly excludes workflow YAML. The runt… |
| Cmux Algorithmic Complexity | |
The production Swift change only replaces several boolean guards with one UserDefaults lookup and one ManagedDevicePolicy check. It adds no loop, collection scan, sort, filter, join, or batch rescan. … |
| Cmux Swift Concurrency | |
The Swift diff does not introduce or materially expand any flagged legacy concurrency pattern. shouldPresentAutomatically and presentIfNeeded remain synchronous (CloudWelcomeWindowController.swift… |
Cmux Swift @Concurrent |
|
PASS. The Swift diff changes only synchronous eligibility and test code. The changed controller methods are nonisolated synchronous functions, with no async, @concurrent, or new task boundary. T… |
| Cmux Swift Package Boundaries | |
The only production Swift change is in CloudWelcomeWindowController, an AppKit window controller that composes launch presentation with the app lifecycle. The diff changes a small campaign eligibili… |
| Cmux Swiftpm Lockfiles | |
The PR changes only two workflows, Cloud Swift sources/tests, and the test registry. No Package.swift, Package.resolved, .gitignore, or Xcode project files changed. The workflow diff contains no… |
| Cmux Swift Logging | |
The changed production Swift file only updates Cloud welcome eligibility and imports CmuxSettings. The diff adds no print, debugPrint, dump, NSLog, file/stdout diagnostics, Logger declaratio… |
| Cmux User-Facing Error Privacy | |
The pull request does not add or materially change a user-facing error, alert, command output, API error body, or recovery message. The Cloud controller diff changes presentation eligibility and comme… |
| Cmux Full Internationalization | |
The production Swift diff changes Cloud welcome eligibility and comments only. It adds no user-facing text and leaves the existing localized window title unchanged. The added test descriptions are tes… |
| Cmux Swiftui State Layout | |
PASS: The Swift diff changes Cloud welcome eligibility and tests only. It adds no ObservableObject, @Published, GeometryReader, lazy/list row store reference, or render-time state mutation. The unchan… |
| Cmux Architecture Rethink | |
The Swift change is a small eligibility correction with clear owners. shouldPresentAutomatically reads the campaign marker from UserDefaults and the managed DisableCloud state from `ManagedDevic… |
| Cmux Swift Auxiliary Window Close Shortcuts | |
The Swift diff changes Cloud welcome eligibility and test setup, not standalone window construction or close-shortcut routing. The existing CloudWelcomeWindowController already uses the stable `cmux… |
| Cmux Source Artifacts | |
PASS. The pull request changes only hand-written Swift source and tests, GitHub Actions workflow configuration, and the test registry. The diff adds no logs, screenshots, recordings, temporary directo… |
| Cmux No Test Or Debug Seam In Production Source | |
PASS — The PR changes only Sources/Cloud/CloudWelcomeWindowController.swift in production Swift. The diff does not add a #if DEBUG or test-build-guarded extension, debug/test-only member, or widen… |
| Title check | |
The title clearly and concisely describes the primary product change: showing the 0.65.1 Cloud welcome when Cloud is enabled or disabled. |
| Description check | |
The description provides a detailed summary, testing results, changelog entry, known UI-test limitation, and CI-repair context. It omits the explicit Summary, Proof, and Checklist headings, but the re… |
Full details: Docstring Coverage
Explanation
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (3 skipped: 3 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Restore the reviewed guard routing from 575ab74 while retaining newer Testbox and protected-signing checks. The existing reusable-workflow permission and structure regressions fail before this repair and pass after it. Co-authored-by: Austin Wang <38676809+austinywang@users.noreply.github.com>
Restore the deleted fast-guard test registration cleanup and nightly polling test registration. Resolve notarization receipt paths at runtime, where RUNNER_TEMP is defined, instead of using an invalid job-level runner context.
|
Passes: CI passes on CI passes on Written by |
|
|
Dogfood tours of
|
|
Merge receipt for |
11ff257 Show the 0.65.1 Cloud welcome whether Cloud is on or off (manaflow-ai#18886) # Conflicts: # .github/workflows/auto-resume-nightly-notarization.yml # .github/workflows/ci-guards.yml
1 participant
The 0.65.1 welcome currently skips people who have already turned Cloud on. This follow-up to merged #17243 shows the campaign once whether Cloud is on or off, except when an organization's MDM profile enforces
DisableCloud.Cloud starts off until the user turns it on; it has no rollout flag. The welcome now checks the managed policy directly and leaves the on/off preference untouched. Exact stable version
0.65.1, the marker written before presentation, and DEBUG/XCTest/UI-test suppression remain intact. Version0.64.25cannot trigger the campaign.Free users also see the welcome. Creating Cloud VMs still requires Pro: the existing welcome action sends signed-in Free users to “Upgrade to Pro” and signed-out users to sign-in.
The first CI run failed before any jobs because #18611's merge restored an older
ci-guards.ymlwhile retaining its new caller and tests. Restore the reviewed guard routing from575ab74328c, preserving the later Testbox and protected-signing checks. The first-classCI fast guardsjob remains authoritative; no validation is bypassed and no token permissions are widened.Also repair the stale test-registry entries from that merge and initialize nightly receipt paths in a runner step, where
RUNNER_TEMPis defined. The existing workflow linter rejected the previous job-levelrunner.tempexpressions; paths and notarization checks are unchanged.Testing
d0e95d6b5fband pass after the CI repair. All 36 guard-routing tests and 18 guard-runner tests pass; repository preflight passes its 16 applicable checks (Swift syntax skipped for the CI-only delta).DisableCloudpreference, exact release selection, marker upgrade/no-repeat, and dev/test suppression.337e4882586failed exactly once: Cloud on with no MDM block was incorrectly rejected. All other original CloudWelcome tests passed.571b8b76ca73ea187c9a576517a90100046f9596, including the Free-account upgrade CTA and all five bundled clips.acb409074603b24704b1e065completed onaws-m4pro-3. The published tagged artifact embeds571b8b76c; its SHA-256 is849c0d3a2ad9d3ef13091362980fc9e35de63c4ca07ad57eece0919c770dfa18. All five bundled MP4 files match the source bytes; workspace reset and cleanup receipts are present. Tagged build. This is a Debug artifact; stable-release eligibility is covered by the focused tests and production launch guards.childPID > 0launcher assertion during enumeration; the third succeeded unchanged on a healthy runner. The existing cleanup receipt repair remains owned by fix(ci): avoid app-host rsync metadata failures #18616.cmuxs-mac-mini-3-glaeda,cmuxs-mac-mini-5-glaeda,cmux11s-mac-mini-glaeda, andcmuxs-mac-mini-5-glaeda-1. The final failure reports an unlocked, awake console but cannot activate Finder; its frontmost-app diagnostics are[ NULL ]. Build and artifact preparation succeeded. No welcome assertion failed, and there is no current UI pass to claim. Fleet GUI recovery is needed before rerunning failed test job114057949055; no guards were weakened and no runner-policy override was applied.cmux11s-mac-mini-glaeda-1. That run confirmed socket readiness from real xcresult app stdout. It is historical evidence, not verification of this follow-up's head.48ba2090321ff4eb8222582ad1b7e03613d39d81; the worktree and submodules are clean.No UI strings, layouts, media or translations change.
Changelog
Fixed: The one-time 0.65.1 Cloud welcome also appears for people who have already turned Cloud on, unless MDM blocks Cloud.