Repository navigation
fix(nightly): use the resolved build commit after publication - #18716
Conversation
The publication moves the release tag to the resolved build commit, so the delta republish stale check must compare against it, and both delta jobs need the resolver. tests/test_nightly_cmux_tui_resolve.py already fails on base for the same jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The delta jobs checked out the tip and compared the release tag with it, but publication moves the tag to the resolved build commit. Whenever the build is behind the tip, every delta result was skipped as stale. The release notes head and the nightly-next recovery manifest and artifact name also used the tip instead of the commit that was built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37871997540 at 9e3a1a2 failed: cmux-next swift test. |
Summary
Base repair:
tests/test_nightly_cmux_tui_resolve.pyis red on feat-cmux-next. Nothing showed it, because ci-guards does not run for feat-cmux-next (a follow-up PR fixes that).The nightly builds at the resolved cmux-tui commit (
build_sha), and publication moves the release tag there. Several later uses still took the tip (decide.head_sha):generate-nightly-deltasandrepublish-nightly-deltaschecked out the tip. The republish stale check compared the release tag with the tip, so whenever the build was behind the tip, every delta result was skipped as stale. Both jobs now need the resolver and usebuild_sha.publish-nightlyrelease notes now usebuild_shaas their head, so the notes cover the commits actually built.build_sha,build_short_sha). The main auto-resume no longer continues nightly-next (Nightly continuation: never resume nightly-next on main's channel #18711), so no other consumer reads them.Main's NIGHTLY and RC run the same jobs, so the delta fix applies to them too. When the build is at the tip,
build_shaequals the tip and nothing changes.Testing
tests/test_nightly_cmux_tui_resolve.pyfails on origin/feat-cmux-next with 11 tip uses ("republish-nightly-deltas checks out ... not the resolved build commit", etc.). The red commit 6efe7fd extendstests/test_nightly_universal_build.shto require the resolver in both delta jobs and the stale check againstbuild_sha. It fails on base's nightly.yml ("post-publication delta generation must be matrixed, stale-guarded ...").Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes nightly delta generation and release notes to use the resolved build commit instead of the tip after publication.
The delta jobs checked out the tip and compared the release tag with it, but publication moves the tag to the resolved build commit. Whenever the build was behind the tip, every delta result was skipped as stale. Release notes heads and the nightly-next recovery manifest and artifact name also used the tip instead of the commit that was built.
build_sha; when the build is at the tip, behavior is unchanged.tests/test_nightly_universal_build.shrequires the resolver in both delta jobs and checks the stale guard againstbuild_sha.Written for commit aca51aa. Summary will update on new commits.
Note
Medium Risk
Changes nightly/RC Sparkle delta republish and release-note commit ranges; wrong SHA wiring could skip deltas or mis-attribute notes, but behavior matches when build_sha equals the tip.
Overview
Nightly publication can build at a resolved cmux-tui commit (
build_sha) while the branch tip moves ahead. This PR aligns downstream jobs that still useddecide.head_shawithresolve-nightly-cmux-tui-client.outputs.build_sha(andbuild_short_sha).generate-nightly-deltasandrepublish-nightly-deltasnow depend on the resolver, check outbuild_sha, and compare the channel release tag tobuild_shain the stale guard (so deltas are not skipped when the tag points at the built commit but the tip has moved).publish-nightlyrelease notes usebuild_shaasNOTES_HEAD. Notarization recovery JSON and artifact names record the built commit instead of the tip.tests/test_nightly_universal_build.shis updated to require the resolver in both delta jobs and the stale check againstbuild_sha.Reviewed by Cursor Bugbot for commit aca51aa. Bugbot is set up for automated code reviews on this repo. Configure here.