Skip to content

ci: remove the cmux-next generated autofix job - #18420

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
ci/remove-generated-autofix
Oct 7, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
ci/remove-generated-autofix

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The cmux-next generated autofix job (#17516) mints its push token from the glaeda route App. That App has no contents: write and will not be widened, so "Mint the autofix token" failed on every pull request with stale generated files. This PR removes the job.

cmux-next generated files still fails on stale files with the regenerate commands (scripts/cmux-next/regenerate-action-contracts.sh, scripts/cmux-next/ci-target-graph.py). It still uploads the regenerated files as the cmux-next-generated-patch artifact. The hint no longer mentions an autofix commit.

Testing

  • tests/test_cmux_next_checks_workflow.py: the new test checks that the job and the token mint are gone and that the stale-files step keeps both regenerate commands. It is red on 60f92db (narrowed in 308712d, because the side-route jobs still use the App) and green on 9063724. It replaces the two autofix job tests.
  • The other workflow test files fail the same number of tests before and after this change. Their base reds include the bundle-removal fallout that fix(cmux-next): finish the bundle removal in CI tests and routing #18409 fixes.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Removes the cmux-next generated autofix job, which failed on every stale pull request because its token source (the glaeda route App) has no contents: write permission.

The cmux-next generated files job still fails on stale generated files and prints the regenerate commands, and still uploads the regenerated files as the cmux-next-generated-patch artifact. The hints no longer mention an autofix commit, and the workflow tests replace the two autofix tests with one asserting the job is gone.

Migration

  • Maintainers on same-repository pull requests must regenerate stale files manually instead of pulling an autofix commit.

Written for commit cd806d5. Summary will update on new commits.

View guided diff Turn on auto-fix


Note

Low Risk
CI-only change: PR authors must regenerate stale cmux-next exports locally or from the artifact instead of pulling a bot commit; merge gates for generated files remain.

Overview
Removes the cmux-next generated autofix job because minting a push token from the glaeda route App failed on every stale PR (the App lacks contents: write and will not be widened).

The generated-files job behavior is unchanged in spirit: it still checks action surfaces and the CI target graph, regenerates on failure, uploads cmux-next-generated-patch, and fails with the regenerate commands. Failure messaging now points at the artifact instead of an autofix commit.

Workflow tests drop the two autofix job assertions and add test_stale_generated_files_fail_with_the_regenerate_hint_and_no_autofix. ci-target-graph.py docstring is updated to match.

Reviewed by Cursor Bugbot for commit cd806d5. Bugbot is set up for automated code reviews on this repo. Configure here.

teamleaderleo and others added 3 commits October 7, 2026 11:11
The generated autofix job mints a token from an App without contents: write,
so it fails on every stale PR. It goes away; the hint stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its token comes from the glaeda route App, which has no contents: write
and will not be widened, so "Mint the autofix token" failed on every
stale pull request. generated-files still fails with the regenerate
commands and uploads the regenerated files as an artifact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 28ff7f8b-aeaf-49a5-bda9-4f9fc0a6bcd2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blacksmith-sh

This comment has been minimized.

@teamleaderleo
teamleaderleo merged commit 1ef5f3c into feat-cmux-next Oct 7, 2026
50 of 53 checks passed
@teamleaderleo
teamleaderleo deleted the ci/remove-generated-autofix branch October 7, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant