Repository navigation
ci: remove the cmux-next generated autofix job - #18420
Merged
Merged
Conversation
The generated autofix job mints a token from an App without contents: write, so it fails on every stale PR. It goes away; the hint stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its token comes from the glaeda route App, which has no contents: write and will not be widened, so "Mint the autofix token" failed on every stale pull request. generated-files still fails with the regenerate commands and uploads the regenerated files as an artifact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cmux-next generated autofixjob (#17516) mints its push token from the glaeda route App. That App has no contents: write and will not be widened, so "Mint the autofix token" failed on every pull request with stale generated files. This PR removes the job.cmux-next generated filesstill fails on stale files with the regenerate commands (scripts/cmux-next/regenerate-action-contracts.sh,scripts/cmux-next/ci-target-graph.py). It still uploads the regenerated files as thecmux-next-generated-patchartifact. The hint no longer mentions an autofix commit.Testing
tests/test_cmux_next_checks_workflow.py: the new test checks that the job and the token mint are gone and that the stale-files step keeps both regenerate commands. It is red on 60f92db (narrowed in 308712d, because the side-route jobs still use the App) and green on 9063724. It replaces the two autofix job tests.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes the
cmux-next generated autofixjob, which failed on every stale pull request because its token source (the glaeda route App) has nocontents: writepermission.The
cmux-next generated filesjob still fails on stale generated files and prints the regenerate commands, and still uploads the regenerated files as thecmux-next-generated-patchartifact. The hints no longer mention an autofix commit, and the workflow tests replace the two autofix tests with one asserting the job is gone.Migration
Written for commit cd806d5. Summary will update on new commits.
Note
Low Risk
CI-only change: PR authors must regenerate stale cmux-next exports locally or from the artifact instead of pulling a bot commit; merge gates for generated files remain.
Overview
Removes the
cmux-next generated autofixjob because minting a push token from the glaeda route App failed on every stale PR (the App lackscontents: writeand will not be widened).The
generated-filesjob behavior is unchanged in spirit: it still checks action surfaces and the CI target graph, regenerates on failure, uploadscmux-next-generated-patch, and fails with the regenerate commands. Failure messaging now points at the artifact instead of an autofix commit.Workflow tests drop the two autofix job assertions and add
test_stale_generated_files_fail_with_the_regenerate_hint_and_no_autofix.ci-target-graph.pydocstring is updated to match.Reviewed by Cursor Bugbot for commit cd806d5. Bugbot is set up for automated code reviews on this repo. Configure here.