Repository navigation
cloud sidebar polish: hover, my devices copy and refresh, empty rows, tab switch glide #18303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e97ef46
test: cloud team chip reports hover through its menu anchor
lucasr1b f233680
cloud: hover on the team chip and the banner close buttons
lucasr1b 91c8e5e
cloud: team chip drops hover when it leaves its window
lucasr1b 13ca34d
test: cover immediate cloud team hover detach
austinywang dc6ab32
fix: keep cloud team hover across pointer lifecycle
austinywang d3de1ca
fix: use window coordinates for cloud hover sync
austinywang 5e718c9
test: keep hover fixture outside the anchor
austinywang fe6a9db
test: cover stale team hover events across reattachment
austinywang 85a0e84
fix: give cloud hover one lifecycle owner
austinywang 06b07fe
fix: preserve sidebar chip environment
austinywang 2cbe04e
fix: use supported sidebar appearance environment
austinywang 4659066
cloud sidebar: no other devices yet, refresh sits closer to the count
lucasr1b 06e5641
cloud sidebar: the devices row says no devices yet, settings keeps no…
lucasr1b 46354a9
right sidebar: open as pane keeps its slot on dock and feed so tab sw…
lucasr1b 9d733dd
right sidebar: open as pane stays on dock and feed, disabled with a t…
lucasr1b 1da10d6
Merge remote-tracking branch 'origin/cloud-hover' into cloud-devices-…
lucasr1b 2c6cefb
cloud sidebar: empty section lines sit closer to their headers
lucasr1b b96d540
right sidebar: quicker tab switch, label fade no longer trails the width
lucasr1b c43a810
cloud sidebar: my devices refresh only refreshes devices, cloud machi…
lucasr1b a54943a
cloud sidebar: empty section lines sit a little higher
lucasr1b 88a66f9
back out the empty line lifts and the quicker tab switch, trying them…
lucasr1b 727c49c
right sidebar: tab switch glides on the sidebar spring with one slidi…
lucasr1b 66a6976
right sidebar: one selection pill, the old copy leaves at once instea…
lucasr1b cc7800c
right sidebar: snappier tab switch, labels swap straight away
lucasr1b 360507c
cloud sidebar: empty lines get a real 18pt row instead of centering i…
lucasr1b dc16f52
Merge main (b8370eadb546) into cloud-typography
lucasr1b 91e1d58
keep the string catalog diff to our keys after merging main
lucasr1b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.